Harald Welte has submitted this change and it was merged.
Change subject: sgsnemu: created "pinghost" and "createif" modes for mutual
exclusion
..
sgsnemu: created "pinghost" and "createif" modes for mutual exclusion
No
Patch Set 1:
> Actually there is no any manual functions. It's all generated by
> ```
> gengetopt --version
> GNU gengetopt 2.22.6
> ```
> according to instructions in`cmdline.ggo`. I think it's easy to
> believe gengetopt here.
I'm sorry, I failed to realize on first sight that the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6196
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I196df7838212dcddecd64a64a6cba613b6cfced0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Patch Set 1:
some related propose.
I just get mind may be it's reasonable to add comment about what lindent to
use, something like:
```
# currently used Lindent could be found here:
#
https://github.com/torvalds/linux/blob/ee8900c9c7cc92db02b7edfa26ae3b2c9b2434f9/scripts/Lindent
```
because
Patch Set 1:
> Sorry, my reply was too quick. It seems you are using it. But then
> why do we need those strange manual function counting how often a
> certain option has been specified?
> Sorry, my reply was too quick. It seems you are using it. But then
> why do we need those strange
Patch Set 1:
At least from a quick glance at
https://www.gnu.org/software/gengetopt/gengetopt.html#Mode-options it seems
that gengetopt has support for mutually exclusive options. Did you investigate
that? If we cannot use it for some reason, please include the reason in the
changelog.
--
Patch Set 1:
I agree with the logic change as such, but I'm surprised that the gengetopt
code doesn't already have some kind of support for mutual exclusion. Did you
check if it has any support for it?
--
To view, visit https://gerrit.osmocom.org/6196
To unsubscribe, visit
Patch Set 1:
some cli output for understanding
## original
```
ubuntu@test:~/osmo-ggsn$ sudo sgsnemu --listen 10.121.0.18 --remote
93.124.95.120 --contexts 1 --apn internet.ge.beeline.net --imsi
282040234567890 --rai=282.04.0001.0001 --nsapi=5 --qos=34824735 --charging=2
--createif
Review at https://gerrit.osmocom.org/6196
sgsnemu: created "pinghost" and "createif" modes for mutual exclusion
No warnings when used options from "pinghost" and "createif" groups
in a same time. sgsnemu created tun0 interface and send pings inside
G-PDU, but didn't calculate replys. Added
