osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
[MERGED] osmo-hlr[master]: tests/auc: Don't require python3
Harald Welte has submitted this change and it was merged. Change subject: tests/auc: Don't require python3 .. tests/auc: Don't require python3 Our jenkins buildslave does not have python3 installed so call python2 instead. Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Ticket: SYS#3322 --- M debian/control M tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 571c24e..934abea 100644 --- a/debian/control +++ b/debian/control @@ -8,7 +8,7 @@ dh-systemd (>= 1.5), autotools-dev, pkg-config, - python3, + python2.7, libosmocore-dev, libosmo-abis-dev, libosmo-netif-dev, diff --git a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py index 0efa7ac..3a1c2b1 100755 --- a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py +++ b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python2 # Convert test sets pasted from 3GPP TS 55.205 to C code. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: I think we already have some tests disabled on FreeBSD in some project. If so, than we can do the same here (if the tests would actually fail of course). -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/2825/4/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py File tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py: Line 2 > since the code seems to work with python2 as well as python3, why not go fo I remember that in an unrelated patch this caused problems in the FreeBSD build slave. The solution then was to explicitly pick python2. I dimly remember that I suggested to just provide a symlink from python to python2 on the build slave, but I think Holger had a reason to not do so. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: Yes
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: FYI: I've created OS#2334 to track jenkins build slave package updates. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: > why not go for python without specifying a version number here? Good idea - in this case we don't have change debian/control: AFAIK jenkins buildslaves are not used for making .deb packages anyway and OBS have no problems with python3. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/2825/4/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py File tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py: Line 2 since the code seems to work with python2 as well as python3, why not go for python without specifying a version number here? -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: Yes
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: > I can't seem to install it That itself seems like much bigger issue which we have to resolve sooner or later anyway. Is there ticket for that? -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 4: Unfortunately I can't seem to install it, no. I have updated the patch to include the requirements for python2(.7) in the debian package. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 4 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: daniel Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 3: > otherwise py3 would be required on NITB hardware Why is that? NITB hardware uses Debian? I think we should just install python3 on buildslave - it should be just 1 command and eventually we'll have to migrate to it anyway. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 3: Code-Review+1 unless someone thinks we should rather require py3, I agree. Also because otherwise py3 would be required on NITB hardware. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: neels Gerrit-HasComments: No
osmo-hlr[master]: tests/auc: Don't require python3
Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/2825/3//COMMIT_MSG Commit Message: Line 10: instead. Which build slave is that? can't we just install python3? -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: neels Gerrit-HasComments: Yes
[PATCH] osmo-hlr[master]: tests/auc: Don't require python3
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2825 to look at the new patch set (#3). tests/auc: Don't require python3 Our jenkins buildslave does not have python3 installed so call python2 instead. Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Ticket: SYS#3322 --- M debian/control M tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/25/2825/3 diff --git a/debian/control b/debian/control index 571c24e..934abea 100644 --- a/debian/control +++ b/debian/control @@ -8,7 +8,7 @@ dh-systemd (>= 1.5), autotools-dev, pkg-config, - python3, + python2.7, libosmocore-dev, libosmo-abis-dev, libosmo-netif-dev, diff --git a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py index 0efa7ac..3a1c2b1 100755 --- a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py +++ b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python2 # Convert test sets pasted from 3GPP TS 55.205 to C code. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels
[PATCH] osmo-hlr[master]: tests/auc: Don't require python3
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2825 to look at the new patch set (#2). tests/auc: Don't require python3 Our jenkins buildslave does not have python3 installed so call python2 instead. Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Ticket: SYS#3322 --- M tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/25/2825/2 diff --git a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py index 0efa7ac..3a1c2b1 100755 --- a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py +++ b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python2 # Convert test sets pasted from 3GPP TS 55.205 to C code. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 2 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder
[PATCH] osmo-hlr[master]: tests/auc: Don't require python3
Review at https://gerrit.osmocom.org/2825 tests/auc: Don't require python3 Our jenkins buildslave does not have python3 installed so call python instead of any specific version. Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Ticket: SYS#3322 --- M tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/25/2825/1 diff --git a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py index 0efa7ac..058113c 100755 --- a/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py +++ b/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python # Convert test sets pasted from 3GPP TS 55.205 to C code. -- To view, visit https://gerrit.osmocom.org/2825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: daniel
