osmo-mgw[master]: mgcp_client: cosmetic: clean up SDP params parsing

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6639 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf1df761270777a142bc8ace75f2a10918314f73 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit

[MERGED] osmo-mgw[master]: mgcp_client: cosmetic: clean up SDP params parsing

2018-02-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mgcp_client: cosmetic: clean up SDP params parsing .. mgcp_client: cosmetic: clean up SDP params parsing The mgcp_response_parse_params() is in a jumble.

[PATCH] osmo-mgw[master]: mgcp_client: cosmetic: clean up SDP params parsing

2018-02-21 Thread Neels Hofmeyr
mgcp_client: cosmetic: clean up SDP params parsing The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic issues: - Move assertion of r->body close to its first use. - Instead of a talloc_zero and osmo_strlcpy dance, simply use talloc_strdup(). - Drop the first unused inv

[PATCH] osmo-mgw[master]: mgcp_client: cosmetic: clean up SDP params parsing

2018-02-21 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6639 mgcp_client: cosmetic: clean up SDP params parsing The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic issues: - Move assertion of r->body close to its first use. - Instead of a talloc_zero and osmo_strlcpy dance, simply use