[MERGED] osmo-msc[master]: libmsc/ussd.c: cosmetic: correct log level and message

2018-04-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged.

Change subject: libmsc/ussd.c: cosmetic: correct log level and message
..


libmsc/ussd.c: cosmetic: correct log level and message

Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
---
M src/libmsc/ussd.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/ussd.c b/src/libmsc/ussd.c
index 748cfbb..ab59571 100644
--- a/src/libmsc/ussd.c
+++ b/src/libmsc/ussd.c
@@ -72,7 +72,8 @@
gh = msgb_l3(msg);
rc = gsm0480_decode_ss_request(gh, msgb_l3len(msg), &req);
if (!rc) {
-   DEBUGP(DMM, "Unhandled SS\n");
+   LOGP(DMM, LOGL_ERROR, "SS/USSD message parsing error, "
+   "rejecting request...\n");
rc = gsm0480_send_ussd_reject(conn, &req);
return rc;
}

-- 
To view, visit https://gerrit.osmocom.org/7675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 


osmo-msc[master]: libmsc/ussd.c: cosmetic: correct log level and message

2018-04-09 Thread Harald Welte

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-HasComments: No


[PATCH] osmo-msc[master]: libmsc/ussd.c: cosmetic: correct log level and message

2018-04-09 Thread Vadim Yanitskiy
Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7675

to look at the new patch set (#3).

libmsc/ussd.c: cosmetic: correct log level and message

Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
---
M src/libmsc/ussd.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/75/7675/3

diff --git a/src/libmsc/ussd.c b/src/libmsc/ussd.c
index 748cfbb..ab59571 100644
--- a/src/libmsc/ussd.c
+++ b/src/libmsc/ussd.c
@@ -72,7 +72,8 @@
gh = msgb_l3(msg);
rc = gsm0480_decode_ss_request(gh, msgb_l3len(msg), &req);
if (!rc) {
-   DEBUGP(DMM, "Unhandled SS\n");
+   LOGP(DMM, LOGL_ERROR, "SS/USSD message parsing error, "
+   "rejecting request...\n");
rc = gsm0480_send_ussd_reject(conn, &req);
return rc;
}

-- 
To view, visit https://gerrit.osmocom.org/7675
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If6c270fae54ce79c2708c99d7762ce6ff71f43d9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy