osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7796 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf17f270cdeb8153036eda3de274dd163bbff7e6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sms_queue: fix use-after-free on 'pending' .. sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call

[PATCH] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call sms_pending_free(pending) and then in the next line still dereference the pending->sms_id member. This bug was introduced in January with Change-Id: I3749855fe25d9d4e37ec96b0c2bffbc692b66a78 and

[PATCH] osmo-msc[master]: sms_queue: fix use-after-free on 'pending'

2018-04-14 Thread Harald Welte
Review at https://gerrit.osmocom.org/7796 sms_queue: fix use-after-free on 'pending' This bug is super obvious: We cannot first call sms_pending_free(pending) and then in the next line still dereference the pending->sms_id member. Change-Id: Ibf17f270cdeb8153036eda3de274dd163bbff7e6 Closes: