[MERGED] osmo-sgsn[master]: .gitignore: Add m4 files
Harald Welte has submitted this change and it was merged. Change subject: .gitignore: Add m4 files .. .gitignore: Add m4 files Existing m4/ax_check_compile_flag.m4 is skipped from the list of ignored files. Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 5f6aee2..7879088 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,8 @@ #configure aclocal.m4 autom4te.cache/ +m4/*.m4 +!m4/ax_*.m4 config.log config.status config.guess -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy
osmo-sgsn[master]: .gitignore: Add m4 files
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No
[PATCH] osmo-sgsn[master]: .gitignore: Add m4 files
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6389 to look at the new patch set (#2). .gitignore: Add m4 files Existing m4/ax_check_compile_flag.m4 is skipped from the list of ignored files. Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/89/6389/2 diff --git a/.gitignore b/.gitignore index 5f6aee2..7879088 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,8 @@ #configure aclocal.m4 autom4te.cache/ +m4/*.m4 +!m4/ax_*.m4 config.log config.status config.guess -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy
osmo-sgsn[master]: .gitignore: Add m4 files
Patch Set 1: > (1 comment) > > You should either remove the remaining m4 file or add it as > !pattern to gitignore. Max is right here. This was I would follow the way of libosmocore: m4/*.m4 !m4/ax_*.m4 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: No
osmo-sgsn[master]: .gitignore: Add m4 files
Patch Set 1: Code-Review-1 (1 comment) You should either remove the remaining m4 file or add it as !pattern to gitignore. https://gerrit.osmocom.org/#/c/6389/1/.gitignore File .gitignore: Line 24: m4/lt~obsolete.m4 > Agreed. That'd be wrong: git ls-files m4 m4/ax_check_compile_flag.m4 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: Yes
osmo-sgsn[master]: .gitignore: Add m4 files
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6389/1/.gitignore File .gitignore: Line 24: m4/lt~obsolete.m4 > I think, you can use a wildcard here ;) Agreed. -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: Yes
osmo-sgsn[master]: .gitignore: Add m4 files
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6389/1/.gitignore File .gitignore: Line 24: m4/lt~obsolete.m4 I think, you can use a wildcard here ;) m4/*.m4 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-HasComments: Yes
[PATCH] osmo-sgsn[master]: .gitignore: Add m4 files
Review at https://gerrit.osmocom.org/6389 .gitignore: Add m4 files Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 --- M .gitignore 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/89/6389/1 diff --git a/.gitignore b/.gitignore index 5f6aee2..3a254f8 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,11 @@ #configure aclocal.m4 autom4te.cache/ +m4/libtool.m4 +m4/ltoptions.m4 +m4/ltsugar.m4 +m4/ltversion.m4 +m4/lt~obsolete.m4 config.log config.status config.guess -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol
