osmo-trx[master]: deb: remove unused dependency

[Holger Freyther]

Patch Set 2:

> (2 comments)

The "yes" means. This part of the patch is good. And the second part is that 
debian will extract the library dependencies from binaries and then will 
look-up which installed package provides them and will then add them to the 
depends. This is done with the macro/command/variable I have cited.

One example in OpenBSC.. We don't need to manually depend on libdbi.so.X as we 
link to it.. but as we need the libdbd sqlite3 plugin we will need to manually 
add it (no direct linking)

-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 
Gerrit-HasComments: No

osmo-trx[master]: deb: remove unused dependency

[Max]

Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/3079/2/debian/control
File debian/control:

Line 8
> yes
Could you elaborate? It's much easier to follow up on feedback which consists 
of entire sentences.


Line 22: Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
> That is wrong. ${shlibs:Depends} will add dependencies for all libraries li
You mean we can simply drop libsqlite3-0 in here?


-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 
Gerrit-HasComments: Yes

osmo-trx[master]: deb: remove unused dependency

[Holger Freyther]

Patch Set 2:

(2 comments)

So a -1 from me.

https://gerrit.osmocom.org/#/c/3079/2/debian/control
File debian/control:

Line 8
yes


Line 22: Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
That is wrong. ${shlibs:Depends} will add dependencies for all libraries linked 
against.. e.g. the package name might be libsqlire3-1 in the future?


-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 
Gerrit-HasComments: Yes

[MERGED] osmo-trx[master]: deb: remove unused dependency

[Max]

Max has submitted this change and it was merged.

Change subject: deb: remove unused dependency
..


deb: remove unused dependency

The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to match.

Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Related: OS#1929
---
M debian/control
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tom Tsou: Looks good to me, approved
  Alexander Chemeris: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/debian/control b/debian/control
index 0e3b714..12da64a 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,6 @@
 Build-Depends: debhelper (>= 9),
autotools-dev,
autoconf-archive,
-   libdbd-sqlite3,
libsqlite3-dev,
pkg-config,
dh-autoreconf,
@@ -20,7 +19,7 @@
 
 Package: osmo-trx
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libdbd-sqlite3
+Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
 Description: SDR transceiver that implements Layer 1 of a GSM BTS
  OsmoTRX is a software-defined radio transceiver that implements the Layer 1
  physical layer of a BTS comprising the following 3GPP specifications:

-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 

osmo-trx[master]: deb: remove unused dependency

[Tom Tsou]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou 
Gerrit-HasComments: No

osmo-trx[master]: deb: remove unused dependency

[Alexander Chemeris]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Ivan Kluchnikov 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou 
Gerrit-HasComments: No

[PATCH] osmo-trx[master]: deb: remove unused dependency

[Max]

Review at  https://gerrit.osmocom.org/3079

deb: remove unused dependency

The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to match.

Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Related: OS#1929
---
M debian/control
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/79/3079/1

diff --git a/debian/control b/debian/control
index 0e3b714..12da64a 100644
--- a/debian/control
+++ b/debian/control
@@ -5,7 +5,6 @@
 Build-Depends: debhelper (>= 9),
autotools-dev,
autoconf-archive,
-   libdbd-sqlite3,
libsqlite3-dev,
pkg-config,
dh-autoreconf,
@@ -20,7 +19,7 @@
 
 Package: osmo-trx
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libdbd-sqlite3
+Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
 Description: SDR transceiver that implements Layer 1 of a GSM BTS
  OsmoTRX is a software-defined radio transceiver that implements the Layer 1
  physical layer of a BTS comprising the following 3GPP specifications:

-- 
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max