osmo-ttcn3-hacks[master]: MGCP: remove hack to fake SDP

2018-02-08 Thread Harald Welte 

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/6323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-ttcn3-hacks[master]: MGCP: remove hack to fake SDP

2018-02-08 Thread Harald Welte 
Harald Welte has submitted this change and it was merged.

Change subject: MGCP: remove hack to fake SDP
..


MGCP: remove hack to fake SDP

A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3 from accepting the SDP data that
was generated by the IUT. The problem is now fixed and the
hack can be removed.

- remove hack

Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Related: OS#2818
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 51aebd2..8193a8d 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -207,9 +207,6 @@
g_media.mgcp_conn[cid].peer.port_nr := 
sdp.media_list[0].media_field.ports.port_number;
} else {
setverdict(fail, "MDCX has no [recognizable] SDP");
-   /* HACK HACK HACK */
-   g_media.mgcp_conn[cid].peer.host := "8.8.8.8";
-   g_media.mgcp_conn[cid].peer.port_nr := 2342;
}
var MgcpConnState mgcp_conn := g_media.mgcp_conn[cid];
sdp := valueof(ts_SDP(mgcp_conn.peer.host, mgcp_conn.peer.host, 
"foo", "21",

-- 
To view, visit https://gerrit.osmocom.org/6323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-ttcn3-hacks[master]: MGCP: remove hack to fake SDP

2018-02-08 Thread dexter 

Review at  https://gerrit.osmocom.org/6323

MGCP: remove hack to fake SDP

A problem with the parameter ordering inside the mgcp-client
(osmo-mgw) prevented TTCN3 from accepting the SDP data that
was generated by the IUT. The problem is now fixed and the
hack can be removed.

- remove hack

Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Related: OS#2818
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/23/6323/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 51aebd2..8193a8d 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -207,9 +207,6 @@
g_media.mgcp_conn[cid].peer.port_nr := 
sdp.media_list[0].media_field.ports.port_number;
} else {
setverdict(fail, "MDCX has no [recognizable] SDP");
-   /* HACK HACK HACK */
-   g_media.mgcp_conn[cid].peer.host := "8.8.8.8";
-   g_media.mgcp_conn[cid].peer.port_nr := 2342;
}
var MgcpConnState mgcp_conn := g_media.mgcp_conn[cid];
sdp := valueof(ts_SDP(mgcp_conn.peer.host, mgcp_conn.peer.host, 
"foo", "21",

-- 
To view, visit https://gerrit.osmocom.org/6323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic37f78c2676e7c98144f10e9f3b55bc9651a4f7c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: dexter