osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Patch Set 2: I thought you're adding this to the global .gitignore. Let's please do that, not a msc-specific one. The names of the symlinked files are the same in all directories anyway. We must of course then excempt any library/*.ttcn and the cc files that we have all over the repo, too. -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: dexter Gerrit-HasComments: No
osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Patch Set 2: The "git ls-files msc" does not show any .cc or .hh files so no negation needed in this subdirectory yet. Am I missing something? -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: dexter Gerrit-HasComments: No
osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Patch Set 2: Code-Review-2 How would this work? Where are your negation rules to ensure we actually don't ignore those .cc / .hh files that we have in this repository? See my example, or otherwise explain why it's not needed. -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-HasComments: No
[PATCH] osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6285 to look at the new patch set (#2). MSC: ignore symlinks and build byproducts Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 --- A msc/.gitignore 1 file changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/6285/2 diff --git a/msc/.gitignore b/msc/.gitignore new file mode 100644 index 000..6866bf4 --- /dev/null +++ b/msc/.gitignore @@ -0,0 +1,69 @@ +BSC_ConnectionHandler +BSSAP_Adapter.ttcn +BSSAP_CodecPort.ttcn +BSSAP_Types.ttcn +BSSMAP_Emulation.ttcn +BSSMAP_Templates.ttcn +GSM_Types.ttcn +GSUP_Emulation.ttcn +GSUP_Types.ttcn +General_Types.ttcn +IPA_CodecPort.ttcn +IPA_CodecPort_CtrlFunct.ttcn +IPA_Emulation.ttcn +IPA_Types.ttcn +IPL4asp_Functions.ttcn +IPL4asp_PortType.ttcn +IPL4asp_Types.ttcn +L3_Templates.ttcn +M3UA_Emulation.ttcn +M3UA_Types.ttcn +MGCP_CodecPort.ttcn +MGCP_CodecPort_CtrlFunct.ttcn +MGCP_Emulation.ttcn +MGCP_Templates.ttcn +MGCP_Types.ttcn +MNCC_CodecPort.ttcn +MNCC_Emulation.ttcn +MNCC_Types.ttcn +MSC_Tests +MTP3asp_PortType.ttcn +MTP3asp_Types.ttcn +Makefile +MobileL3_CC_Types.ttcn +MobileL3_CommonIE_Types.ttcn +MobileL3_GMM_SM_Types.ttcn +MobileL3_MM_Types.ttcn +MobileL3_RRM_Types.ttcn +MobileL3_SMS_Types.ttcn +MobileL3_SS_Types.ttcn +MobileL3_Types.ttcn +Native_Functions.ttcn +Osmocom_CTRL_Adapter.ttcn +Osmocom_CTRL_Functions.ttcn +Osmocom_CTRL_Types.ttcn +Osmocom_Types.ttcn +Osmocom_VTY_Functions.ttcn +RSL_Types.ttcn +RTP_CodecPort.ttcn +RTP_Types.ttcn +SCCP_Emulation.ttcn +SCCP_Mapping.ttcn +SCCP_Mapping.ttcnpp +SCCP_Types.ttcn +SCCPasp_Types.ttcn +SCTPasp_PortType.ttcn +SCTPasp_Types.ttcn +SDP_Types.ttcn +Socket_API_Definitions.ttcn +TCCConversion_Functions.ttcn +TCCInterface_Functions.ttcn +TELNETasp_PortType.ttcn +UD_PortType.ttcn +UD_Types.ttcn +*.cc +*.hh +*.c +*.h +*.y +*.l -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter
osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Patch Set 1: gitignore claims to support negation of previously-excluded files, so something like *.cc *.hh !MNCC_EncDec.cc should work. This would allow us to list those few .cc files that are not generated, rather than listing each and every cc or hh file that is generated. -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-HasComments: No
[PATCH] osmo-ttcn3-hacks[master]: MSC: ignore symlinks and build byproducts
Review at https://gerrit.osmocom.org/6285 MSC: ignore symlinks and build byproducts Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 --- A msc/.gitignore 1 file changed, 214 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/6285/1 diff --git a/msc/.gitignore b/msc/.gitignore new file mode 100644 index 000..56567d2 --- /dev/null +++ b/msc/.gitignore @@ -0,0 +1,214 @@ +BSC_ConnectionHandler +BSC_ConnectionHandler.cc +BSC_ConnectionHandler.hh +BSSAP_Adapter.cc +BSSAP_Adapter.hh +BSSAP_Adapter.ttcn +BSSAP_CodecPort.cc +BSSAP_CodecPort.hh +BSSAP_CodecPort.ttcn +BSSAP_Types.cc +BSSAP_Types.hh +BSSAP_Types.ttcn +BSSMAP_Emulation.cc +BSSMAP_Emulation.hh +BSSMAP_Emulation.ttcn +BSSMAP_Templates.cc +BSSMAP_Templates.hh +BSSMAP_Templates.ttcn +GSM_Types.cc +GSM_Types.hh +GSM_Types.ttcn +GSUP_Emulation.cc +GSUP_Emulation.hh +GSUP_Emulation.ttcn +GSUP_Types.cc +GSUP_Types.hh +GSUP_Types.ttcn +General_Types.cc +General_Types.hh +General_Types.ttcn +IPA_CodecPort.cc +IPA_CodecPort.hh +IPA_CodecPort.ttcn +IPA_CodecPort_CtrlFunct.cc +IPA_CodecPort_CtrlFunct.hh +IPA_CodecPort_CtrlFunct.ttcn +IPA_CodecPort_CtrlFunctDef.cc +IPA_Emulation.cc +IPA_Emulation.hh +IPA_Emulation.ttcn +IPA_Types.cc +IPA_Types.hh +IPA_Types.ttcn +IPL4asp_Functions.cc +IPL4asp_Functions.hh +IPL4asp_Functions.ttcn +IPL4asp_PT.cc +IPL4asp_PT.hh +IPL4asp_PortType.cc +IPL4asp_PortType.hh +IPL4asp_PortType.ttcn +IPL4asp_Types.cc +IPL4asp_Types.hh +IPL4asp_Types.ttcn +IPL4asp_discovery.cc +IPL4asp_protocol_L234.hh +L3_Templates.cc +L3_Templates.hh +L3_Templates.ttcn +M3UA_Emulation.cc +M3UA_Emulation.hh +M3UA_Emulation.ttcn +M3UA_Types.cc +M3UA_Types.hh +M3UA_Types.ttcn +MGCP_CodecPort.cc +MGCP_CodecPort.hh +MGCP_CodecPort.ttcn +MGCP_CodecPort_CtrlFunct.cc +MGCP_CodecPort_CtrlFunct.hh +MGCP_CodecPort_CtrlFunct.ttcn +MGCP_CodecPort_CtrlFunctDef.cc +MGCP_Emulation.cc +MGCP_Emulation.hh +MGCP_Emulation.ttcn +MGCP_Templates.cc +MGCP_Templates.hh +MGCP_Templates.ttcn +MGCP_Types.cc +MGCP_Types.hh +MGCP_Types.ttcn +MNCC_CodecPort.cc +MNCC_CodecPort.hh +MNCC_CodecPort.ttcn +MNCC_Emulation.cc +MNCC_Emulation.hh +MNCC_Emulation.ttcn +MNCC_EncDec.cc +MNCC_Types.cc +MNCC_Types.hh +MNCC_Types.ttcn +MSC_Tests +MSC_Tests.cc +MSC_Tests.hh +MTP3asp_PortType.cc +MTP3asp_PortType.hh +MTP3asp_PortType.ttcn +MTP3asp_Types.cc +MTP3asp_Types.hh +MTP3asp_Types.ttcn +Makefile +MobileL3_CC_Types.cc +MobileL3_CC_Types.hh +MobileL3_CC_Types.ttcn +MobileL3_CommonIE_Types.cc +MobileL3_CommonIE_Types.hh +MobileL3_CommonIE_Types.ttcn +MobileL3_GMM_SM_Types.cc +MobileL3_GMM_SM_Types.hh +MobileL3_GMM_SM_Types.ttcn +MobileL3_MM_Types.cc +MobileL3_MM_Types.hh +MobileL3_MM_Types.ttcn +MobileL3_RRM_Types.cc +MobileL3_RRM_Types.hh +MobileL3_RRM_Types.ttcn +MobileL3_SMS_Types.cc +MobileL3_SMS_Types.hh +MobileL3_SMS_Types.ttcn +MobileL3_SS_Types.cc +MobileL3_SS_Types.hh +MobileL3_SS_Types.ttcn +MobileL3_Types.cc +MobileL3_Types.hh +MobileL3_Types.ttcn +Native_FunctionDefs.cc +Native_Functions.cc +Native_Functions.hh +Native_Functions.ttcn +Osmocom_CTRL_Adapter.cc +Osmocom_CTRL_Adapter.hh +Osmocom_CTRL_Adapter.ttcn +Osmocom_CTRL_Functions.cc +Osmocom_CTRL_Functions.hh +Osmocom_CTRL_Functions.ttcn +Osmocom_CTRL_Types.cc +Osmocom_CTRL_Types.hh +Osmocom_CTRL_Types.ttcn +Osmocom_Types.cc +Osmocom_Types.hh +Osmocom_Types.ttcn +Osmocom_VTY_Functions.cc +Osmocom_VTY_Functions.hh +Osmocom_VTY_Functions.ttcn +RSL_Types.cc +RSL_Types.hh +RSL_Types.ttcn +RTP_CodecPort.cc +RTP_CodecPort.hh +RTP_CodecPort.ttcn +RTP_CodecPort_CtrlFunctDef.cc +RTP_EncDec.cc +RTP_Types.cc +RTP_Types.hh +RTP_Types.ttcn +SCCP_Emulation.cc +SCCP_Emulation.hh +SCCP_Emulation.ttcn +SCCP_EncDec.cc +SCCP_Mapping.cc +SCCP_Mapping.hh +SCCP_Mapping.ttcn +SCCP_Mapping.ttcnpp +SCCP_Types.cc +SCCP_Types.hh +SCCP_Types.ttcn +SCCPasp_Types.cc +SCCPasp_Types.hh +SCCPasp_Types.ttcn +SCTPasp_PT.cc +SCTPasp_PT.hh +SCTPasp_PortType.cc +SCTPasp_PortType.hh +SCTPasp_PortType.ttcn +SCTPasp_Types.cc +SCTPasp_Types.hh +SCTPasp_Types.ttcn +SDP_EncDec.cc +SDP_Types.cc +SDP_Types.hh +SDP_Types.ttcn +SDP_parse_.tab.c +SDP_parse_.tab.h +SDP_parse_parser.h +SDP_parser.l +SDP_parser.y +Socket_API_Definitions.cc +Socket_API_Definitions.hh +Socket_API_Definitions.ttcn +TCCConversion.cc +TCCConversion.hh +TCCConversion_Functions.cc +TCCConversion_Functions.hh +TCCConversion_Functions.ttcn +TCCInterface.cc +TCCInterface_Functions.cc +TCCInterface_Functions.hh +TCCInterface_Functions.ttcn +TCCInterface_ip.h +TELNETasp_PT.cc +TELNETasp_PT.hh +TELNETasp_PortType.cc +TELNETasp_PortType.hh +TELNETasp_PortType.ttcn +UD_PT.cc +UD_PT.hh +UD_PortType.cc +UD_PortType.hh +UD_PortType.ttcn +UD_Types.cc +UD_Types.hh +UD_Types.ttcn +lex.SDP_parse_.c +mncc.h -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Ger