[MERGED] osmocom-bb[fixeria/trx]: trxcon/sched_trx.h: clarify lchan flags meaning

2018-03-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged.

Change subject: trxcon/sched_trx.h: clarify lchan flags meaning
..


trxcon/sched_trx.h: clarify lchan flags meaning

Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
---
M src/host/trxcon/sched_trx.h
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index 856566c..78f458d 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -17,11 +17,13 @@
 #define GPRS_BURST_LEN GSM_BURST_LEN
 #define EDGE_BURST_LEN 444
 
+/* Is a channel related to PDCH (GPRS) */
 #define TRX_CH_FLAG_PDCH   (1 << 0)
+/* Should a channel be activated automatically */
 #define TRX_CH_FLAG_AUTO   (1 << 1)
-#define TRX_TS_COUNT   8
 
 #define MAX_A5_KEY_LEN (128 / 8)
+#define TRX_TS_COUNT   8
 
 /* Forward declaration to avoid mutual include */
 struct trx_lchan_state;

-- 
To view, visit https://gerrit.osmocom.org/7204
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


osmocom-bb[fixeria/trx]: trxcon/sched_trx.h: clarify lchan flags meaning

2018-03-11 Thread Harald Welte

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7204
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


[PATCH] osmocom-bb[fixeria/trx]: trxcon/sched_trx.h: clarify lchan flags meaning

2018-03-10 Thread Vadim Yanitskiy

Review at  https://gerrit.osmocom.org/7204

trxcon/sched_trx.h: clarify lchan flags meaning

Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
---
M src/host/trxcon/sched_trx.h
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/7204/1

diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/sched_trx.h
index 856566c..78f458d 100644
--- a/src/host/trxcon/sched_trx.h
+++ b/src/host/trxcon/sched_trx.h
@@ -17,11 +17,13 @@
 #define GPRS_BURST_LEN GSM_BURST_LEN
 #define EDGE_BURST_LEN 444
 
+/* Is a channel related to PDCH (GPRS) */
 #define TRX_CH_FLAG_PDCH   (1 << 0)
+/* Should a channel be activated automatically */
 #define TRX_CH_FLAG_AUTO   (1 << 1)
-#define TRX_TS_COUNT   8
 
 #define MAX_A5_KEY_LEN (128 / 8)
+#define TRX_TS_COUNT   8
 
 /* Forward declaration to avoid mutual include */
 struct trx_lchan_state;

-- 
To view, visit https://gerrit.osmocom.org/7204
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: fixeria/trx
Gerrit-Owner: Vadim Yanitskiy