[MERGED] osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Harald Welte has submitted this change and it was merged. Change subject: transceiver: Fix RSP SETSLOT format .. transceiver: Fix RSP SETSLOT format According to osmo-trx README: SETSLOT sets the format of the uplink timeslots in the ARFCN. The indicates the timeslot of interest. The indicates the type of channel that occupies the timeslot. A chantype of zero indicates the timeslot is off. CMD SETSLOT RSP SETSLOT Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Related: OS#2944 --- M src/host/layer23/src/transceiver/trx.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vadim Yanitskiy: Looks good to me, but someone else must approve; Verified Harald Welte: Looks good to me, approved diff --git a/src/host/layer23/src/transceiver/trx.c b/src/host/layer23/src/transceiver/trx.c index 8432dca..3f51928 100644 --- a/src/host/layer23/src/transceiver/trx.c +++ b/src/host/layer23/src/transceiver/trx.c @@ -340,7 +340,7 @@ if (trx->l1l[tn]) l1ctl_tx_bts_mode(trx->l1l[tn], 1, trx->type, trx->bsic, trx->arfcn, trx->gain, trx->l1l[tn]->tx_mask, trx->l1l[tn]->rx_mask, trx->handover); - return _trx_ctrl_send_resp(trx, cmd, "%d %d", 0, type); + return _trx_ctrl_send_resp(trx, cmd, "%d %d %d", 0, tn, type); } static int -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: > Would it make sense to try to port this to master? No idea, but probably unrelated to the fix/patch. If the answer is yes, then somebody can create an issue in redmine about it. -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: Would it make sense to try to port this to master? -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: Jenkins Builder failed because it's an old branch which has no jenkins.sh script, but the this trx feature doesn't seem to be available in master yet. roox, can you test it with your env and Verify+1 it? -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: roox Gerrit-HasComments: No
osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: roox Gerrit-HasComments: No
[PATCH] osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format
Review at https://gerrit.osmocom.org/6449 transceiver: Fix RSP SETSLOT format According to osmo-trx README: SETSLOT sets the format of the uplink timeslots in the ARFCN. The indicates the timeslot of interest. The indicates the type of channel that occupies the timeslot. A chantype of zero indicates the timeslot is off. CMD SETSLOT RSP SETSLOT Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Related: OS#2944 --- M src/host/layer23/src/transceiver/trx.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/49/6449/1 diff --git a/src/host/layer23/src/transceiver/trx.c b/src/host/layer23/src/transceiver/trx.c index 8432dca..3f51928 100644 --- a/src/host/layer23/src/transceiver/trx.c +++ b/src/host/layer23/src/transceiver/trx.c @@ -340,7 +340,7 @@ if (trx->l1l[tn]) l1ctl_tx_bts_mode(trx->l1l[tn], 1, trx->type, trx->bsic, trx->arfcn, trx->gain, trx->l1l[tn]->tx_mask, trx->l1l[tn]->rx_mask, trx->handover); - return _trx_ctrl_send_resp(trx, cmd, "%d %d", 0, type); + return _trx_ctrl_send_resp(trx, cmd, "%d %d %d", 0, tn, type); } static int -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: jolly/testing Gerrit-Owner: Pau Espin Pedrol
