Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Andy Waddington
Sometime before sending, Shevek typed (and on Friday 2011-04-01 sent): but this line is changing it to m4a: $prog-{ext} = 'm4a' if $prog-{ext} = 'aac'; why? I don't do perl, but with most languages, a test should be == rather than =. Is that the case here ? In which case the test will be

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Shevek
On 1 April 2011 08:44, Andy Waddington and...@pennine.demon.co.uk wrote: Sometime before sending, Shevek typed (and on Friday 2011-04-01 sent): but this line is changing it to m4a: $prog-{ext} = 'm4a' if $prog-{ext} = 'aac'; why? I don't do perl, but with most languages, a test should be

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Jimmy Aitken
String comparisons should use 'eq' and not '==' Jimmy On 1 Apr 2011, at 08:48, Shevek wrote: On 1 April 2011 08:44, Andy Waddington and...@pennine.demon.co.uk wrote: Sometime before sending, Shevek typed (and on Friday 2011-04-01 sent): but this line is changing it to m4a: $prog-{ext} =

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-04-01 Thread richard
On Thu, 31 Mar 2011 21:44:23 Shevek wrote: For those of you who want to try this before it gets applied to the repo I have shared the full script here: http://dl.dropbox.com/u/14628647/get_iplayer.pl This does not work for my Marantz player. I still think the problem with ffmpeg has not

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Shevek
On 31 March 2011 21:40, Shevek she...@shevek.co.uk wrote: A new patch - this one supersedes my previous patch and should be Jimmy Aitken is trying to post but his message is being rejected, he has found a problem with this patch. Unfortunately this solution is no good either because of the

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Roger Burton West
On Fri, Apr 01, 2011 at 11:01:02AM +0100, Shevek wrote: because of the change from array to string passed to System() and Open3() any programmes with characters such as in the title won't download As I feared might be a problem... It looks like it will have to be a 2 calls to ffmpeg - I'll take

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread dinkypumpkin
On 1 Apr 2011, at 09:13, Shevek wrote: dinkypumpkin - this affects your fork too Thanks - I didn't catch that error. Will remember to test with video next time. I've rolled back my github repo until this is sorted out. ___ get_iplayer mailing

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread dinkypumpkin
On 1 Apr 2011, at 11:11, Roger Burton West wrote: I don't have scope to test this in place, but broadly speaking I would expect you could get away with something like this. Set up @cmd1 and @cmd2 to be the first and second system() calls, then: my $buffersize=1024*4096;

Re: [PATCH] Output AAC as M4A with metadata tags

2011-04-01 Thread Shevek
On 1 April 2011 11:54, dinkypumpkin dinkypump...@gmail.com wrote: On 1 Apr 2011, at 11:11, Roger Burton West wrote: I don't have scope to test this in place, but broadly speaking I would expect you could get away with something like this. Set up @cmd1 and @cmd2 to be the first and second

Re: bit of a newbie but...

2011-04-01 Thread Chris Marriott
Hi Paul, Are you saying that Radio 4 Extra programmes won't be available on the iPlayer? Bit of a pain, if that's true! Cheers, Chris -Original Message- From: Paul Sent: Friday, April 01, 2011 11:10 AM To: get_iplayer@lists.infradead.org Subject: bit of a newbie but... been using

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-04-01 Thread bat guano
This does not work for my Marantz player. I still think the problem with ffmpeg has not been completely solved:- @ Richard In the ffmpeg git commit, it says:- In ipod/mov/mp4 muxer, always write esds descriptor length using 4 bytes, ipod shuffle

Re: bit of a newbie but...

2011-04-01 Thread Jon Davies
On 1 April 2011 11:10, Paul paul.le...@gmail.com wrote: been using get_iplayer for a few weeks and just realised that the BBCs change from Radio 7 to Radio 4 Extra looks like you can't use get_iplayer to get this new material Am I right? As I understand it the channel names are hard-coded in

AAC-M4A/MP3 patches at github - one more time

2011-04-01 Thread dinkypumpkin
For anyone keeping score, I've reposted patched code at github for anyone who wishes to test AAC-M4A or AAC-MP3 conversion. I'm now tracking Shevek's code in its own branch: https://github.com/dinkypumpkin/get_iplayer/blob/aactom4a-shevek/get_iplayer This branch contains Shevek's FIRST patch

3rd go at M4A

2011-04-01 Thread Shevek
Right, before I submit another patch it would be good to get some testing done on this: http://dl.dropbox.com/u/14628647/get_iplayer.pl This is basically my first patch (run through ffmpeg a second time for aac-m4a) but with better variable handling Let me know if this works in all the test

RE: 3rd go at M4A

2011-04-01 Thread bat guano
This is basically my first patch (run through ffmpeg a second time for aac-m4a) but with better variable handling Let me know if this works in all the test scenarios everyone has and if so I'll submit the patch @ Shevek I tested your '3rd go at

Re: 3rd go at M4A

2011-04-01 Thread Shevek
On 1 April 2011 16:21, bat guano batguano...@hotmail.com wrote: This is basically my first patch (run through ffmpeg a second time for aac-m4a) but with better variable handling Let me know if this works in all the test scenarios everyone has and

3rd go at M4A

2011-04-01 Thread richard
On 1 Apr 2011 15:03:15 Shevek wrote: Right, before I submit another patch it would be good to get some testing done on this: http://dl.dropbox.com/u/14628647/get_iplayer.pl Tested with Bell on Sunday, Radio 4. Download looked OK, but the m4a file will not play on my Marantz. EasyTag shows

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-04-01 Thread richard
On 1 Apr 2011 14:40:10 Jon Davies wrote: I would be interested to know if an ffmpeg-generated m4a with all (well, most of) the metadata stripped out works or not, it might help narrow down what's breaking things - try AtomicParsley file.m4a --metaEnema I'm no coder. Using bat guano's

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-04-01 Thread richard
On 1 Apr 2011 14:40 Jon Davies: I would be interested to know if an ffmpeg-generated m4a with all (well, most of) the metadata stripped out works or not, it might help narrow down what's breaking things - try AtomicParsley file.m4a --metaEnema The m4a file did not play in the Marantz CD

Re: bit of a newbie but...

2011-04-01 Thread James Cook
On Fri, 1 Apr 2011 14:04:32 +0100, you wrote: On 1 April 2011 11:10, Paul paul.le...@gmail.com wrote: been using get_iplayer for a few weeks and just realised that the BBCs change from Radio 7 to Radio 4 Extra looks like you can't use get_iplayer to get this new material Am I right? As I

Re: Possible [PATCH] Add BBC Radio 4 Extra (was: Re: bit of a newbie but...)

2011-04-01 Thread Jon Davies
On 1 April 2011 22:55, Jon Davies j...@hedgerows.org.uk wrote: 've attached a patch which doesn't crash get_iplayer, but I can't really test it until 4 extra content starts appearing on iplayer, which won't be until at least tomorrow.  Adn the live streaming bit is a guess at what the URL will

How to Apply the Patch to Add BBC Radio 4 Extra?

2011-04-01 Thread Jeremy Bartle
Couple of quick questions for the non-technical among us! Is this as simple as editing get_player.pl and adding the new lines? Can I do this in Wordpad or do I have to download a special editor? All help much appreciated. ___ get_iplayer mailing list