Re: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread Shevek
On 30 March 2011 20:07, geoff.getiplayer_l...@alphaworks.co.uk wrote: On 25/03/2011 01:36, Shevek wrote: re-sending previous patch email as text attachment in case gmail mungs the line endings Could we have a beginners' guide on how to take all this great work and get it running? At the

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread Shevek
On 30 March 2011 23:34, bat guano batguano...@hotmail.com wrote: Hi The patch has been committed to FFmpeg git. Information is here:- http://git.videolan.org/?p=ffmpeg.git;a=commit;h=93dfda88968c5e4d3f596f35a446fb7c238e96b2 I've compiled FFmpeg again, everything's hunkydory. Great! I'll

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread Vangelis forthnet
On Thu Mar 31 03:09:15 EDT 2011 Shevek she...@shevek.co.uk wrote: On 30 March 2011 23:34, bat guano batguano...@hotmail.com wrote: Hi The patch has been committed to FFmpeg git. Great! I'll wait for a build to hit mplayer-win32 [1] and then I'll have a play with my previous change

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread Shevek
On 31 March 2011 09:14, Vangelis forthnet northmed...@the.forthnet.gr wrote: The FFmpeg patch was committed on Mar 30th...You can also find daily Win x86 builds from the git repo here, courtesy of bizzeh: http://www.bizzeh.com/ffmpeg/free/static/ If you end up with a fully working patched

M4A / AAC changes

2011-03-31 Thread Shevek
All, Quick question on how to handle the AAC / M4A issue Should M4A be the default container for AAC audio or should it default to raw AAC and only use M4A if a new --m4a switch is set? Cheers Shevek ___ get_iplayer mailing list

Re: M4A / AAC changes

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 13:01, Shevek wrote: All, Quick question on how to handle the AAC / M4A issue Should M4A be the default container for AAC audio or should it default to raw AAC and only use M4A if a new --m4a switch is set? +1 for M4A as the default. Although they work in VLC,

RE: M4A / AAC changes

2011-03-31 Thread bat guano
Date: Thu, 31 Mar 2011 13:01:25 +0100 Subject: M4A / AAC changes From: she...@shevek.co.uk To: get_iplayer@lists.infradead.org All, Quick question on how to handle the AAC / M4A issue Should M4A be the default container for AAC audio or should

Re: M4A / AAC changes

2011-03-31 Thread FJuniper
Apologies for not wading through the dozens of posts - will an mp3 option be added too? I like to play these files using the SD card reader built into my car, and fear that only mp3 is compatible. Thanks. Nick Ludlam wrote: On 31 Mar 2011, at 13:08, dinkypumpkin wrote: For my github fork,

Re: M4A / AAC changes

2011-03-31 Thread Shevek
The existing mp3 from flashaudio functionality will not be changed this is changing the output from flashaac modes On 31 March 2011 14:35, FJuniper fjuni...@gmail.com wrote: Apologies for not wading through the dozens of posts - will an mp3 option be added too? I like to play these files using

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. I am also finding the new version of ffmpeg doesn't work with iTunes - it reports an incorrect

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 14:55, Nick Ludlam n...@recoil.org wrote: On 31 Mar 2011, at 14:43, Shevek wrote: On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Jon Davies
On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. ...snip We seem to have established that ffmpeg isn't generating entirely valid mpeg4 files, I

Re: M4A / AAC changes

2011-03-31 Thread Shevek
On 31 March 2011 15:39, FJuniper fjuni...@gmail.com wrote: That sounds good - I am already using your .pl, so I will look out for your new one.  Thanks. Changing the subject slightly - I installed get_iplayer_setup_4.2.exe from http://www.infradead.org/get_iplayer_win/ I also have an idea

Re: M4A / AAC changes

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 15:39, FJuniper wrote: Changing the subject slightly - I installed get_iplayer_setup_4.2.exe from http://www.infradead.org/get_iplayer_win/ I also have an idea that this is all based on v2.79 of something (this naming convention confuses me!). Is there ever likely to

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 15:34, Jon Davies j...@hedgerows.org.uk wrote: On 31 March 2011 14:35, richard rich...@richsim900.plus.com wrote: Sorry to spoil things, but the patch to ffmpeg has not solved the problem with my Marantz CD6003. These are the tests I've done. ...snip We seem to have

Re: M4A / AAC changes

2011-03-31 Thread FJuniper
Shevek wrote: 2.79 is the version of get_iplayer itself when this is updated you don't need to reinstall using the windows setup, you can run get_iplayer --update OK, thanks. So does --update get a new .pl and any newer versions of FFMPEG and the other components? Actually I just took a

Re: M4A / AAC changes

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 16:07, FJuniper wrote: OK, thanks. So does --update get a new .pl and any newer versions of FFMPEG and the other components? Actually I just took a look at http://linuxcentre.net/getiplayer/documentation#Updating%20get_iplayer and --update seems to be for Linux etc -

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 16:01, Shevek wrote: This is possibly a stupid question, but can ffmpeg pipe to itself to do both things separately but in one command? This worked for me: ffmpeg -i test.flv -vn -acodec copy -f adts - | ffmpeg -i - -vn -acodec copy -absf aac_adtstoasc -y test.m4a I

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread bat guano
Subject: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek) From: rich...@richsim900.plus.com To: get_iplayer@lists.infradead.org Date: Thu, 31 Mar 2011 14:35:54 +0100 Sorry to spoil things, but the patch to ffmpeg has not solved the

Re: M4A / AAC changes

2011-03-31 Thread Shevek
On 31 March 2011 16:07, FJuniper fjuni...@gmail.com wrote: Shevek wrote: 2.79 is the version of get_iplayer itself when this is updated you don't need to reinstall using the windows setup, you can run get_iplayer --update OK, thanks. So does --update get a new .pl and any newer versions

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 16:21, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 16:01, Shevek wrote: This is possibly a stupid question, but can ffmpeg pipe to itself to do both things separately but in one command? This worked for me: ffmpeg -i test.flv -vn -acodec copy -f adts - |

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Roger Burton West
On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). Easiest option (though it's vulnerable to shellmetas showing up in filenames) is probably to do it all in one string: set $cmd

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:33, Roger Burton West wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). Sorry, Shevek - I should have warned you about that beforehand.

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system(). I thought it would be something like that. Thanks for the

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:36, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 20:33, Roger Burton West wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? You can't use shell functions (such as pipe) with the list-form invocation of system().

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? Easiest option (though it's vulnerable to shellmetas showing up in filenames) is probably to do it all in one string: set $cmd instead of @cmd

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Shevek
On 31 March 2011 20:49, dinkypumpkin dinkypump...@gmail.com wrote: On 31 Mar 2011, at 20:44, Shevek wrote: On 31 March 2011 20:33, Roger Burton West ro...@firedrake.org wrote: On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: What am I doing wrong? Easiest option (though it's

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread bat guano
OK, this is what I came up with and it works: @cmd = ( $bin-{ffmpeg} . ' -i ' . $file_tmp . ' -vn -acodec copy -f adts - | ' . $bin-{ffmpeg} . ' -i - -vn -acodec copy -absf aac_adtstoasc -y ' . $prog-{filepart} . '', ); does anyone have any

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:52, Shevek wrote: On 31 March 2011 20:49, dinkypumpkin dinkypump...@gmail.com wrote: Path to ffmpeg exe might have spaces, so should be quoted as well. good spot... it's odd, because up till now none of the paths have been quoted, but it has always worked,

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread Roger Burton West
On Thu, Mar 31, 2011 at 08:56:59PM +0100, dinkypumpkin wrote: Yes. Perl pros here should correct me, but I think now that you effectively passing a list of length = 1 to system() or open3 (under the hood of main::run_cmd), you need to handle all internal quoting yourself. Yes. The array form

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 20:54, bat guano wrote: OK, this is what I came up with and it works: @cmd = ( $bin-{ffmpeg} . ' -i ' . $file_tmp . ' -vn -acodec copy -f adts - | ' . $bin-{ffmpeg} . ' -i - -vn -acodec copy -absf aac_adtstoasc -y ' . $prog-{filepart} . '', ); does anyone have any

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread geoff . getiplayer_list
On 31/03/2011 08:06, Shevek wrote: On 30 March 2011 20:07,geoff.getiplayer_l...@alphaworks.co.uk wrote: On 25/03/2011 01:36, Shevek wrote: re-sending previous patch email as text attachment in case gmail mungs the line endings Could we have a beginners' guide on how to take all this great

Re: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread Shevek
On 31 March 2011 21:12, geoff.getiplayer_l...@alphaworks.co.uk wrote: On 31/03/2011 08:06, Shevek wrote: On 30 March 2011 20:07,geoff.getiplayer_l...@alphaworks.co.uk  wrote: On 25/03/2011 01:36, Shevek wrote: re-sending previous patch email as text attachment in case gmail mungs the line

[PATCH] Output AAC as M4A with metadata tags

2011-03-31 Thread Shevek
A new patch - this one supersedes my previous patch and should be applied to current head in repository. (http://git.infradead.org/get_iplayer.git/commit/2e6ddc177605244746fb749524f639fe22cf2556) please ignore my previous patch

Broken list threads

2011-03-31 Thread Shevek
Anyone have any idea why emails from a couple of people [Richard (richard at richsim900.plus.com) and Vangelis (northmedia1 at the.forthnet.gr)] break the threading? ___ get_iplayer mailing list get_iplayer@lists.infradead.org

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread richard
bat guano wrote: @ Richard Using your new version of FFmpeg... When you convert other mp3 files to m4a using command:- ffmpeg filename -acodec libfaac output.m4a Do they now play in your Marantz straight off, or do you still need to use EasyTAG? No they do not play, but no 'header error'

RE: [PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread bat guano
No they do not play, but no 'header error' or 'time out' error. They play OK (with no delay) if I use EasyTag and change a tag. OK Well the FFmpeg update fixed it for the Shuffle. The m4a files play straight off without needing EasyTAG any more.

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread richard
On 31 Mar 2011 15:34:12, Jon Davies wrote: I don't have an ipod and itunes to hand, but for a test file I do have here mp4info reports different things. note the kbps in the audio track... ?it suggests (as I think we're establishing) that ffmpeg mangles the metadata atoms in a way that makes

[PATCH] Output AAC as M4A for iTunes with metadata tags

2011-03-31 Thread richard
bat guano wrote: Try using a command like this:- ffmpeg -i Bells_on_Sunday_-_27_03_2011_b00zq9t8_default.flv -acodec copy -f adts - | ffmpeg -i - -acodec copy -absf aac_adtstoasc Bells-on-Sunday.m4a AtomicParsley Bells-on-Sunday.m4a --artist BBC Radio 4 --title Bells on Sunday

Re: [PATCH] Output AAC as M4A with metadata tags

2011-03-31 Thread dinkypumpkin
On 31 Mar 2011, at 21:40, Shevek wrote: A new patch - this one supersedes my previous patch and should be applied to current head in repository. (http://git.infradead.org/get_iplayer.git/commit/2e6ddc177605244746fb749524f639fe22cf2556) please ignore my previous patch