Re: [PATCH] Re: atomicparsley tagging issue
On 3 April 2011 00:12, Jimmy Aitken jimmy.ait...@gmail.com wrote: I've actually patched my get_iplayer to use eyeD3. On 3 April 2011 11:45, Shevek she...@shevek.co.uk wrote: I personally would prefer not to add any further dependencies to get_iplayer. Nor would I. I'd prefer to move towards fewer dependencies, and perhaps consider adopting a perl-native tagging library. Looks like tagging is going to end up as a long conversation too... Jon ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On Sun, Apr 03, 2011 at 02:39:04PM +0100, Jon Davies wrote: Nor would I. I'd prefer to move towards fewer dependencies, and perhaps consider adopting a perl-native tagging library. What I'd like to see - and I think this would be a big enough change that this is really more of a suggestion for the download client that gets written for the successor to iPlayer - is a conventionally Unix-like nest of programs that each do one thing, but talk to each other; they could then be connected by a (textual, GUI or web-based) interface. These one things might be, for example: searching the programme listings for specific titles/etc.; taking a single programme ID and converting it to be something to be fed into getrtsp; remuxing and/or transcoding the output from getrtsp; tagging. R ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On 03/04/2011 09:06, James Cook wrote: A configuration mechanism is a good idea, but I think it will have be based a full mapping of get_iplayer fields - MP3 frames - MP4 atoms. I've done this for iTunes, and it's pretty straightforward. I don't think id3v2 can add artwork, but that seems acceptable unless someone knows of another cross-platform ID3v2 command-line tagger that can insert APIC frames. It seems everyone has their own solution, id3v2 is very outdated and you can't set APIC as you say, as well as ... TDRL for example - so I doubt if anyone is really using it (?). It's certainly a dead end, though it works well enough for people like my Windows-user colleagues who just want to download The Archers omnibus and pop it into WMP. There are better libraries out there, but I can't say I have much ambition to concoct a command-line media tagger in C++. Actually its the underlying id3lib which is outdated. I have tweaked these two to get some simple tags (TDRL) working but not for complex tags. I sympathise. The lack of support for useful (according to me) frames finally drove me to eyeD3 and then on to Mutagen. As an iTunes user, I've found it pretty beneficial to have better tagging control, e.g., for managing downloads as podcasts. The alternative would be come up with some sort of integrated tagging plugin, but I'm not sure it's worth the bother. I've been using mutagen, so I don't know whether the available perl modules are even up to the task. In the end I use a small perl lib I wrote which uses MP3:Tag. It can set all the tags I need, including APICs etc. That's good to know. I've done a little bit of poking around in the perl MP4 tagging libs, and it seems like most of the bits one would need are there as well, but I haven't put them through their paces. Not quite as tidy as Mutagen, but we are living in a perl world here. ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On 2 April 2011 09:02, Jimmy Aitken jimmy.ait...@gmail.com wrote: There is a version of AtomicParsley which tags the 'longDescription' field. I have a modified version of AtomicParsley which allows this and have a small patch which allows this tag to be added if the version supports it. Here's the patch to allow it. Line numbers may vary due to the other patches I've added recently. This work on tagging is fantastic. Please take into account my patch for m4a audio as this affects tagging too - it correctly tags m4a using atomic parsley and puts this metadata in different places that an mp4 video. ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On Sat, 2 Apr 2011 09:08:22 +0100, you wrote:
Please take into account my patch for m4a audio as this affects
tagging too - it correctly tags m4a using atomic parsley and puts this
metadata in different places that an mp4 video.
I noticed that. I have a quick hack with just tags m4a or m4v in the
same way - seems to work - so I wonder why e.g you take care not to
set
'--TVNetwork', $tags-{channel},
for m4a files. Just curious about that.
Also I wonder if its ever sensible to set STIK to audiobook for
(some?) radio shows? (atomicparsley forces output of m4b file)
JC
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On 2 April 2011 20:06, James Cook james.c...@bluewin.ch wrote:
On Sat, 2 Apr 2011 09:08:22 +0100, you wrote:
Please take into account my patch for m4a audio as this affects
tagging too - it correctly tags m4a using atomic parsley and puts this
metadata in different places that an mp4 video.
I noticed that. I have a quick hack with just tags m4a or m4v in the
same way - seems to work - so I wonder why e.g you take care not to
set
'--TVNetwork', $tags-{channel},
for m4a files. Just curious about that.
I did think about this. at least in iTunes this info appears on the TV
Show tab of the Get Info screen so I think I decided it wasn't the
right place to put it.
Also I wonder if its ever sensible to set STIK to audiobook for
(some?) radio shows? (atomicparsley forces output of m4b file)
Again, I did think about the STIK and decided that it should be
treated as Normal for radio shows. It's a shame that there isn't a
Radio STIK!
Of course both choices were to my personal preference and others are
of course entitled to disagree :)
Perhaps some discussion here may reveal a consensus.
___
get_iplayer mailing list
get_iplayer@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
On 2 Apr 2011, at 20:00, James Cook wrote: On Sat, 2 Apr 2011 16:38:53 +0100, you wrote: According to the docs AtomicParsley is clever about tagging so tagging an mp4 file with USLT shoud result in --lyrics being set. So you could just configure the id3v2 tag names and they'll be applied to whatever output file you create. No need to double configure for mp3 and m4*. I don't think it works quite like that. AtomicParsley puts the ID3 frames inside ID32 atoms in the MP4 tree. iTunes ignores them - are there other media managers/players that can read those frames? More esoteric is the fact that atomicparsley apparently only writes ID3v2.4 frames. I would guess that any app that could read ID3 frames from MP4 trees would also do ID3v2.4, but I have no real clue. A configuration mechanism is a good idea, but I think it will have be based a full mapping of get_iplayer fields - MP3 frames - MP4 atoms. I've done this for iTunes, and it's pretty straightforward. I don't think id3v2 can add artwork, but that seems acceptable unless someone knows of another cross-platform ID3v2 command-line tagger that can insert APIC frames. The alternative would be come up with some sort of integrated tagging plugin, but I'm not sure it's worth the bother. I've been using mutagen, so I don't know whether the available perl modules are even up to the task. ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
Re: [PATCH] Re: atomicparsley tagging issue
I've actually patched my get_iplayer to use eyeD3. (http://eyed3.nicfit.net/) It's a python script, so should be os agnostic, and also allows tagging of artwork as well as the standard ID3 tags. I wasn't happy with the code changes (it hard codes a test for the 'eyeD3' string into get_iplayer which seems a dreadful hack), but it worked for me. I could supply my patches if interested, and they could be integrated, however, I'm not sure how much work would be involved in supplying the python libraries etc for a standard eyeD3. Jimmy On Sat, Apr 2, 2011 at 9:01 PM, dinkypumpkin dinkypump...@gmail.com wrote: On 2 Apr 2011, at 20:00, James Cook wrote: On Sat, 2 Apr 2011 16:38:53 +0100, you wrote: According to the docs AtomicParsley is clever about tagging so tagging an mp4 file with USLT shoud result in --lyrics being set. So you could just configure the id3v2 tag names and they'll be applied to whatever output file you create. No need to double configure for mp3 and m4*. I don't think it works quite like that. AtomicParsley puts the ID3 frames inside ID32 atoms in the MP4 tree. iTunes ignores them - are there other media managers/players that can read those frames? More esoteric is the fact that atomicparsley apparently only writes ID3v2.4 frames. I would guess that any app that could read ID3 frames from MP4 trees would also do ID3v2.4, but I have no real clue. A configuration mechanism is a good idea, but I think it will have be based a full mapping of get_iplayer fields - MP3 frames - MP4 atoms. I've done this for iTunes, and it's pretty straightforward. I don't think id3v2 can add artwork, but that seems acceptable unless someone knows of another cross-platform ID3v2 command-line tagger that can insert APIC frames. The alternative would be come up with some sort of integrated tagging plugin, but I'm not sure it's worth the bother. I've been using mutagen, so I don't know whether the available perl modules are even up to the task. ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer ___ get_iplayer mailing list get_iplayer@lists.infradead.org http://lists.infradead.org/mailman/listinfo/get_iplayer
