Re: [Getfem-commits] please merge branch devel-tetsuo-xml

2020-05-10 Thread Konstantinos Poulios via Getfem-commits
The FOOTER_WRITTEN enumeration entry is not used anywhere, so it has to be removed. Is it intentional that you did not support exporting slices in the vtu format? What prevents us from exporting slices? For now, you can continue working on your current branch, and when the code is ready for

Re: [Getfem-commits] please merge branch devel-tetsuo-xml

2020-05-10 Thread Konstantinos Poulios via Getfem-commits
the other thing is the big overlapping between the vtk_export class and the new vtu_export class. Duplicating code is not a very good strategy. I think you should just keep the old vtk_export class and add an optional argument for the user to choose if exporting to xml format or not. Best regards

Re: [Getfem-commits] please merge branch devel-tetsuo-xml

2020-05-10 Thread Konstantinos Poulios via Getfem-commits
by the way, the "remove_dof_unused" function you should make it work in-place on the passed by reference V vector, as was the code that you replaced with this function. The line gmm::copy(remove_dof_unused(V, pmf_dof_used, Q), W) and the temporary W vector are completely unnecessary, and just add

Re: [Getfem-commits] please merge branch devel-tetsuo-xml

2020-05-10 Thread Konstantinos Poulios via Getfem-commits
Dear Tetsuo, Thanks for your answer. Your code looks quite nice actually. I have one question about the lines std::vector W(Q*pmf_dof_used.card()); gmm::copy(remove_dof_unused(V, pmf_dof_used, Q), W); write_dataset_(V, name, qdim); Since you do not do anything with vector W,