Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Jan Stolarek
I fully support Austin's proposal. My eyes hurt when I work on 5 files and each of them is written in a different style. Now, to address a few points that were raised. Is it just for the sake of beauty (not to diminish the importance of beauty)? * I believe that trailing whitespaces are a

Re: GenericsPropositionalEquality [Was: Resolved+new Q: TypeLits question, how to build a Type Application with Symbol index]

2014-07-03 Thread José Pedro Magalhães
Gabor and all, Below you'll find my encoding of GHC.Generics with DataKinds. The most important part, for this discussion, is the treatment of meta-information. I don't think we need |sameDatatype|, in particular; why not just use |sameSymbol|? Cheers, Pedro {-# LANGUAGE TypeFamilies

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Joachim Breitner
Hi, Am Donnerstag, den 03.07.2014, 10:44 +0200 schrieb Jan Stolarek: Now, I understand people who don't want such change because of merge conflicts. But the truth is there will never be a good moment to implement such changes because there is always some ongoing work and outstanding

Re: GHCJS now runs Template Haskell on node.js - Any interest in out of process TH for general cross compilation?

2014-07-03 Thread CJ van den Berg
Yes! This would definitely be of great interest to users of the Android cross compilers. It should be quite feasible to drive a TH runner process on a development device or emulator. Having genuine TH support would be a huge improvement to the usefulness of GHC in a cross compiling scenario. I

Re: No entry for Haskell CPP command error with testsuite

2014-07-03 Thread Adam Sandberg Ericsson
The error is probably related to: https://phabricator.haskell.org/D26 Adam Sandberg Ericsson On Thu, Jul 3, 2014 at 8:44 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: I'm trying to run the testsuite in my symlinked build tree, but keep getting this error: [killy@xerxes :

Re: Fwd: GHCJS now runs Template Haskell on node.js - Any interest in out of process TH for general cross compilation?

2014-07-03 Thread CJ van den Berg
That is great! Please send your patches to me. I would love to update ghc-android to support 7.8. A pull request on github would be ideal, but plain patches are ok too. On 2014-07-03 05:18, member MP2E wrote: 1. Cross GHC 7.8 using the Stage1 TH patch and a few other patches available from

Re: GHCJS now runs Template Haskell on node.js - Any interest in out of process TH for general cross compilation?

2014-07-03 Thread Luite Stegeman
I think GHC could use more or less the same communication method as GHCJS now does: Start some user-specifiied process and send messages through pipes (GHCJS uses stdin/stderr of the node process), with the difference that it would get dynamic libraries for the target rather than blobs of JS code.

Re: No entry for Haskell CPP command error with testsuite

2014-07-03 Thread Carter Schonwald
Did you do a make maintainer-clean ; perl boot ; ./configure After you pulled the new changes? It patched the build system so you have to do the above. Can't reuse a previous build On Thursday, July 3, 2014, Jan Stolarek jan.stola...@p.lodz.pl wrote: I'm trying to run the testsuite in my

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/07/14 11:13, Joachim Breitner wrote: So my conclusion is that it?s ok to have the mess in the source code forever. I mostly agree. The only way to handle this that I can presently identify is to agree on some guidelines, put them up on the

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Jan Stolarek
And if you are changing 90% of a file for some reason, it probably doesn't hurt to detab it as well, etc. I think the reason we still have tabs in the source code is that people usually don't change 90% of a file, but 5% or something like that and they feel this is not enough to justify

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/07/14 17:38, Jan Stolarek wrote: I think the reason we still have tabs in the source code is that people usually don't change 90% of a file, but 5% or something like that and they feel this is not enough to justify detabing of a whole

Re: No entry for Haskell CPP command error with testsuite

2014-07-03 Thread Jan Stolarek
Did you do a make maintainer-clean ; perl boot ; ./configure After you pulled the new changes? It patched the build system so you have to do the above. Can't reuse a previous build I guess that was it. Did a clean build and all is fine. Janek ___

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Andrew Farmer
On Thu, Jul 3, 2014 at 4:13 AM, Joachim Breitner m...@joachim-breitner.de wrote: On the other hand, having a “detab and rename” horizon where merging patches from before is much harder, and where git log -L and git blame fail to work properly would be a hindrance. Minor point, but you can

RE: GHCJS now runs Template Haskell on node.js - Any interest in out of process TH for general cross compilation?

2014-07-03 Thread Simon Peyton Jones
Luite I lack the bandwidth to respond at any technical depth, but I’d like to make encouraging noises. If you can figure out a way to make GHC do these things without making the compiler terribly complicated and making maintaining it harder, then I’m open to your proposals. Several people

Re: No entry for Haskell CPP command error with testsuite

2014-07-03 Thread Carter Schonwald
yay! :) (i spent quite a bit of time working on that patch, so you scared me initially) On Thu, Jul 3, 2014 at 11:39 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: Did you do a make maintainer-clean ; perl boot ; ./configure After you pulled the new changes? It patched the build system so

Re: No entry for Haskell CPP command error with testsuite

2014-07-03 Thread Edward Z . Yang
I wonder if we should have some magic variable in the build system that induces a full rebuild, so if you push a patch which requires a rebuild you can bump the variable and let it know. Edward Excerpts from Carter Schonwald's message of 2014-07-03 17:20:44 +0100: yay! :) (i spent quite a bit

RE: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Simon Peyton Jones
Just to say that * In general I don't have a strong opinion about these stylistic issues. Moreover I have little bikeshed time, and if I don't contribute to a debate I can't expect to influence it much. So I'm mostly happy to accept a consensus view. However, some thoughts * I don't

Re: RFC: style cleanup guidelines for GHC, and related bikeshedding

2014-07-03 Thread Johan Tibell
On Thu, Jul 3, 2014 at 6:29 PM, Simon Peyton Jones simo...@microsoft.com wrote: * Insisting on line comments exclusively, carries a cost. The on-screen distraction of line comments, and the nuisance of writing them, is not trivial. Perhaps it is bearable, but it's non-zero. See

Re: [commit: ghc] master: Re-add more primops for atomic ops on byte arrays (4ee4ab0)

2014-07-03 Thread Páli Gábor János
Hello Johan, 2014-06-30 22:13 GMT+02:00 g...@git.haskell.org: commit 4ee4ab01c1d97845aecb7707ad2f9a80933e7a49 Author: Johan Tibell johan.tib...@gmail.com Date: Fri Jun 27 13:48:24 2014 +0200 Re-add more primops for atomic ops on byte arrays It seems this change breaks the build on

Re: GHCJS now runs Template Haskell on node.js - Any interest in out of process TH for general cross compilation?

2014-07-03 Thread John Meacham
In case anyone wanted to start writing haskell android code now, jhc fully supports android as a target. here is an app made with it https://play.google.com/store/apps/details?id=org.metasepi.ajhc.android.cube this was made with Kiwamu's ajhc branch but code has been merged back into the main

Head's up, yall: Cabal's dir layout changed

2014-07-03 Thread Mark Lentczner
I just noticed that the default directory layout that cabal uses (under .cabal) has changed between 1.16 and 1.18. In particular: In 1.16 -- libsubdir: $pkgid/$compiler -- datasubdir: $pkgid -- docdir: $datadir/doc/$pkgid in 1.18 -- libsubdir: $arch-$os-$compiler/$pkgid -- datasubdir:

Re: Head's up, yall: Cabal's dir layout changed

2014-07-03 Thread Carter Schonwald
I'll admit i've pushed a lot of haskell platform users to migrate to 1.20 style ~/.cabal/config's for a while :) On Thu, Jul 3, 2014 at 6:35 PM, Mark Lentczner mark.lentcz...@gmail.com wrote: I just noticed that the default directory layout that cabal uses (under .cabal) has changed between