diff'ing in Diffusion

2014-08-11 Thread Richard Eisenberg
Hi all, I wanted to see a side-by-side diff of the GHC code between 7.8.2 and 7.8.3. So, I went to Phab's Diffusion application. I can access the different commits I wish to compare, but I can't seem to find a "Compare" or "Diff" button. Any hints? Thanks! Richard _

Re: CPP usage in GHC.

2014-08-11 Thread Carter Schonwald
Oo. Then it's possibly debris leftover from Austin's initial clang compatibility work predating the improvements via the settings file work. I'm Afk right now, but that probably can be safely removed from ghc, especially since the configure script for clang cpp adds that anyways now I think?

Re: CPP usage in GHC.

2014-08-11 Thread Karel Gardas
On 08/11/14 11:18 PM, Carter Schonwald wrote: why should this flag be passed to cpp when invoked on HS files? It'd be easy to expose another field in the settings file for this other invokecation.. though i should look more closely at the use site before opinining :) Hmm, isn't doCpp function w

Re: CPP usage in GHC.

2014-08-11 Thread Carter Schonwald
why should this flag be passed to cpp when invoked on HS files? It'd be easy to expose another field in the settings file for this other invokecation.. though i should look more closely at the use site before opinining :) On Mon, Aug 11, 2014 at 4:27 PM, Karel Gardas wrote: > On 08/11/14 08:48

Re: CPP usage in GHC.

2014-08-11 Thread Karel Gardas
On 08/11/14 08:48 PM, Carter Schonwald wrote: What i'm hearing you say is we actually need TWO sets of CPP flags, one for normal haskell, and another for the CPP used on the assembler? wheres this hardcoding? DriverPipeline.hs -- grep for "assembler-with-cpp" and you will find it. IMHO best wo

Re: CPP usage in GHC.

2014-08-11 Thread Carter Schonwald
What i'm hearing you say is we actually need TWO sets of CPP flags, one for normal haskell, and another for the CPP used on the assembler? wheres this hardcoding? ___ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-d

Re: CPP usage in GHC.

2014-08-11 Thread Karel Gardas
On 08/11/14 02:32 PM, Karel Gardas wrote: Hmm, seeing CPPHS give me an idea about either - prioritizing CPPHS usage, when configure detects CPPHS availability it is then set as with --with-hs-cpp option and used as a preprocessor https://phabricator.haskell.org/D142 -- implements this option

Re: CPP usage in GHC.

2014-08-11 Thread Karel Gardas
On 08/11/14 01:27 AM, Carter Schonwald wrote: I could be wrong, but I think assembler-with-cpp came up only as part of certain clang work arounds, it should suffice to use any GCC like traditional mode CPP (like the CPPHS tool). This is interesting, but it looks like -x assembler-with-cpp is