RE: Typechecker tests failures

2014-12-12 Thread Simon Peyton Jones
Thanks. This was being tracked in Trac #9567, and I have finally gotten around to fixing it. Your proposed change is small, but it simply avoids the crash without fixing the cause. The cause was that contInputType was simply *wrong*. https://ghc.haskell.org/trac/ghc/ticket/9567 Fixed now!

Typechecker plugins and 7.10

2014-12-12 Thread Adam Gundry
Hi Austin, devs, I'm not sure what stage the 7.10 branch split and RC have got to, but if possible I'd like to get Phab:D553 included (my special pleading is that it makes relatively small, self-contained changes that will make it slightly harder to shoot oneself in the foot when writing a

Re: Please test: release candidates for Cabal/cabal-install patch releases on the 1.18 and 1.20 branches

2014-12-12 Thread Johan Tibell
Ben, Is this something that worked in cabal-install 1.18.0.5 and that stopped working in 1.18.0.6 or is it something that didn't work in 1.18.0.5 but you expected to be fixed in 1.18.0.6? These 1.18 and 1.20 releases just target a very few critical bugs. They are not attempts to backport all

Re: Serialising evidence generated by typechecker plugins

2014-12-12 Thread Richard Eisenberg
On Dec 12, 2014, at 3:30 AM, Adam Gundry a...@well-typed.com wrote: I did vaguely wonder about doing something like this, but was worried about the complexity. Since you all seem keen, though, I'll have a go and see if I can make it work. I'd imagine using the (plugin module name, axiom

Re: Typechecker plugins and 7.10

2014-12-12 Thread Richard Eisenberg
As I'm referenced here, I'll speak up: yes, I think we should advertise that the plugin interface is purely a technology preview, and very subject to change. I'm sure that as users adopt this powerful new feature, they and we will discover ways that it could be improved, or perhaps ways that it

Re: Please test: release candidates for Cabal/cabal-install patch releases on the 1.18 and 1.20 branches

2014-12-12 Thread Ben Gamari
Johan Tibell johan.tib...@gmail.com writes: Ben, Is this something that worked in cabal-install 1.18.0.5 and that stopped working in 1.18.0.6 or is it something that didn't work in 1.18.0.5 but you expected to be fixed in 1.18.0.6? These 1.18 and 1.20 releases just target a very few

D538 and compiler performance spec

2014-12-12 Thread Alan Kim Zimmerman
For API annotations I am working in the details of RdrNames, which come in a bewildering variety of syntactic forms. My latest change causes perf/compiler to fail, with bytes allocated value is too high: Expectedparsing001(normal) bytes allocated: 587079016 +/-5% Lower bound

Re: Typechecker plugins and 7.10

2014-12-12 Thread Eric Seidel
I agree, marking type-checker plugins as experimental and subject to change makes perfect sense given how little experience we have writing them at the moment. Eric Richard Eisenberg e...@cis.upenn.edu writes: As I'm referenced here, I'll speak up: yes, I think we should advertise that the

RE: D538 and compiler performance spec

2014-12-12 Thread Simon Peyton Jones
I am now adding an `AnnVal` to every RdrName, to be able to separate it out from any decoration, such as surrounding backticks or parens. That seems like overkill to me. (a `op` b) is an HsOpApp, and must of course have backticks unless op is an operator like (a + b), in which case it doesn’t.

Re: D538 and compiler performance spec

2014-12-12 Thread Alan Kim Zimmerman
The problem is round-tripping cases like this, which are valid ( /// ) :: Int - Int - Int a /// b = 3 baz :: Int - Int - Int a ` baz ` b = 4 There can be arbitrary spaces between the surrounding parens and the operator name, and between the backquotes and the

Re: D538 and compiler performance spec

2014-12-12 Thread Alan Kim Zimmerman
On reflection, I can try to make it work with annotations just for those fairly rare cases where there are parens/backquotes, and use the location span otherwise. On Fri, Dec 12, 2014 at 11:20 PM, Alan Kim Zimmerman alan.z...@gmail.com wrote: The problem is round-tripping cases like this,

performance regressions

2014-12-12 Thread Richard Eisenberg
Hi devs, Phab has shown up some performance regressions in my recent commits. See https://phabricator.haskell.org/harbormaster/build/2607/. The failures except for haddock.base are new, and evidently my fault. They didn't show up on Travis. Will look into it shortly, but I doubt over the