Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Moritz Angermann
Hi Viktor, - I believe the "test spaces" part is important and would need to be fixed, if spaces break this is not desirable. - For the Relocations part, I'm happy to offer guidance and help for anyone who wants to take a stab at it, right now I'm not in a position where I could take this on

Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Viktor Dukhovni
On Mon, Mar 15, 2021 at 06:44:20AM -0400, Viktor Dukhovni wrote: > ..., the FreeBSD "validate --legacy" > successfully builds GHC. [ The tests seem to all be failing, perhaps > the test driver scripts are not portable to FreeBSD, but previously > the compiler was not building. ] FWIW, the tests

Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Viktor Dukhovni
On Mon, Mar 15, 2021 at 09:46:35AM +0100, Sylvain Henry wrote: > > > > Thank you! Don’t forget to comment it – especially because it is fake. > > Done in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5265 Speaking of build failures with the legacy make system, I see a build failure on

Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Sylvain Henry
Thank you! Don’t forget to comment it – especially because it is fake. Done in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/5265 Make build system doesn't respect package dependencies, only module dependencies (afaik) Does Hadrian suffer from this malady too? Are the fake imports

RE: Build failure -- missing dependency? Help!

2021-03-15 Thread Simon Peyton Jones via ghc-devs
Thanks Sylvain So we should add a similar fake import into libraries/base/GHC/Exception/Type.hs-boot. I will open a MR. Thank you! Don't forget to comment it - especially because it is fake. Make build system doesn't respect package dependencies, only module dependencies (afaik) Does Hadrian

Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Sylvain Henry
Hi Simon, The issue is that: 1. Make build system doesn't respect package dependencies, only module dependencies (afaik) 2. The build system isn't aware that most modules implicitly depend on GHC.Num.Integer/Natural (to desugar Integer/Natural literals) That's why we have several fake

Re: Build failure -- missing dependency? Help!

2021-03-15 Thread Viktor Dukhovni
> On Mar 14, 2021, at 6:53 PM, Simon Peyton Jones via ghc-devs > wrote: > > I’m getting this (with ‘sh validate –legacy’). Oddly > > • It does not happen on HEAD > • It does happen on wip/T19495, a tiny patch with one innocuous change > to GHC.Tc.Gen.HsType > I can’t see how my