Re: -fghci-leak-check apparently causes many tests to fail

2018-06-07 Thread Ryan Scott
> If you're seeing errors from this, then we should fix them. Could you open a ticket and assign to me please? I've opened Trac #15246 [1] for this. Ryan S. - [1] https://ghc.haskell.org/trac/ghc/ticket/15246 On Thu, Jun 7, 2018 at 4:34 PM, Simon Marlow wrote: > Sorry, only just saw

Re: -fghci-leak-check apparently causes many tests to fail

2018-06-07 Thread Simon Marlow
Sorry, only just saw this. -fghci-leak-check is a new flag I added to prevent regressions of the space leak that was fixed in https://phabricator.haskell.org/D4659 If you're seeing errors from this, then we should fix them. Could you open a ticket and assign to me please? Cheers Simon On 1

Re: -fghci-leak-check apparently causes many tests to fail

2018-06-01 Thread Ryan Scott
One thing I forgot to mention is that these test failures only seem to occur with the `quick` build flavor, and I couldn't reproduce them with ./validate. Is -fghci-leak-check expected to have different behavior if stage-2 GHC is built without optimization? Ryan S.

Re: -fghci-leak-check apparently causes many tests to fail

2018-05-31 Thread Phyx
I don't know what -fghci-leak-check does at all, but if they are to be expected we shouldn't accept the changes. Instead change the default options in the testsuite to pass -fno-ghci-leak-check (I assume that exists) On Thu, May 31, 2018, 06:49 Ryan Scott wrote: > I recently ran the testsuite

-fghci-leak-check apparently causes many tests to fail

2018-05-31 Thread Ryan Scott
I recently ran the testsuite and experienced a very large number of testsuite failures, all of which seem to involve the new -fghci-leak-check flag. Here is the list of tests that fail: Unexpected failures: ghci/prog001/prog001.runprog001 [bad stdout] (ghci)