Re: `arc` changes my commit messages

2014-11-09 Thread Simon Marlow
A diff per commit is not that bad, this is my usual workflow. Using 'git rebase -i' and 'edit' you can amend individual commits in a stack. The workflow is * git rebase -i oldest commit in the stack * 'edit' the commit you want to modify * modify away * arc diff * git commit --continue

`arc` changes my commit messages

2014-10-21 Thread Richard Eisenberg
Hi all, Is there a way to put `arc` into a read-only mode? Frequently while working on a patch, I make several commits, preferring to separate out testing commits from productive work commits and non-productive (whitespace, comments) commits. Sometimes each of these categories are themselves

Re: `arc` changes my commit messages

2014-10-21 Thread Yuras Shumovich
On Tue, 2014-10-21 at 09:34 -0400, Richard Eisenberg wrote: Hi all, Is there a way to put `arc` into a read-only mode? Not sure it is relevant, please ignore me if it is not. Does arc diff --preview work for you? It will create a diff without creating revision and changing anything locally.

Re: `arc` changes my commit messages

2014-10-21 Thread Johan Tibell
This is probably the biggest shortcoming of Phab. If you don't want this merging behavior you need to make a separate Phab review *per commit*. When I use arc I usually use git to rewrite the message after the review to something less messy. On Tue, Oct 21, 2014 at 11:04 AM, Richard Eisenberg

Re: `arc` changes my commit messages

2014-10-21 Thread Edward Z. Yang
For a while, I tried working around this using a branch summary patch, which is just an empty commit I kept on top of the patchset which then Phabricator would hit. It was really annoying and Git kept swallowing up. So I eventually gave up and just arc diff'd each patch in the set individually.