Re: Linker.c broken

2016-07-04 Thread Phyx
Or: how can I selectively re-enable it for in my > validate.mk? > > > > *From:* ghc-devs [mailto:ghc-devs-boun...@haskell.org] *On Behalf Of *Phyx > *Sent:* 04 July 2016 13:05 > *To:* Erik de Castro Lopo ; ghc-devs < > ghc-devs@haskell.org> > *Subject:* Re: Linker.

RE: Linker.c broken

2016-07-04 Thread Simon Peyton Jones via ghc-devs
Let’s re-enable it. Or: how can I selectively re-enable it for in my validate.mk? From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Phyx Sent: 04 July 2016 13:05 To: Erik de Castro Lopo ; ghc-devs Subject: Re: Linker.c broken There used to be a bug in the msys2 runtime which

Re: Linker.c broken

2016-07-04 Thread Ben Gamari
Simon Marlow writes: > If parallel tests now work on Windows, could it be enabled by default? > I seem to remember trying this last summer and ran into trouble. That being said, it would be worth trying again. I've fired up another build; we'll see how it goes. Cheers, - Ben signature.asc De

Re: Linker.c broken

2016-07-04 Thread Phyx
There used to be a bug in the msys2 runtime which made certain processes hang on exit in a non deterministic way. So the parallel runs was disabled. I was looking into it but haven't been able to reproduce it at all in months now since either upgrading msys2 or Windows (to Windows 10). We have a

Re: Linker.c broken

2016-07-04 Thread Erik de Castro Lopo
Phyx wrote: > I can build and validate in about an hour myself using 9 jobs on a core i7. > If I revert the change in the testsuite preventing parallel runs for > Windows Oh dear, why is that? Erik -- -- Erik de Castro Lopo htt

Re: Linker.c broken

2016-07-04 Thread Simon Marlow
If parallel tests now work on Windows, could it be enabled by default? On 4 July 2016 at 12:48, Phyx wrote: > I can build and validate in about an hour myself using 9 jobs on a core > i7. If I revert the change in the testsuite preventing parallel runs for > Windows. > > Tamar > > On Mon, Jul 4,

Re: Linker.c broken

2016-07-04 Thread Phyx
I can build and validate in about an hour myself using 9 jobs on a core i7. If I revert the change in the testsuite preventing parallel runs for Windows. Tamar On Mon, Jul 4, 2016, 12:26 Ben Gamari wrote: > "Boespflug, Mathieu" writes: > > > On 4 July 2016 at 12:36, Ben Gamari wrote: > >> Sim

Re: Linker.c broken

2016-07-04 Thread Boespflug, Mathieu
True. Worth a try asking them what limits they're willing to lift for a high profile open source project like GHC, I think. -- Mathieu Boespflug Founder at http://tweag.io. On 4 July 2016 at 13:26, Ben Gamari wrote: > "Boespflug, Mathieu" writes: > >> On 4 July 2016 at 12:36, Ben Gamari wrote:

Re: Linker.c broken

2016-07-04 Thread Ben Gamari
"Boespflug, Mathieu" writes: > On 4 July 2016 at 12:36, Ben Gamari wrote: >> Simon Marlow writes: >> >>> I will fix it, sorry about this. Unfortunately I can't really add a >>> Windows validate into my workflow because it would mean rebooting my laptop >>> into Windows and not doing anything e

Re: Linker.c broken

2016-07-04 Thread Boespflug, Mathieu
On 4 July 2016 at 12:36, Ben Gamari wrote: > Simon Marlow writes: > >> I will fix it, sorry about this. Unfortunately I can't really add a >> Windows validate into my workflow because it would mean rebooting my laptop >> into Windows and not doing anything else for several hours. We need some >

Re: Linker.c broken

2016-07-04 Thread Erik de Castro Lopo
Ben Gamari wrote: > Indeed; and I think it would also be worthwhile also setting up at least > a nightly build validating 32-bit Linux. If its not integrated with the CI, I'm not sure how useful that is. As you may remember I have a Jenkins instance. Once a day it polls git and if there are new

Re: Linker.c broken

2016-07-04 Thread Ben Gamari
Erik de Castro Lopo writes: > Simon Marlow wrote: > >> I will fix it, sorry about this. Unfortunately I can't really add a >> Windows validate into my workflow because it would mean rebooting my laptop >> into Windows and not doing anything else for several hours. > > Even building as 32 bit wou

Re: Linker.c broken

2016-07-04 Thread Ben Gamari
Simon Marlow writes: > I will fix it, sorry about this. Unfortunately I can't really add a > Windows validate into my workflow because it would mean rebooting my laptop > into Windows and not doing anything else for several hours. We need some > CI support for Windows - Ben/Austin any thoughts

Re: Linker.c broken

2016-07-04 Thread Erik de Castro Lopo
Simon Marlow wrote: > It was actually intentional. The patch validated on Travis: > https://travis-ci.org/simonmar/ghc/builds/141572355 and I didn't think it > was worth having it reviewed (but if you want to review all linker patches > I'd be happy to put them on Phabricator in the future). I *

Re: Linker.c broken

2016-07-04 Thread Simon Marlow
On 4 July 2016 at 09:45, Erik de Castro Lopo wrote: > Simon Marlow wrote: > > > I will fix it, sorry about this. Unfortunately I can't really add a > > Windows validate into my workflow because it would mean rebooting my > laptop > > into Windows and not doing anything else for several hours. >

Re: Linker.c broken

2016-07-04 Thread Erik de Castro Lopo
Simon Marlow wrote: > I will fix it, sorry about this. Unfortunately I can't really add a > Windows validate into my workflow because it would mean rebooting my laptop > into Windows and not doing anything else for several hours. Even building as 32 bit would have shaken out a bug in the format

Re: Linker.c broken

2016-07-04 Thread Simon Marlow
2 July 2016 01:02 > | To: ghc-devs > | Subject: Re: Linker.c broken > | > | I'm guessing it's: > | > | commit 6377757918c1e7f63638d6f258cad8d5f02bb6a7 > | Author: Simon Marlow > | Date: Wed Jun 29 21:50:18 2016 +0100 > | > | Linker: som

Re: Linker.c broken

2016-07-04 Thread Erik de Castro Lopo
Simon Peyton Jones via ghc-devs wrote: > rts\Linker.c:1480:28: error: > > error: format '%ls' expects argument of type 'wchar_t *', but argument 3 > has type 'void *' [-Werror=format=] > > debugBelch("%p is in %" PATH_FMT, addr, I get an error on code from this commit

RE: Linker.c broken

2016-07-04 Thread Simon Peyton Jones via ghc-devs
That was it. Simon M: would you care to fix? Or should I push a revert? Simon | -Original Message- | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of | Edward Z. Yang | Sent: 02 July 2016 01:02 | To: ghc-devs | Subject: Re: Linker.c broken | | I'm gue

Re: Linker.c broken

2016-07-01 Thread Edward Z. Yang
I'm guessing it's: commit 6377757918c1e7f63638d6f258cad8d5f02bb6a7 Author: Simon Marlow Date: Wed Jun 29 21:50:18 2016 +0100 Linker: some extra debugging / logging which added ghci_find. Edward Excerpts from Simon Peyton Jones via ghc-devs's message of 2016-07-01 18:51:20 -0400: > Aarg

Linker.c broken

2016-07-01 Thread Simon Peyton Jones via ghc-devs
Aargh! Windows is broken /again/. Some mess-up in Linker.c. I have not yet tried reverting recent patches. Might someone fix please? It’s really helpful to validate on Windows when making RTS changes. Simon rts\Linker.c: In function 'ghci_find': rts\Linker.c:1482:52: error: error: p