-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org
mailto:ghc-devs-boun...@haskell.org] On Behalf Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org mailto:ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the
| administrators for Haskell.org set up an instance of
| Phabricator[1], located
messages are invisible until you
really start digging.
Simon
| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
...@haskell.org] On Behalf
Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the
| administrators for Haskell.org set up an instance
-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 24 June 2014 18:13
| To: Richard Eisenberg
| Cc: ghc-devs@haskell.org
| Subject: Re: Phabricator for patches and code review
|
| Richard,
|
| Thanks, these are all actually really excellent questions.
|
| 1) I'm just setting things up on my
...@haskell.org] On Behalf Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the
| administrators for Haskell.org set up an instance
2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the
| administrators for Haskell.org set up an instance of
| Phabricator[1], located at https
June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the
| administrators for Haskell.org set up an instance of Phabricator[1],
| located at https://phabricator.haskell.org
for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up an instance of Phabricator[1], located at
| https://phabricator.haskell.org
|
| For those who aren't aware, Phabricator (or Phab) is a suite of tools
| for software
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up an instance of Phabricator[1], located at
| https
Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up an instance of Phabricator[1], located
@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up an instance of Phabricator[1], located at
| https://phabricator.haskell.org
|
| For those who aren't aware, Phabricator
PS I couldn't get past the login box at https://phabricator.haskell.org/D4
| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
[mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up
2014-06-06 7:05 GMT+03:00 Austin Seipp aus...@well-typed.com:
2) Phabricator in particular makes it very easy to submit patches for
review. To submit a patch, I just run the command 'arc diff' and it
Does The Right Thing. It also makes it easy to ensure people are
*alerted* when a patch might
tl;dir I strongly support this, but for code review only, and only if we
can integrate it well with Trac.
Phabricator is what we use internally at Facebook, and it's a really
good code review tool (better than github, IMO). For one thing, you
only get one email for a complete review, rather
I haven't looked deeply into Trac integration yet, but I believe this
should generally be possible. I'll probably pester the developers
about it later today. I'm glad people seem receptive to it.
I don't think Arcanist will be a barrier, actually. Here's what I
propose: we add arcanist and
No, at the moment Phabricator is not integrated with any testing
functionality. It could be, but that would be a bit of work I think to
integrate with GHC's ./validate process. It would be nice to have
long-term, however, but I don't think it's necessary right now - I run
./validate before every
Piggybacking a bit on Ömer's point:
It is often the case that something flies by that I can fix in a few moments
(for example, #9163) but that I have to defer until I have enough time for a
GHC hacking session. Making even a tiny patch requires that I'm up-to-date,
that my unchanged tree
Richard, I think Phabricator would suit this just fine.
Here's (roughly) how Phabricator will work from a GHC hackers point of view.
1) I have a thing I want. Make a branch, hack hack hack away.
$ git branch new-thing
$ git checkout new-thing
$ emacs
$ git commit -a -m Add minor new
Hello all,
Recently, while doing server maintenance, several of the
administrators for Haskell.org set up an instance of Phabricator[1],
located at https://phabricator.haskell.org
For those who aren't aware, Phabricator (or Phab) is a suite of
tools for software development. Think of it like a
while i'm a novice at using ANY code review tools, having some persistent
tooling for patch reviews would be really great! theres a lot of good
feedback that otherwise only exists in an email somewhere!
On Fri, Jun 6, 2014 at 12:05 AM, Austin Seipp aus...@well-typed.com wrote:
Hello all,
22 matches
Mail list logo
