RE: Broken Data.Data instances

2014-08-15 Thread Simon Peyton Jones
. Hölzenspies Cc: Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org Subject: Re: Broken Data.Data instances And I dipped my toes into the phabricator water, and uploaded a diff to https://phabricator.haskell.org/D153 I left the lines long for now, so that it is clear that I simply added

Re: Broken Data.Data instances

2014-08-15 Thread Richard Eisenberg
is, of course, a good one ;) Regards, Philip From: Alan Kim Zimmerman [mailto:alan.z...@gmail.com] Sent: maandag 28 juli 2014 14:10 To: Holzenspies, P.K.F. (EWI) Cc: Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org Subject: Re: Broken Data.Data instances Philip I

Re: Broken Data.Data instances

2014-08-15 Thread Alan Kim Zimmerman
;) Regards, Philip *From:* Alan Kim Zimmerman [mailto:alan.z...@gmail.com] *Sent:* maandag 28 juli 2014 14:10 *To:* Holzenspies, P.K.F. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason

RE: Broken Data.Data instances

2014-08-15 Thread Simon Peyton Jones
: Philip K.F. Hölzenspies; Edward Kmett; ghc-devs@haskell.org Subject: Re: Broken Data.Data instances Did you look at https://phabricator.haskell.org/D157? It superseded https://phabricator.haskell.org/D153 On Fri, Aug 15, 2014 at 5:17 PM, Simon Peyton Jones simo...@microsoft.commailto:simo

Re: Broken Data.Data instances

2014-08-13 Thread Alan Kim Zimmerman
Zimmerman [mailto:alan.z...@gmail.com] *Sent:* maandag 28 juli 2014 14:10 *To:* Holzenspies, P.K.F. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason for the WrongPhase thing is to have something

RE: Broken Data.Data instances

2014-08-13 Thread p.k.f.holzenspies
-devs@haskell.org Subject: Re: Broken Data.Data instances And I dipped my toes into the phabricator water, and uploaded a diff to https://phabricator.haskell.org/D153 I left the lines long for now, so that it is clear that I simply added parameters to existing type signatures. On Tue, Aug 12, 2014

Re: Broken Data.Data instances

2014-08-13 Thread Alan Kim Zimmerman
, Philip *From:* Alan Kim Zimmerman [mailto:alan.z...@gmail.com] *Sent:* maandag 28 juli 2014 14:10 *To:* Holzenspies, P.K.F. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason

Re: Broken Data.Data instances

2014-08-12 Thread Alan Kim Zimmerman
] *Sent:* maandag 28 juli 2014 14:10 *To:* Holzenspies, P.K.F. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason for the WrongPhase thing is to have something that explicitly has a Data and Typeable

RE: Broken Data.Data instances

2014-07-28 Thread Simon Peyton Jones
Subject: Re: Broken Data.Data instances Philip, Alan, If you need a hand, I'm happy to pitch in guidance. I've had to mangle a bunch of hand-written Data instances and push out patches to a dozen packages that used to be built this way before I convinced the authors to switch to safer versions

Re: Broken Data.Data instances

2014-07-28 Thread Alan Kim Zimmerman
; Simon Peyton Jones; ghc-devs *Subject:* Re: Broken Data.Data instances Philip, Alan, If you need a hand, I'm happy to pitch in guidance. I've had to mangle a bunch of hand-written Data instances and push out patches to a dozen packages that used to be built this way before I convinced

RE: Broken Data.Data instances

2014-07-28 Thread p.k.f.holzenspies
...@gmail.com] Sent: maandag 28 juli 2014 11:14 To: Simon Peyton Jones Cc: Edward Kmett; Holzenspies, P.K.F. (EWI); ghc-devs Subject: Re: Broken Data.Data instances I have made a conceptual example of this here http://lpaste.net/108262 Alan On Mon, Jul 28, 2014 at 9:50 AM, Alan Kim Zimmerman alan.z

RE: Broken Data.Data instances

2014-07-28 Thread p.k.f.holzenspies
them twice. Any ideas on this, Edward? Regards, Philip From: Alan Kim Zimmerman [mailto:alan.z...@gmail.com] Sent: maandag 28 juli 2014 11:14 To: Simon Peyton Jones Cc: Edward Kmett; Holzenspies, P.K.F. (EWI); ghc-devs Subject: Re: Broken Data.Data instances I have made a conceptual example

RE: Broken Data.Data instances

2014-07-28 Thread p.k.f.holzenspies
, Philip From: Alan Kim Zimmerman [mailto:alan.z...@gmail.com] Sent: maandag 28 juli 2014 14:10 To: Holzenspies, P.K.F. (EWI) Cc: Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org Subject: Re: Broken Data.Data instances Philip I think the main reason for the WrongPhase thing is to have something

Re: Broken Data.Data instances

2014-07-28 Thread Alan Kim Zimmerman
, Philip *From:* Alan Kim Zimmerman [mailto:alan.z...@gmail.com] *Sent:* maandag 28 juli 2014 14:10 *To:* Holzenspies, P.K.F. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason

Re: Broken Data.Data instances

2014-07-28 Thread Alan Kim Zimmerman
. (EWI) *Cc:* Simon Peyton Jones; Edward Kmett; ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Philip I think the main reason for the WrongPhase thing is to have something that explicitly has a Data and Typeable instance, to allow generic (SYB) traversal. If we can get

RE: Broken Data.Data instances

2014-07-27 Thread p.k.f.holzenspies
removable). Regards, Philip Van: Alan Kim Zimmerman [alan.z...@gmail.com] Verzonden: vrijdag 25 juli 2014 13:44 Aan: Simon Peyton Jones CC: Holzenspies, P.K.F. (EWI); ghc-devs@haskell.org Onderwerp: Re: Broken Data.Data instances By the way, I would be happy

Re: Broken Data.Data instances

2014-07-27 Thread Alan Kim Zimmerman
[alan.z...@gmail.com] *Verzonden:* vrijdag 25 juli 2014 13:44 *Aan:* Simon Peyton Jones *CC:* Holzenspies, P.K.F. (EWI); ghc-devs@haskell.org *Onderwerp:* Re: Broken Data.Data instances By the way, I would be happy to attempt this task, if the concept is viable. On Thu, Jul 24, 2014 at 11:23

Re: Broken Data.Data instances

2014-07-27 Thread Alan Kim Zimmerman
, P.K.F. (EWI); ghc-devs@haskell.org *Onderwerp:* Re: Broken Data.Data instances By the way, I would be happy to attempt this task, if the concept is viable. On Thu, Jul 24, 2014 at 11:23 PM, Alan Kim Zimmerman alan.z...@gmail.com wrote: While we are talking about fixing traversals

Re: Broken Data.Data instances

2014-07-27 Thread Edward Kmett
*CC:* Holzenspies, P.K.F. (EWI); ghc-devs@haskell.org *Onderwerp:* Re: Broken Data.Data instances By the way, I would be happy to attempt this task, if the concept is viable. On Thu, Jul 24, 2014 at 11:23 PM, Alan Kim Zimmerman alan.z...@gmail.com wrote: While we are talking about

Re: Broken Data.Data instances

2014-07-27 Thread Alan Kim Zimmerman
@haskell.org *Onderwerp:* Re: Broken Data.Data instances By the way, I would be happy to attempt this task, if the concept is viable. On Thu, Jul 24, 2014 at 11:23 PM, Alan Kim Zimmerman alan.z...@gmail.com wrote: While we are talking about fixing traversals, how about getting rid

Re: Broken Data.Data instances

2014-07-27 Thread Richard Eisenberg
] Verzonden: vrijdag 25 juli 2014 13:44 Aan: Simon Peyton Jones CC: Holzenspies, P.K.F. (EWI); ghc-devs@haskell.org Onderwerp: Re: Broken Data.Data instances By the way, I would be happy to attempt this task, if the concept is viable. On Thu, Jul 24, 2014 at 11:23 PM, Alan Kim Zimmerman

Re: Broken Data.Data instances

2014-07-27 Thread Edward Kmett
-- *Van:* Alan Kim Zimmerman [alan.z...@gmail.com] *Verzonden:* vrijdag 25 juli 2014 13:44 *Aan:* Simon Peyton Jones *CC:* Holzenspies, P.K.F. (EWI); ghc-devs@haskell.org *Onderwerp:* Re: Broken Data.Data instances By the way, I would be happy to attempt this task

Re: Broken Data.Data instances

2014-07-25 Thread Alan Kim Zimmerman
divergence (which it might well be), and (b) the pitfalls are documented. Simon *From:* Philip K.F. Hölzenspies [mailto:p.k.f.holzensp...@utwente.nl] *Sent:* 24 July 2014 18:42 *To:* Simon Peyton Jones *Cc:* ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Dear Simon, et

RE: Broken Data.Data instances

2014-07-24 Thread Simon Peyton Jones
GHC's data structures are often mutually recursive. e.g. * The TyCon for Maybe contains the DataCon for Just * The DataCon For just contains Just's type * Just's type contains the TyCon for Maybe So any attempt to recursively walk over all these structures, as you would

Re: Broken Data.Data instances

2014-07-24 Thread Philip K.F. Hölzenspies
Dear Simon, et al, These are very good points to make for people writing such traversals and queries. I would be more than happy to write a page on the pitfalls etc. on the wiki, but in my experience so far, exploring the innards of GHC is tremendously helped by trying small things out and

Re: Broken Data.Data instances

2014-07-24 Thread Alan Kim Zimmerman
*To:* Simon Peyton Jones *Cc:* ghc-devs@haskell.org *Subject:* Re: Broken Data.Data instances Dear Simon, et al, These are very good points to make for people writing such traversals and queries. I would be more than happy to write a page on the pitfalls etc. on the wiki, but in my experience