Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-15 Thread Ben Gamari
Phyx writes: [snip] Hi Phyx, Sorry for the late reply here; Jared did a good job of summarizing the effort. I just want to make sure that we clearly put this particular concern to rest: > This would be unfortunate as it would mean we would effectively stop > tracking

Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-11 Thread Jared Weakly
Hi Phyx, Sorry for the late reply. I already implemented a wait and retry approach since it seemed the most sensible. Let me see if I can clear this up a bit. Suppose you want to check out a new branch and work on a feature. You check out that branch, run the testsuite once (using

Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-07 Thread Phyx
Hi Jared, On Tue, Sep 5, 2017, 19:39 Jared Weakly wrote: > Hi Tamar, > > That framework failure is due to a somewhat embarrassing error that I > thought I had caught earlier; line 298 shouldn't have existed (it was > a small mistake from converting the all.T file from using the

Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-05 Thread Jared Weakly
Hi Tamar, That framework failure is due to a somewhat embarrassing error that I thought I had caught earlier; line 298 shouldn't have existed (it was a small mistake from converting the all.T file from using the old function to using the new collect_stats function. I have fixed this and it will

Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-04 Thread Phyx
Hi Jared, First off, thanks for all the hard work on this. I checked out your branch and made a run, I noticed at the end it had Framework failures: . ./perf/compiler/all.T [] (unexpected indent (, line 298)) so I assume none of the perf tests were run? Though I do see a .git/refs/notes/perf,

Re: Feedback request regarding HSOC project (bringing sanity to the GHC performance test-suite)

2017-09-03 Thread Richard Eisenberg
Hi Jared, I have nothing in particular to offer in the way of feedback, other than that this sounds great. Thanks for doing this, and good luck finishing up the work! Richard > On Sep 1, 2017, at 5:00 AM, Jared Weakly wrote: > > Hey y'all, > > A quick ToC before I dive