Show instance for SrcSpan

2014-10-06 Thread Alan Kim Zimmerman
Is there any reason I can't put in a diff request to replace the derived Show instance for SrcSpan with a handcrafted one that does not exhausively list the constructors, making it more readable? Alan ___ ghc-devs mailing list ghc-devs@haskell.org http

Re: Show instance for SrcSpan

2014-10-06 Thread Mateusz Kowalczyk
On 10/06/2014 01:59 PM, Alan Kim Zimmerman wrote: Is there any reason I can't put in a diff request to replace the derived Show instance for SrcSpan with a handcrafted one that does not exhausively list the constructors, making it more readable? Alan Why? If you're looking for pretty

Re: Show instance for SrcSpan

2014-10-06 Thread Johan Tibell
information. On Mon, Oct 6, 2014 at 3:11 PM, Mateusz Kowalczyk fuuze...@fuuzetsu.co.uk wrote: On 10/06/2014 01:59 PM, Alan Kim Zimmerman wrote: Is there any reason I can't put in a diff request to replace the derived Show instance for SrcSpan with a handcrafted one that does not exhausively

Re: Show instance for SrcSpan

2014-10-06 Thread Alan Kim Zimmerman
/06/2014 01:59 PM, Alan Kim Zimmerman wrote: Is there any reason I can't put in a diff request to replace the derived Show instance for SrcSpan with a handcrafted one that does not exhausively list the constructors, making it more readable? Alan Why? If you're looking for pretty

Re: Show instance for SrcSpan

2014-10-06 Thread Matthias Fischmann
On Mon, Oct 06, 2014 at 02:59:03PM +0200, Alan Kim Zimmerman wrote: Date: Mon, 6 Oct 2014 14:59:03 +0200 From: Alan Kim Zimmerman alan.z...@gmail.com To: ghc-devs@haskell.org ghc-devs@haskell.org Subject: Show instance for SrcSpan Is there any reason I can't put in a diff request

Re: Show instance for SrcSpan

2014-10-06 Thread Alan Kim Zimmerman
, Alan Kim Zimmerman wrote: Date: Mon, 6 Oct 2014 14:59:03 +0200 From: Alan Kim Zimmerman alan.z...@gmail.com To: ghc-devs@haskell.org ghc-devs@haskell.org Subject: Show instance for SrcSpan Is there any reason I can't put in a diff request to replace the derived Show instance

Re: Show instance for SrcSpan

2014-10-06 Thread Matthias Fischmann
...@zerobuzz.net Cc: ghc-devs@haskell.org ghc-devs@haskell.org Subject: Re: Show instance for SrcSpan Not at all, just show as e.g. SrcSpan (RealSrcSpan (SrcSpanOneLine ./foo.hs 4 1 6)) We just avoid showing the srcSpanFile / srcSpanLine / srcSpanSCol / srcSpanECol noise On Mon, Oct 6

Re: Show instance for SrcSpan

2014-10-06 Thread Alan Kim Zimmerman
+0200, Alan Kim Zimmerman wrote: Date: Mon, 6 Oct 2014 15:27:49 +0200 From: Alan Kim Zimmerman alan.z...@gmail.com To: Matthias Fischmann m...@zerobuzz.net Cc: ghc-devs@haskell.org ghc-devs@haskell.org Subject: Re: Show instance for SrcSpan Not at all, just show as e.g. SrcSpan

RE: Show instance for SrcSpan

2014-10-06 Thread p.k.f.holzenspies
: ghc-devs@haskell.org Subject: Re: Show instance for SrcSpan True, but if you are using GHC generated stuff via the GHC API you sometimes do not want to have to implement Outputable for all your app types, when you can auto derive Show which mostly does what you need. On Mon, Oct 6, 2014 at 3:11

RE: Show instance for SrcSpan

2014-10-06 Thread Simon Peyton Jones
By all means do so S From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Alan Kim Zimmerman Sent: 06 October 2014 13:59 To: ghc-devs@haskell.org Subject: Show instance for SrcSpan Is there any reason I can't put in a diff request to replace the derived Show instance for SrcSpan