Re: classP recently deleted from TH.Lib

2014-05-19 Thread Gabor Greif
All, just pushed 4117551 and 135489d. Any feedback appreciated. Cheers, Gabor On 5/14/14, Gabor Greif ggr...@gmail.com wrote: Alrighty, this is what I have now. If you think this is ok, I'll go on re-implementing equalP too and commit. Then we can bikeshed about the deprecation

Re: classP recently deleted from TH.Lib

2014-05-14 Thread Gregory Collins
On Mon, May 12, 2014 at 4:58 PM, Richard Eisenberg e...@cis.upenn.eduwrote: We could, of course, just leave the functions there with new implementations, but that feels like it could accumulate legacy functions over time. I think the ultimate goal of removing the function was not unwise of

Re: classP recently deleted from TH.Lib

2014-05-14 Thread Gabor Greif
Alrighty, this is what I have now. If you think this is ok, I'll go on re-implementing equalP too and commit. Then we can bikeshed about the deprecation message :-) diff --git a/libraries/template-haskell/Language/Haskell/TH/Lib.hs b/libraries/template-haskell/Language/Haskell/TH/Lib.hs index

Re: classP recently deleted from TH.Lib

2014-05-13 Thread Mateusz Kowalczyk
On 05/13/2014 12:33 AM, Gabor Greif wrote: On 5/12/14, Richard Eisenberg e...@cis.upenn.edu wrote: This one was my fault/decision. The TH.Lib functions tend to mirror exactly the constructors in TH.Syntax. We removed the constructors (for good reason Hmmm, okay, I see you added `equalityT`

Re: classP recently deleted from TH.Lib

2014-05-13 Thread Carter Schonwald
i'm quite certain BScarlet will accept patches to fix up llvm-general-pure for ghc head. Hes a very responsive author On Mon, May 12, 2014 at 6:33 PM, Gabor Greif ggr...@gmail.com wrote: On 5/12/14, Richard Eisenberg e...@cis.upenn.edu wrote: This one was my fault/decision. The TH.Lib

classP recently deleted from TH.Lib

2014-05-12 Thread Gabor Greif
The last two commits from (Apr 9) on https://github.com/ghc/packages-template-haskell/commits/master/Language/Haskell/TH/Lib.hs removed a helper to construct applied type class constraints (`classP`). Some packages (notably `llvm-general-pure`) though, depend on it. Can we add back something

Re: classP recently deleted from TH.Lib

2014-05-12 Thread Johan Tibell
That would be nice. I had to fix some breakage caused by this in one of Bryan's libraries. On Mon, May 12, 2014 at 4:12 PM, Gabor Greif ggr...@gmail.com wrote: The last two commits from (Apr 9) on https://github.com/ghc/packages-template-haskell/commits/master/Language/Haskell/TH/Lib.hs

Re: classP recently deleted from TH.Lib

2014-05-12 Thread Gabor Greif
Forgot to explicitly state that this is with 7.9 HEAD. 7.8.2 is delivered with template-haskell 2.9.0.0, which contains the `classP` helper. Richard, if you also support my suggestion, I'll go forward and push it. Cheers, Gabor On 5/12/14, Johan Tibell johan.tib...@gmail.com wrote: That

RE: classP recently deleted from TH.Lib

2014-05-12 Thread Simon Peyton Jones
I suspect it was accidental, but Richard will doubtless say in due course Simon From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Johan Tibell Sent: 12 May 2014 15:35 To: Gabor Greif Cc: ghc-devs Subject: Re: classP recently deleted from TH.Lib That would be nice. I had to fix

Re: classP recently deleted from TH.Lib

2014-05-12 Thread Richard Eisenberg
This one was my fault/decision. The TH.Lib functions tend to mirror exactly the constructors in TH.Syntax. We removed the constructors (for good reason -- predicates and types really are the same now), so I thought it best to remove the TH.Lib function, too. In the cases where code had to be

Re: classP recently deleted from TH.Lib

2014-05-12 Thread Gabor Greif
On 5/12/14, Richard Eisenberg e...@cis.upenn.edu wrote: This one was my fault/decision. The TH.Lib functions tend to mirror exactly the constructors in TH.Syntax. We removed the constructors (for good reason Hmmm, okay, I see you added `equalityT` which is just a shallow wrapper around a new