Re: phabricator issue with git submodules.

2014-07-27 Thread Edward Z . Yang
That's right. I am actually not even sure how Harbormaster even manages to find your commits for the build... Edward Excerpts from Karel Gardas's message of 2014-07-27 18:02:24 +0100: > > Hello Edward, > > I've done that, see https://phabricator.haskell.org/D96 -- but now I'm > curious but si

Re: phabricator issue with git submodules.

2014-07-27 Thread Karel Gardas
Hello Edward, I've done that, see https://phabricator.haskell.org/D96 -- but now I'm curious but since this is done in this way, basically speaking library/unix + libraries/primitive now points to commits done in my forks of those libs on github.com waiting for approval since I already pushe

Re: phabricator issue with git submodules.

2014-07-26 Thread Edward Z . Yang
Hello Karel, When your submodules get updated, you need to add them to your commit (since the parent repository maintains pointers to the submodules). Then they will no longer show up as dirty and you can submit the Phabricator patch. Edward Excerpts from Karel Gardas's message of 2014-07-25 22:

phabricator issue with git submodules.

2014-07-25 Thread Karel Gardas
Hi, just fixing few warning issues on Solaris/x86. The changes spread over main ghc tree and libraries/primitive and libraries/unix. I already commited changes and pushed to my github.com's forks of libraries/primitive and libraries/unix. The git status looks then: $ git status On branch ma