RE: Injective type families

2016-01-11 Thread Ben Gamari
Simon Peyton Jones writes: > I agree! > Currently InjectiveTypeFamilies is in the tree but it's not too late to change it. Of course, this means that we need to decide what to do about the -rc1 release. I finished the builds earlier today but have been sitting on them to

Phab not running a full validate?

2016-01-11 Thread Richard Eisenberg
Hi devs, Take a look at https://phabricator.haskell.org/harbormaster/build/9990/ See how only 1 test was run. Is this expected? Does Phab now bail when it runs into an error? Or have I done something wrong? Thanks, Richard ___ ghc-devs mailing list

Re: Phab not running a full validate?

2016-01-11 Thread Matthew Pickering
I think it does run them all. If you look at the full stdout log it runs the failing tests again after finishing the run. Matt On 12 Jan 2016 00:59, "Richard Eisenberg" wrote: > Hi devs, > > Take a look at https://phabricator.haskell.org/harbormaster/build/9990/ > > See how

Re: Injective type families

2016-01-11 Thread Richard Eisenberg
I'm joining this conversation late, but I favor TypeFamilyDependencies over InjectiveTypeFamilies. We use the annotations for things other than injectivity! For example, > type family Plus a b = r | r a -> b, r b -> a is not injective under any common understanding of the word. And the

RE: Injective type families

2016-01-11 Thread Simon Peyton Jones
I agree! | -Original Message- | From: Richard Eisenberg [mailto:e...@cis.upenn.edu] | Sent: 11 January 2016 16:35 | To: Jan Stolarek | Cc: Simon Peyton Jones ; GHC developers | Subject: Re: Injective type families | | I'm joining