RE: [commit: ghc] master: Adjust test suite stats (a055f24)

2017-08-28 Thread Simon Peyton Jones via ghc-devs
Ha!  They didn’t regress for me.  I validated before committing.  How strange.

I agree about keeping it green

Simon

From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of David Feuer
Sent: 28 August 2017 22:13
To: ghc-devs 
Subject: RE: [commit: ghc] master: Adjust test suite stats (a055f24)

These were regressions from your simplifier refactoring. Yes, we should 
investigate. I'll open a ticket this evening, unless someone else gets to it 
first. But we surely don't want to keep CI red on every commit until then.



David Feuer
Well-Typed, LLP

 Original message 
From: Simon Peyton Jones via ghc-devs 
>
Date: 8/28/17 4:57 PM (GMT-05:00)
To: ghc-devs@haskell.org
Subject: RE: [commit: ghc] master: Adjust test suite stats (a055f24)

David, are you sure we want to accept a more than 5% increase in compile time 
without investigation?   What commit caused these increases?  Maybe they are 
readily squashed? Generally we are trying to improve compiler perf not accept 
it getting worse!

Simon

| -Original Message-
| From: ghc-commits [mailto:ghc-commits-boun...@haskell.org] On Behalf Of
| g...@git.haskell.org
| Sent: 28 August 2017 19:34
| To: ghc-comm...@haskell.org
| Subject: [commit: ghc] master: Adjust test suite stats (a055f24)
|
| Repository : ssh://g...@git.haskell.org/ghc
|
| On branch  : master
| Link   :
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske
| ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db
| 7%2Fghc=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D=0
|
| >---
|
| commit a055f240aeda538c656a59e810870e6a2ccc2db7
| Author: David Feuer >
| Date:   Mon Aug 28 14:35:19 2017 -0400
|
| Adjust test suite stats
|
| T1969 and T12150 were failing (stat too high)
|
|
| >---
|
| a055f240aeda538c656a59e810870e6a2ccc2db7
|  testsuite/tests/perf/compiler/all.T | 6 --
|  1 file changed, 4 insertions(+), 2 deletions(-)
|
| diff --git a/testsuite/tests/perf/compiler/all.T
| b/testsuite/tests/perf/compiler/all.T
| index 1da2883..cf49981 100644
| --- a/testsuite/tests/perf/compiler/all.T
| +++ b/testsuite/tests/perf/compiler/all.T
| @@ -72,7 +72,7 @@ test('T1969',
|   # 2017-03-24 9261052 (x86/Linux, 64-bit machine)
|   # 2017-04-06 9418680 (x86/Linux, 64-bit machine)
|
| -   (wordsize(64), 16679176, 15)]),
| +   (wordsize(64), 19199872, 15)]),
|   # 2014-09-10 10463640, 10  # post-AMP-update (somewhat
| stabelish)
| # looks like the peak is around ~10M, but we're
| # unlikely to GC exactly on the peak.
| @@ -87,6 +87,7 @@ test('T1969',
|   # 2017-02-01 19924328 (amd64/Linux) Join points (#12988)
|   # 2017-02-14 16393848 Early inline patch
|   # 2017-03-31 16679176 Fix memory leak in simplifier
| + # 2017-08-25 19199872 Refactor the Mighty Simplifier
|
|compiler_stats_num_field('bytes allocated',
|[(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7
| +,8 @@ test('T12150',
|   [ only_ways(['optasm']),
| compiler_stats_num_field('bytes allocated',
|[(wordsize(64), 70773000, 5)
| -  # initial:  70773000
| +  # initial:70773000
| +  # 2017-08-25: 74358208  Refactor the Mighty Simplifier
|]),
|   ],
|  compile,
|
| ___
| ghc-commits mailing list
| ghc-comm...@haskell.org
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask
| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
| commits=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D=0
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: [commit: ghc] master: Adjust test suite stats (a055f24)

2017-08-28 Thread David Feuer
These were regressions from your simplifier refactoring. Yes, we should 
investigate. I'll open a ticket this evening, unless someone else gets to it 
first. But we surely don't want to keep CI red on every commit until then.


David FeuerWell-Typed, LLP
 Original message From: Simon Peyton Jones via ghc-devs 
 Date: 8/28/17  4:57 PM  (GMT-05:00) To: 
ghc-devs@haskell.org Subject: RE: [commit: ghc] master: Adjust test suite stats 
(a055f24) 
David, are you sure we want to accept a more than 5% increase in compile time 
without investigation?   What commit caused these increases?  Maybe they are 
readily squashed? Generally we are trying to improve compiler perf not accept 
it getting worse!

Simon

| -Original Message-
| From: ghc-commits [mailto:ghc-commits-boun...@haskell.org] On Behalf Of
| g...@git.haskell.org
| Sent: 28 August 2017 19:34
| To: ghc-comm...@haskell.org
| Subject: [commit: ghc] master: Adjust test suite stats (a055f24)
| 
| Repository : ssh://g...@git.haskell.org/ghc
| 
| On branch  : master
| Link   :
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske
| ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db
| 7%2Fghc=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D=0
| 
| >---
| 
| commit a055f240aeda538c656a59e810870e6a2ccc2db7
| Author: David Feuer 
| Date:   Mon Aug 28 14:35:19 2017 -0400
| 
| Adjust test suite stats
| 
| T1969 and T12150 were failing (stat too high)
| 
| 
| >---
| 
| a055f240aeda538c656a59e810870e6a2ccc2db7
|  testsuite/tests/perf/compiler/all.T | 6 --
|  1 file changed, 4 insertions(+), 2 deletions(-)
| 
| diff --git a/testsuite/tests/perf/compiler/all.T
| b/testsuite/tests/perf/compiler/all.T
| index 1da2883..cf49981 100644
| --- a/testsuite/tests/perf/compiler/all.T
| +++ b/testsuite/tests/perf/compiler/all.T
| @@ -72,7 +72,7 @@ test('T1969',
|   # 2017-03-24 9261052 (x86/Linux, 64-bit machine)
|   # 2017-04-06 9418680 (x86/Linux, 64-bit machine)
| 
| -   (wordsize(64), 16679176, 15)]),
| +   (wordsize(64), 19199872, 15)]),
|   # 2014-09-10 10463640, 10  # post-AMP-update (somewhat
| stabelish)
| # looks like the peak is around ~10M, but we're
| # unlikely to GC exactly on the peak.
| @@ -87,6 +87,7 @@ test('T1969',
|   # 2017-02-01 19924328 (amd64/Linux) Join points (#12988)
|   # 2017-02-14 16393848 Early inline patch
|   # 2017-03-31 16679176 Fix memory leak in simplifier
| + # 2017-08-25 19199872 Refactor the Mighty Simplifier
| 
|    compiler_stats_num_field('bytes allocated',
|    [(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7
| +,8 @@ test('T12150',
|   [ only_ways(['optasm']),
| compiler_stats_num_field('bytes allocated',
|    [(wordsize(64), 70773000, 5)
| -  # initial:  70773000
| +  # initial:    70773000
| +  # 2017-08-25: 74358208  Refactor the Mighty Simplifier
|    ]),
|   ],
|  compile,
| 
| ___
| ghc-commits mailing list
| ghc-comm...@haskell.org
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask
| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
| commits=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D=0
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: [commit: ghc] master: Adjust test suite stats (a055f24)

2017-08-28 Thread Simon Peyton Jones via ghc-devs
David, are you sure we want to accept a more than 5% increase in compile time 
without investigation?   What commit caused these increases?  Maybe they are 
readily squashed? Generally we are trying to improve compiler perf not accept 
it getting worse!

Simon

| -Original Message-
| From: ghc-commits [mailto:ghc-commits-boun...@haskell.org] On Behalf Of
| g...@git.haskell.org
| Sent: 28 August 2017 19:34
| To: ghc-comm...@haskell.org
| Subject: [commit: ghc] master: Adjust test suite stats (a055f24)
| 
| Repository : ssh://g...@git.haskell.org/ghc
| 
| On branch  : master
| Link   :
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske
| ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db
| 7%2Fghc=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D=0
| 
| >---
| 
| commit a055f240aeda538c656a59e810870e6a2ccc2db7
| Author: David Feuer 
| Date:   Mon Aug 28 14:35:19 2017 -0400
| 
| Adjust test suite stats
| 
| T1969 and T12150 were failing (stat too high)
| 
| 
| >---
| 
| a055f240aeda538c656a59e810870e6a2ccc2db7
|  testsuite/tests/perf/compiler/all.T | 6 --
|  1 file changed, 4 insertions(+), 2 deletions(-)
| 
| diff --git a/testsuite/tests/perf/compiler/all.T
| b/testsuite/tests/perf/compiler/all.T
| index 1da2883..cf49981 100644
| --- a/testsuite/tests/perf/compiler/all.T
| +++ b/testsuite/tests/perf/compiler/all.T
| @@ -72,7 +72,7 @@ test('T1969',
|   # 2017-03-24 9261052 (x86/Linux, 64-bit machine)
|   # 2017-04-06 9418680 (x86/Linux, 64-bit machine)
| 
| -   (wordsize(64), 16679176, 15)]),
| +   (wordsize(64), 19199872, 15)]),
|   # 2014-09-10 10463640, 10  # post-AMP-update (somewhat
| stabelish)
| # looks like the peak is around ~10M, but we're
| # unlikely to GC exactly on the peak.
| @@ -87,6 +87,7 @@ test('T1969',
|   # 2017-02-01 19924328 (amd64/Linux) Join points (#12988)
|   # 2017-02-14 16393848 Early inline patch
|   # 2017-03-31 16679176 Fix memory leak in simplifier
| + # 2017-08-25 19199872 Refactor the Mighty Simplifier
| 
|compiler_stats_num_field('bytes allocated',
|[(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7
| +,8 @@ test('T12150',
|   [ only_ways(['optasm']),
| compiler_stats_num_field('bytes allocated',
|[(wordsize(64), 70773000, 5)
| -  # initial:  70773000
| +  # initial:70773000
| +  # 2017-08-25: 74358208  Refactor the Mighty Simplifier
|]),
|   ],
|  compile,
| 
| ___
| ghc-commits mailing list
| ghc-comm...@haskell.org
| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask
| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
| commits=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&
| sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D=0
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


Re: Alex install failure

2017-08-28 Thread Brandon Allbery
On Mon, Aug 28, 2017 at 1:42 PM, Ben Gamari  wrote:

> Hmm, interesting. So it seems almost certain at this point that you are
> not running the lock daemon. In contrast, on an NFSv3 client that I
> setup I see,
>

This is moderately likely to be common: many people incorrectly believe the
lock manager is a server-only daemon, and reliance on file locking is
uncommon enough that they are rarely disabused of this belief.

-- 
brandon s allbery kf8nh   sine nomine associates
allber...@gmail.com  ballb...@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonadhttp://sinenomine.net
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Alex install failure

2017-08-28 Thread Ben Gamari
Ben Gamari  writes:

snip
> Hmmm. I'll need to do some reading at this point.
>
I am now able to reproduce the issue locally. Stay tuned.


signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Alex install failure

2017-08-28 Thread Ben Gamari
Simon Peyton Jones  writes:

> sudo rpcinfo -p
>program vers proto   port  service
> 104   tcp111  portmapper
> 103   tcp111  portmapper
> 102   tcp111  portmapper
> 104   udp111  portmapper
> 103   udp111  portmapper
> 102   udp111  portmapper
> 1000241   udp  56434  status
> 1000241   tcp  34797  status
> simonpj@cam-05-unx:~/code/HEAD$
>
Hmm, interesting. So it seems almost certain at this point that you are
not running the lock daemon. In contrast, on an NFSv3 client that I
setup I see,

$ sudo rpcinfo -p
   program vers proto   port  service
104   tcp111  portmapper
103   tcp111  portmapper
102   tcp111  portmapper
104   udp111  portmapper
103   udp111  portmapper
102   udp111  portmapper
1000241   udp  42146  status
1000241   tcp  44535  status
1000211   udp  33470  nlockmgr
1000213   udp  33470  nlockmgr
1000214   udp  33470  nlockmgr
1000211   tcp  40385  nlockmgr
1000213   tcp  40385  nlockmgr
1000214   tcp  40385  nlockmgr

Hmmm. I'll need to do some reading at this point.

Cheers,

- Ben



signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Alex install failure

2017-08-28 Thread Simon Peyton Jones via ghc-devs
sudo rpcinfo -p
   program vers proto   port  service
104   tcp111  portmapper
103   tcp111  portmapper
102   tcp111  portmapper
104   udp111  portmapper
103   udp111  portmapper
102   udp111  portmapper
1000241   udp  56434  status
1000241   tcp  34797  status
simonpj@cam-05-unx:~/code/HEAD$

|  -Original Message-
|  From: Ben Gamari [mailto:b...@smart-cactus.org]
|  Sent: 28 August 2017 13:36
|  To: Simon Peyton Jones ; Herbert Valerio Riedel
|  ; ghc-devs 
|  Subject: RE: Alex install failure
|  
|  Simon Peyton Jones via ghc-devs  writes:
|  
|  > |  note that you mistyped "lockd" (aka "lock daemon") as "locd"
|  >
|  > Oh, sorry about mistyping
|  >
|  > simonpj@cam-05-unx:~/tmp$ ps -Af | grep lockd
|  > root   140 2  0  2016 ?00:00:00 [kblockd]
|  > simonpj   7882  1184  0 13:22 pts/700:00:00 grep lockd
|  >
|  Interesting; no lock daemon.
|  
|  > |  also, the output of "rpcinfo -p" would be interesting to know
|  >
|  > simonpj@cam-05-unx:~/tmp$ rpcinfo -p
|  > Command 'rpcinfo' is available in '/usr/sbin/rpcinfo'
|  > The command could not be located because '/usr/sbin' is not included in
|  the PATH environment variable.
|  > This is most likely caused by the lack of administrative privileges
|  associated with your user account.
|  > rpcinfo: command not found
|  >
|  Silly me; are you able to run `sudo rpcinfo -p`?
|  
|  Cheers,
|  
|  - Ben

___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Alex install failure

2017-08-28 Thread Ben Gamari
Simon Peyton Jones via ghc-devs  writes:

> |  note that you mistyped "lockd" (aka "lock daemon") as "locd"
>
> Oh, sorry about mistyping
>
> simonpj@cam-05-unx:~/tmp$ ps -Af | grep lockd
> root   140 2  0  2016 ?00:00:00 [kblockd]
> simonpj   7882  1184  0 13:22 pts/700:00:00 grep lockd
>
Interesting; no lock daemon.

> |  also, the output of "rpcinfo -p" would be interesting to know
>
> simonpj@cam-05-unx:~/tmp$ rpcinfo -p
> Command 'rpcinfo' is available in '/usr/sbin/rpcinfo'
> The command could not be located because '/usr/sbin' is not included in the 
> PATH environment variable.
> This is most likely caused by the lack of administrative privileges 
> associated with your user account.
> rpcinfo: command not found
>
Silly me; are you able to run `sudo rpcinfo -p`?

Cheers,

- Ben



signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


RE: Alex install failure

2017-08-28 Thread Simon Peyton Jones via ghc-devs
|  note that you mistyped "lockd" (aka "lock daemon") as "locd"

Oh, sorry about mistyping

simonpj@cam-05-unx:~/tmp$ ps -Af | grep lockd
root   140 2  0  2016 ?00:00:00 [kblockd]
simonpj   7882  1184  0 13:22 pts/700:00:00 grep lockd

|  also, the output of "rpcinfo -p" would be interesting to know

simonpj@cam-05-unx:~/tmp$ rpcinfo -p
Command 'rpcinfo' is available in '/usr/sbin/rpcinfo'
The command could not be located because '/usr/sbin' is not included in the 
PATH environment variable.
This is most likely caused by the lack of administrative privileges associated 
with your user account.
rpcinfo: command not found


|  -Original Message-
|  From: Herbert Valerio Riedel [mailto:hvrie...@gmail.com]
|  Sent: 28 August 2017 12:51
|  To: Simon Peyton Jones 
|  Subject: Re: Alex install failure
|  
|  Simon,
|  
|  note that you mistyped "lockd" (aka "lock daemon") as "locd"
|  
|  also, the output of "rpcinfo -p" would be interesting to know
|  
|  On Mon, Aug 28, 2017 at 1:47 PM, Simon Peyton Jones via ghc-devs  wrote:
|  > |  Hmm, alright then. What do the following say,
|  > |
|  > |   * ps -Af | grep lockd
|  > |   * ps -Af | grep portmap
|  > |   * ps -Af | grep rpcbind
|  > |   * mount | grep nfs
|  > |
|  >
|  > simonpj@cam-05-unx:~/tmp$ ps -Af | grep locd
|  > simonpj  20138  1184  0 12:46 pts/700:00:00 grep locd
|  >
|  > simonpj@cam-05-unx:~/tmp$ ps -Af | grep portmap
|  > simonpj  22601  1184  0 12:46 pts/700:00:00 grep portmap
|  >
|  > simonpj@cam-05-unx:~/tmp$ ps -Af | grep rpcbind
|  > root  1472 1  0  2016 ?00:00:13 rpcbind -w
|  > simonpj  26634  1184  0 12:46 pts/700:00:00 grep rpcbind
|  >
|  > simonpj@cam-05-unx:~/tmp$ mount | grep nfs camresunxa02:/home on /home
|  > type nfs (rw,intr,vers=4,addr=10.190.50.19,clientaddr=10.190.108.81)
|  >
|  > |  -Original Message-
|  > |  From: Ben Gamari [mailto:b...@well-typed.com]
|  > |  Sent: 25 August 2017 17:46
|  > |  To: Simon Peyton Jones 
|  > |  Cc: ghc-devs 
|  > |  Subject: RE: Alex install failure
|  > |
|  > |  Simon Peyton Jones via ghc-devs  writes:
|  > |
|  > |  > |  I have implemented this in wip/ghc-pkg-locking. Do you think
|  > | you  > | could give  this branch a try? If it still fails then we'll
|  > | have to  > | try to debug things  in-situ.
|  > |  >
|  > |  > Alas, no go.
|  > |  >
|  > |  Hmm, alright then. What do the following say,
|  > |
|  > |   * ps -Af | grep lockd
|  > |   * ps -Af | grep portmap
|  > |   * ps -Af | grep rpcbind
|  > |   * mount | grep nfs
|  > |
|  > |  Cheers,
|  > |
|  > |  - Ben
|  >
|  > ___
|  > ghc-devs mailing list
|  > ghc-devs@haskell.org
|  > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h
|  > askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs=02%7C01%7Csi
|  > monpj%40microsoft.com%7C33b163bdb97f4f59d80f08d4ee0b07ea%7C72f988bf86f
|  > 141af91ab2d7cd011db47%7C1%7C0%7C636395178517098924=EOVdQbvvTDGP9
|  > 2o8AHcVEcapHMicnVptxMCpwRPrsvE%3D=0
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs