Re: Commit comments - call for opinions
I personally prefer seeing the whole commit message, if only because including it is more prominent than just a mention. Commits are really important, and should be made to stand out beyond just a mention. Not sure if this is worth yet more custom tooling, though. Richard > On Feb 8, 2019, at 7:04 PM, Ben Gamari wrote: > > Matthew Pickering writes: > >> I am in favor of option b) as it fits in better with the "gitlab way >> of things". If we are to use gitlab then we should use it as it's most >> intended rather than trying to retrofit trac practices which have >> accrued over many years. >> >> Adding commits as comments is just a hack in trac to work around >> missing native support for the fundamental operation of linking a >> commit to. >> > Well, I'm not sure that's *entirely* true. > >> I don't really see that it is much more inconvenient to click on a >> link to see the commit, the hash can be hovered over to see the commit >> title. >> > I can see Simon's point here; Trac tickets generally tell a story, > consisting of both comments as well as commit messages. It's not clear > to me why the content of the former should be more visible than that of > the latter. They both tell equally-important parts of the story. > > Cheers, > > - Ben > > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: How do I find out which info table a continuation belongs to?
I'm already using -g3. Here's my build.mk: BuildFlavour = quick ifneq "$(BuildFlavour)" "" include mk/flavours/$(BuildFlavour).mk endif GhcRtsHcOpts += -O0 -g3 SRC_HC_OPTS += -g3 GhcStage1HcOpts += -g3 GhcStage2HcOpts += -g3 GhcLibHcOpts += -g3 STRIP_CMD = : Ömer Simon Marlow , 10 Şub 2019 Paz, 19:00 tarihinde şunu yazdı: > > I believe this is due to https://phabricator.haskell.org/D4722 > > (cc Sergei Azovskov) > > I'm a bit surprised that gdb isn't showing anything though, it should know > that the address corresponds to a temporary symbol like `.L1234`. Perhaps you > need to compile with -g to make this work, I'm not sure. > > On Sun, 10 Feb 2019 at 07:50, Ömer Sinan Ağacan wrote: >> >> I'm currently working on a bug and one of the things I often want to know is >> what's on the stack. The problem is I can't see labels of continuations so >> the >> information is really useless. Example: >> >> >>> call printStack(((StgTSO*)0x42000e0198)->stackobj) >> 0x42000c8788: RET_SMALL (0x512d70) >> 0x42000c8790: RET_SMALL (0x40edf0) >>stk[5] (0x42000c8798) = 0x7b3938 >> 0x42000c87a0: CATCH_FRAME(0x735a98,0x7d3ff2) >> 0x42000c87b8: STOP_FRAME(0x7311b8) >> >> (I modified the printer to print stack locations when printing stacks) >> >> Here I need to know which info table the RET_SMALLs return to. Normally I do >> this for other kinds of closures: >> >> >>> print ((StgClosure*)...)->header.info >> $15 = (const StgInfoTable *) 0x404dc0 >> >> But for continuations that doesn't work: >> >> >>> print ((StgClosure*)0x42000c8788)->header.info >> $11 = (const StgInfoTable *) 0x512d80 >> >>> info symbol 0x512d80 >> No symbol matches 0x512d80. >> >> Anyone know how to make this work? Can I maybe mark the continuations label >> in >> the generated assembly somehow to make those labels available in gdb? >> >> Thanks >> >> Ömer >> ___ >> ghc-devs mailing list >> ghc-devs@haskell.org >> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: How do I find out which info table a continuation belongs to?
I believe this is due to https://phabricator.haskell.org/D4722 (cc Sergei Azovskov) I'm a bit surprised that gdb isn't showing anything though, it should know that the address corresponds to a temporary symbol like `.L1234`. Perhaps you need to compile with -g to make this work, I'm not sure. On Sun, 10 Feb 2019 at 07:50, Ömer Sinan Ağacan wrote: > I'm currently working on a bug and one of the things I often want to know > is > what's on the stack. The problem is I can't see labels of continuations so > the > information is really useless. Example: > > >>> call printStack(((StgTSO*)0x42000e0198)->stackobj) > 0x42000c8788: RET_SMALL (0x512d70) > 0x42000c8790: RET_SMALL (0x40edf0) >stk[5] (0x42000c8798) = 0x7b3938 > 0x42000c87a0: CATCH_FRAME(0x735a98,0x7d3ff2) > 0x42000c87b8: STOP_FRAME(0x7311b8) > > (I modified the printer to print stack locations when printing stacks) > > Here I need to know which info table the RET_SMALLs return to. Normally I > do > this for other kinds of closures: > > >>> print ((StgClosure*)...)->header.info > $15 = (const StgInfoTable *) 0x404dc0 > > But for continuations that doesn't work: > > >>> print ((StgClosure*)0x42000c8788)->header.info > $11 = (const StgInfoTable *) 0x512d80 > >>> info symbol 0x512d80 > No symbol matches 0x512d80. > > Anyone know how to make this work? Can I maybe mark the continuations > label in > the generated assembly somehow to make those labels available in gdb? > > Thanks > > Ömer > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
