Re: "Merge-buddy" request

2023-10-27 Thread Alexandre Rodrigues Baldé
Zubin has already kindly volunteered; if a second review is needed, I also don't mind taking a look - though I might need some context. I'm @rockbmb From: ghc-devs on behalf of Alan & Kim Zimmerman Sent: 27 October 2023 16:03 To: Zubin Duggal Cc: ghc-devs

Re: PMC: addConCt and newtypes bottom info

2023-10-27 Thread Sebastian Graf
Hi Rodrigo, Happy to see that you resumed your work on the pattern-match checker. I think you are right; we could reasonably just go with your code, not least because it is less confusing to retain as much info about `x` as possible. I don't think it makes a difference, because whenever we add

PMC: addConCt and newtypes bottom info

2023-10-27 Thread Rodrigo Mesquita
Dear Sebastian and GHC devs, Regarding this bit from the function addConCt in the GHC.HsToCore.Pmc.Solver module, Nothing -> do let pos' = PACA alt tvs args : pos let nabla_with bot' = nabla{ nabla_tm_st = ts{ts_facts = addToUSDFM env x (vi{vi_pos = pos', vi_bot =

Re: "Merge-buddy" request

2023-10-27 Thread Alan & Kim Zimmerman
Thanks Zubin. And to re-iterate on what Simon said, I will cheerfully have a discussion with anyone who needs context for these. Alan On Fri, 27 Oct 2023, 12:24 Zubin Duggal, wrote: > Feel free to assign me for reviews. > > On 23/10/26 17:10, Alan & Kim Zimmerman wrote: > >Hi all > > > >I

Re: "Merge-buddy" request

2023-10-27 Thread Zubin Duggal
Feel free to assign me for reviews. On 23/10/26 17:10, Alan & Kim Zimmerman wrote: Hi all I have been landing a series of MRs to simplify the exact print annotations. They are split into pieces so each change is not too big. I still have quite a number of them to land, but am finding the

Re: "Merge-buddy" request

2023-10-27 Thread Simon Peyton Jones
I hope someone responds to Alan's call. Simplifying exact-print annotations is a noble goal, and Alan has been working hard on it. I hope someone feels able to support him. I don't think you need to be an exact-print expert. I'm sure Alan would be happy to teach you. And that learning journey