Re: -fghci-leak-check apparently causes many tests to fail
> If you're seeing errors from this, then we should fix them. Could you open a ticket and assign to me please? I've opened Trac #15246 [1] for this. Ryan S. - [1] https://ghc.haskell.org/trac/ghc/ticket/15246 On Thu, Jun 7, 2018 at 4:34 PM, Simon Marlow wrote: > Sorry, only just saw this. -fghci-leak-check is a new flag I added to > prevent regressions of the space leak that was fixed in > https://phabricator.haskell.org/D4659 > > If you're seeing errors from this, then we should fix them. Could you > open a ticket and assign to me please? > > Cheers > Simon > > On 1 June 2018 at 11:57, Ryan Scott wrote: > >> One thing I forgot to mention is that these test failures only seem to >> occur with the `quick` build flavor, and I couldn't reproduce them with >> ./validate. Is -fghci-leak-check expected to have different behavior if >> stage-2 GHC is built without optimization? >> >> Ryan S. >> >> ___ >> ghc-devs mailing list >> ghc-devs@haskell.org >> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs >> >> > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: -fghci-leak-check apparently causes many tests to fail
Sorry, only just saw this. -fghci-leak-check is a new flag I added to prevent regressions of the space leak that was fixed in https://phabricator.haskell.org/D4659 If you're seeing errors from this, then we should fix them. Could you open a ticket and assign to me please? Cheers Simon On 1 June 2018 at 11:57, Ryan Scott wrote: > One thing I forgot to mention is that these test failures only seem to > occur with the `quick` build flavor, and I couldn't reproduce them with > ./validate. Is -fghci-leak-check expected to have different behavior if > stage-2 GHC is built without optimization? > > Ryan S. > > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: -fghci-leak-check apparently causes many tests to fail
One thing I forgot to mention is that these test failures only seem to occur with the `quick` build flavor, and I couldn't reproduce them with ./validate. Is -fghci-leak-check expected to have different behavior if stage-2 GHC is built without optimization? Ryan S. ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Re: -fghci-leak-check apparently causes many tests to fail
I don't know what -fghci-leak-check does at all, but if they are to be expected we shouldn't accept the changes. Instead change the default options in the testsuite to pass -fno-ghci-leak-check (I assume that exists) On Thu, May 31, 2018, 06:49 Ryan Scott wrote: > I recently ran the testsuite and experienced a very large number of > testsuite failures, all of which seem to involve the new -fghci-leak-check > flag. Here is the list of tests that fail: > > Unexpected failures: >ghci/prog001/prog001.runprog001 [bad stdout] (ghci) >ghci/prog002/prog002.runprog002 [bad stdout] (ghci) >ghci/prog003/prog003.runprog003 [bad stdout] (ghci) >ghci/prog010/ghci.prog010.run ghci.prog010 [bad stdout] (ghci) >ghci/prog013/prog013.runprog013 [bad stdout] (ghci) >ghci/prog012/prog012.runprog012 [bad stdout] (ghci) >ghci/prog009/ghci.prog009.run ghci.prog009 [bad stdout] (ghci) >ghci/scripts/ghci025.runghci025 [bad stdout] (ghci) >ghci/scripts/ghci038.runghci038 [bad stdout] (ghci) >ghci/scripts/ghci057.runghci057 [bad stdout] (ghci) >ghci/scripts/T2182ghci.run T2182ghci [bad stdout] (ghci) >ghci/scripts/ghci058.runghci058 [bad stdout] (ghci) >ghci/scripts/T6106.run T6106 [bad stdout] (ghci) >ghci/scripts/T8353.run T8353 [bad stdout] (ghci) >ghci/scripts/T9293.run T9293 [bad stdout] (ghci) >ghci/scripts/T10989.run T10989 [bad stdout] (ghci) >ghci/should_run/T13825-ghci.run T13825-ghci [bad stdout] (ghci) >ghci.debugger/scripts/print007.run print007 [bad stdout] (ghci) >ghci.debugger/scripts/break009.run break009 [bad stdout] (ghci) >ghci.debugger/scripts/break008.run break008 [bad stdout] (ghci) >ghci.debugger/scripts/break026.run break026 [bad stdout] (ghci) >perf/space_leaks/T4029.run T4029 [bad stdout] (ghci) > > And the full failing test output can be found here [1]. (I won't post it > inline, since it's quite large). > > Are these changes expected? I'm not at all familiar with > -fghci-leak-check, so I don't know if we should accept the new output or > not. > > Ryan S. > - > [1] > https://gist.githubusercontent.com/RyanGlScott/f920737287049b82947e1c47cdbc2b94/raw/4fe68d47cc78675424e09cf451be556c6f430d08/gistfile1.txt > ___ > ghc-devs mailing list > ghc-devs@haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs > ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
-fghci-leak-check apparently causes many tests to fail
I recently ran the testsuite and experienced a very large number of testsuite failures, all of which seem to involve the new -fghci-leak-check flag. Here is the list of tests that fail: Unexpected failures: ghci/prog001/prog001.runprog001 [bad stdout] (ghci) ghci/prog002/prog002.runprog002 [bad stdout] (ghci) ghci/prog003/prog003.runprog003 [bad stdout] (ghci) ghci/prog010/ghci.prog010.run ghci.prog010 [bad stdout] (ghci) ghci/prog013/prog013.runprog013 [bad stdout] (ghci) ghci/prog012/prog012.runprog012 [bad stdout] (ghci) ghci/prog009/ghci.prog009.run ghci.prog009 [bad stdout] (ghci) ghci/scripts/ghci025.runghci025 [bad stdout] (ghci) ghci/scripts/ghci038.runghci038 [bad stdout] (ghci) ghci/scripts/ghci057.runghci057 [bad stdout] (ghci) ghci/scripts/T2182ghci.run T2182ghci [bad stdout] (ghci) ghci/scripts/ghci058.runghci058 [bad stdout] (ghci) ghci/scripts/T6106.run T6106 [bad stdout] (ghci) ghci/scripts/T8353.run T8353 [bad stdout] (ghci) ghci/scripts/T9293.run T9293 [bad stdout] (ghci) ghci/scripts/T10989.run T10989 [bad stdout] (ghci) ghci/should_run/T13825-ghci.run T13825-ghci [bad stdout] (ghci) ghci.debugger/scripts/print007.run print007 [bad stdout] (ghci) ghci.debugger/scripts/break009.run break009 [bad stdout] (ghci) ghci.debugger/scripts/break008.run break008 [bad stdout] (ghci) ghci.debugger/scripts/break026.run break026 [bad stdout] (ghci) perf/space_leaks/T4029.run T4029 [bad stdout] (ghci) And the full failing test output can be found here [1]. (I won't post it inline, since it's quite large). Are these changes expected? I'm not at all familiar with -fghci-leak-check, so I don't know if we should accept the new output or not. Ryan S. - [1] https://gist.githubusercontent.com/RyanGlScott/f920737287049b82947e1c47cdbc2b94/raw/4fe68d47cc78675424e09cf451be556c6f430d08/gistfile1.txt ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
