Re: Deprecating functions

2015-01-09 Thread John Lato
I agree with Johan. I do think it makes sense to remove deprecated/replaced functions, but only after N+2 cycles. On 06:18, Fri, Jan 9, 2015 Richard Eisenberg e...@cis.upenn.edu wrote: On Jan 9, 2015, at 5:37 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: Especially that we're talking

Re: Deprecating functions

2015-01-09 Thread Johan Tibell
We could file a tracking bug against the 7.14 milestone. Just curious, is there a way to keep these functions for backwards compat in 7.14 or is that unfeasible? On Fri, Jan 9, 2015 at 10:22 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: I want to deprecate some Template Haskell functions in

Re: Deprecating functions

2015-01-09 Thread Jan Stolarek
I agree. You'll get rid of the redundancy in the library by removing it but you're users will have to live with (...) That's why I want to deprecate them first and give users one release cycle to switch to new functions. I assumed that's enough but we could make this two or three release

Re: Deprecating functions

2015-01-09 Thread Herbert Valerio Riedel
On 2015-01-09 at 11:09:07 +0100, Roman Cheplyaka wrote: [...] Just curious, is there a way to keep these functions for backwards compat in 7.14 or is that unfeasible? They could stay, technically that's not a problem. But I'm adding new functions that can do the same thing (and more), so we

Re: Deprecating functions

2015-01-09 Thread Johan Tibell
On Fri, Jan 9, 2015 at 11:09 AM, Roman Cheplyaka r...@ro-che.info wrote: On 09/01/15 12:02, Jan Stolarek wrote: We could file a tracking bug against the 7.14 milestone. I was considering that but we don't have 7.14 milestone yet. Just curious, is there a way to keep these functions for

Re: Deprecating functions

2015-01-09 Thread Johan Tibell
On Fri, Jan 9, 2015 at 11:13 AM, Herbert Valerio Riedel hvrie...@gmail.com wrote: Why hide them? DEPRECATEd entities have the deprecation-message shown in discouraging red letters (including any hyperlinks to their replacements) in the generated Haddock documentation... I think Java's (!)

Re: Deprecating functions

2015-01-09 Thread Herbert Valerio Riedel
On 2015-01-09 at 11:18:02 +0100, Jan Stolarek wrote: The reall question is how to remember that we should remove this at some point? This affects all exposed libraries; I think it's enough to simply make this part of the release-procedure at some point in the release-cycle, to actively scan

Deprecating functions

2015-01-09 Thread Jan Stolarek
I want to deprecate some Template Haskell functions in GHC 7.12 and then remove them in GHC 7.14 (or whatever version that comes after 7.12). Do we have any workflow for remembering these kind of things? I was thinking about adding a conditional error: #if __GLASGOW_HASKELL__ 712 #error

Re: Deprecating functions

2015-01-09 Thread Jan Stolarek
We could file a tracking bug against the 7.14 milestone. I was considering that but we don't have 7.14 milestone yet. Just curious, is there a way to keep these functions for backwards compat in 7.14 or is that unfeasible? They could stay, technically that's not a problem. But I'm adding new

Re: Deprecating functions

2015-01-09 Thread Bardur Arantsson
On 2015-01-09 11:25, Herbert Valerio Riedel wrote: On 2015-01-09 at 11:18:02 +0100, Jan Stolarek wrote: The reall question is how to remember that we should remove this at some point? This affects all exposed libraries; I think it's enough to simply make this part of the

Re: Deprecating functions

2015-01-09 Thread Roman Cheplyaka
On 09/01/15 12:02, Jan Stolarek wrote: We could file a tracking bug against the 7.14 milestone. I was considering that but we don't have 7.14 milestone yet. Just curious, is there a way to keep these functions for backwards compat in 7.14 or is that unfeasible? They could stay, technically

Re: Deprecating functions

2015-01-09 Thread Richard Eisenberg
On Jan 9, 2015, at 5:37 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: Especially that we're talking about internal TH module - I'll be surprised if there are more than 10 users. As I understand it, TH.Lib is not an internal module. Though I, personally, have never found the functions there

Re: Deprecating functions

2015-01-09 Thread Johan Tibell
On Fri, Jan 9, 2015 at 11:18 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: I agree. You'll get rid of the redundancy in the library by removing it but you're users will have to live with (...) That's why I want to deprecate them first and give users one release cycle to switch to new

Re: Deprecating functions

2015-01-09 Thread Jan Stolarek
I think Java's (!) policy for deprecation is good I think it's not. It keeps the library code a mess and many times I have seen users using functions that have been deprecated for years just because it's easier to suppress a warning than change the code. I don't want Haskell to go down that

Re: Deprecating functions

2015-01-09 Thread Johan Tibell
On Fri, Jan 9, 2015 at 11:37 AM, Jan Stolarek jan.stola...@p.lodz.pl wrote: I think Java's (!) policy for deprecation is good I think it's not. It keeps the library code a mess and many times I have seen users using functions that have been deprecated for years just because it's easier to