Thanks Ben. I've copied that verbatim to
https://gitlab.haskell.org/ghc/ghc/-/wikis/contributing#working-conventions
:)
On Fri, 29 Sept 2023 at 18:23, Ben Gamari wrote:
> Bryan Richter via ghc-devs writes:
>
> > I am not sure of the best ways for checking if a certain issue has been
> > fixed
Bryan Richter via ghc-devs writes:
> I am not sure of the best ways for checking if a certain issue has been
> fixed on a certain release. My past ways of using git run into certain
> problems:
>
> The commit (or commits!) that fix an issue get rewritten once by Marge as
> they are rebased onto
I usually end up looking at the source I’m actually compiling and checking
if the expected changes are in the source or not. If not, I end up
backporting stuff to the source at hand. As this is often for compilers
that are way past their end of life cycle (e.g. 8.10), there seems little
point in
Personally I try to include fixes #1234 in the commit so then I can just
check which tags contain a commit mentioning the issue.
If the issue isn't mentioned in the commit I usually look at the issue
-> look for related mrs -> look for the commit with the fix -> grep for
the commit message of
Yah, I get very confused with how ghc manages commits. I've ended up
searching for the patches at times. I'd love a sensible approach.
On Thu, Sep 28, 2023, 17:55 Justin Bailey wrote:
> I would also love to know how to do this. I don't often contribute to GHC,
> but I follow bug fixes closely.
I know if I backport anything I use 'git cherry-pick -x' which puts a
reference to the original commit in the message.
I am not sure how general that is though
Alan
On Thu, 28 Sept 2023 at 21:55, Justin Bailey wrote:
> I would also love to know how to do this. I don't often contribute to GHC,
I would also love to know how to do this. I don't often contribute to GHC,
but I follow bug fixes closely. In fact, the one time I did contribute (
https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10245), it turned out i
was duplicating work already done elsewhere! If I had known how to
I am not sure of the best ways for checking if a certain issue has been
fixed on a certain release. My past ways of using git run into certain
problems:
The commit (or commits!) that fix an issue get rewritten once by Marge as
they are rebased onto master, and then potentially a second time as
