Re: Phab: conditional approval

2017-09-14 Thread Alan & Kim Zimmerman
William Casarin recently tweeted a link to the bitcoincore devs ACK system[1], which are Concept ACK - Agree with the idea and overall direction, but haven't reviewed the code changes or tested them. utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested

Re: Phab: conditional approval

2017-09-14 Thread Richard Eisenberg
Yes, this works for me. As for merging, I'm always very grateful when Ben does it -- though I agree that it would make more sense for me to do it when I can test-then-merge. Thanks, Richard > On Sep 13, 2017, at 10:29 AM, Ben Gamari wrote: > > Simon Marlow

Re: Phab: conditional approval

2017-09-13 Thread Ben Gamari
Simon Marlow writes: > On 19 August 2017 at 03:56, Richard Eisenberg wrote: > >> Hi devs, >> >> When reviewing a diff on Phab, I can "accept" or "request changes". >> Sometimes, though, I want to do both: I suggest very minor (e.g., typo) >> changes,

Re: Phab: conditional approval

2017-09-12 Thread Simon Marlow
On 19 August 2017 at 03:56, Richard Eisenberg wrote: > Hi devs, > > When reviewing a diff on Phab, I can "accept" or "request changes". > Sometimes, though, I want to do both: I suggest very minor (e.g., typo) > changes, but then when these changes are made, I accept. I'm

Re: Phab: conditional approval

2017-08-22 Thread Ben Gamari
Richard Eisenberg writes: > Hi devs, > > When reviewing a diff on Phab, I can "accept" or "request changes". > Sometimes, though, I want to do both: I suggest very minor (e.g., > typo) changes, but then when these changes are made, I accept. I'm > leery of making the

Phab: conditional approval

2017-08-18 Thread Richard Eisenberg
Hi devs, When reviewing a diff on Phab, I can "accept" or "request changes". Sometimes, though, I want to do both: I suggest very minor (e.g., typo) changes, but then when these changes are made, I accept. I'm leery of making the suggestions and saying "accept", because then someone working