William Casarin recently tweeted a link to the bitcoincore devs ACK
system[1], which are
Concept ACK - Agree with the idea and overall direction, but haven't
reviewed the code changes or tested them.
utACK (untested ACK) - Reviewed and agree with the code changes but
haven't actually tested
Yes, this works for me.
As for merging, I'm always very grateful when Ben does it -- though I agree
that it would make more sense for me to do it when I can test-then-merge.
Thanks,
Richard
> On Sep 13, 2017, at 10:29 AM, Ben Gamari wrote:
>
> Simon Marlow
Simon Marlow writes:
> On 19 August 2017 at 03:56, Richard Eisenberg wrote:
>
>> Hi devs,
>>
>> When reviewing a diff on Phab, I can "accept" or "request changes".
>> Sometimes, though, I want to do both: I suggest very minor (e.g., typo)
>> changes,
On 19 August 2017 at 03:56, Richard Eisenberg wrote:
> Hi devs,
>
> When reviewing a diff on Phab, I can "accept" or "request changes".
> Sometimes, though, I want to do both: I suggest very minor (e.g., typo)
> changes, but then when these changes are made, I accept. I'm
Richard Eisenberg writes:
> Hi devs,
>
> When reviewing a diff on Phab, I can "accept" or "request changes".
> Sometimes, though, I want to do both: I suggest very minor (e.g.,
> typo) changes, but then when these changes are made, I accept. I'm
> leery of making the
Hi devs,
When reviewing a diff on Phab, I can "accept" or "request changes". Sometimes,
though, I want to do both: I suggest very minor (e.g., typo) changes, but then
when these changes are made, I accept. I'm leery of making the suggestions and
saying "accept", because then someone working