Oh ok. The fix sounded like it was about core. My mistake on reading your
explanation earlier ! Thanks for clarifying!
On Wed, Aug 1, 2018 at 11:45 PM Abhiroop Sarkar
wrote:
> Oh no! it was a Cmm lint error. The register width don't come into the
> picture before Cmm. The register width in
Oh no! it was a Cmm lint error. The register width don't come into the
picture before Cmm. The register width in the Cmm is decided based on
`primRepCmmType` function(which I mentioned in the previous mail) which in
turn uses `Type` and some other info, this is where the error was hiding.
It was
So the issue was core lint type error rather than a cmm lint error? Glad
you figured it out !
But you didn’t communicate what the error you got from lint was core rather
than cmm ... :(
On Wed, Aug 1, 2018 at 11:25 PM Abhiroop Sarkar
wrote:
> Never mind I found the issue and fixed it.
>
> It
Never mind I found the issue and fixed it.
It was the definition of the `Int32` type constructor:
int32PrimTyCon = pcPrimTyCon0 int32PrimTyConName IntRep
which had to be fixed to
int32PrimTyCon = pcPrimTyCon0 int32PrimTyConName Int32Rep
Thanks anyways :)
Abhiroop
On Wed, Aug 1, 2018 at
Hello,
I would appreciate some help in debugging a Cmm Lint error, I have been
stuck on for quite a while.
Basically I am adding support for Int32# on top of the In8#(D4475) and
Int16#(D5006) patches.
The Cmm being generated for the test programs are incorrect.
Taking a sample test like this (
I've rebased the diff and relaxed the assertion - do take a look if that
looks reasonable to you :)
https://phabricator.haskell.org/D4475
Cheers!
- Michal
On Wed, Jul 25, 2018 at 9:03 PM Michal Terepeta
wrote:
> Hi Carter,
>
> I didn't write this assertion. I only validated locally (IIRC at
Hi Carter,
I didn't write this assertion. I only validated locally (IIRC at the time I
uploaded the diff, harbormaster was failing for some other reasons).
I'll try to have a look at it this weekend.
Cheers!
- Michal
On Wed, Jul 25, 2018 at 2:16 AM Carter Schonwald
wrote:
> Michal: did you
Michal: did you write this Assert about width? and if so could you explain
it so we can understand?
hrmm... that code is in the procedure for generating C calls for 64bit
intel systems
https://github.com/michalt/ghc/blob/int8/compiler/nativeGen/X86/CodeGen.hs#L2541
is the top of that routine
