RE: Test T12504 on Windows

2016-09-20 Thread Richard Cook 
Thanks! Yes, I did mean to reply all.
-Richard


Sent via the Samsung Galaxy S7 edge, an AT 4G LTE smartphone
 Original message From: loneti...@gmail.com Date: 9/20/16  6:03 
PM  (GMT-08:00) To: Richard Cook <rc...@rcook.org>, Simon Peyton Jones 
<simo...@microsoft.com>, ghc-devs@haskell.org Subject: RE: Test T12504 on 
Windows 
I believe you forgot to press Reply-All Richard. In any case a fix is up at 
https://phabricator.haskell.org/D2537 Sorry, should have caught this during 
review. Tamar From: Richard Cook
Sent: Tuesday, September 20, 2016 23:35
To: Phyx
Subject: Re: Test T12504 on Windows Dear All, This is the test case that was 
added to validate the fix to hsc2hs. Here's the commit that added the test 
case: 
https://git.haskell.org/ghc.git/commitdiff/76286af5c621f032c4afab1f26b992e8ffa7f84d
 Output on Windows should include backslashes, other platforms should use 
forward slashes. This is keyed off the WINDOWS Makefile variable. -Richard  On 
Tue, Sep 20, 2016 at 3:10 PM, Phyx <loneti...@gmail.com> wrote:The new output 
is correct. hsc2hs was patched to fix the error messages it gives. We missed a 
test it seems. I'll update the test output when I get home. Thanks Simon, 
Tamar  On Tue, Sep 20, 2016, 23:06 Simon Peyton Jones via ghc-devs 
<ghc-devs@haskell.org> wrote:Test hsc2hs/T12504 is failing thus on Windows. 
Something path-y.Simon -{-# LINE 1 "T12504/path/to/T12504.hsc" #-}-{-# LINE 2 
"T12504/path/to/T12504.hsc" #-}+{-# LINE 1 "T12504\\path\\to\\T12504.hsc" 
#-}+{-# LINE 2 "T12504\\path\\to\\T12504.hsc" #-}*** unexpected failure for 
T12504(normal)___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs  ___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

RE: Test T12504 on Windows

2016-09-20 Thread lonetiger 
I believe you forgot to press Reply-All Richard.

In any case a fix is up at https://phabricator.haskell.org/D2537

Sorry, should have caught this during review.

Tamar

From: Richard Cook___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Re: Test T12504 on Windows

2016-09-20 Thread Phyx 
The new output is correct.

hsc2hs was patched to fix the error messages it gives. We missed a test it
seems.

I'll update the test output when I get home.

Thanks Simon,
Tamar

On Tue, Sep 20, 2016, 23:06 Simon Peyton Jones via ghc-devs <
ghc-devs@haskell.org> wrote:

> Test hsc2hs/T12504 is failing thus on Windows. Something path-y.
>
> Simon
>
>
>
> -{-# LINE 1 "T12504/path/to/T12504.hsc" #-}
>
> -{-# LINE 2 "T12504/path/to/T12504.hsc" #-}
>
> +{-# LINE 1 "T12504\\path\\to\\T12504.hsc" #-}
>
> +{-# LINE 2 "T12504\\path\\to\\T12504.hsc" #-}
>
> *** unexpected failure for T12504(normal)
> ___
> ghc-devs mailing list
> ghc-devs@haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Test T12504 on Windows

2016-09-20 Thread Simon Peyton Jones via ghc-devs 
Test hsc2hs/T12504 is failing thus on Windows. Something path-y.
Simon



-{-# LINE 1 "T12504/path/to/T12504.hsc" #-}

-{-# LINE 2 "T12504/path/to/T12504.hsc" #-}

+{-# LINE 1 "T12504\\path\\to\\T12504.hsc" #-}

+{-# LINE 2 "T12504\\path\\to\\T12504.hsc" #-}

*** unexpected failure for T12504(normal)
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs