Re: [Gimp-developer] Save + export spec essentials implemented
On Thursday, May 7, 2009, 0:24:12, Martin Nordholts wrote: I have been working on implementing the Save + export spec [1] for a while. Since it will affect the workflow for basically everyone it would be nice with getting some testing and comments before we finalize I built a Windows installer with this yesterday, and the comments I got so far are: - i don't have to try a stupid idea to say that it's a stupid idea - That's bizarre... - eww so they going to do it after all? - why the hell did they do that -- Jernej Simončič http://eternallybored.org/ Nature will tell you a direct lie if she can. -- Darwin's Observation ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials implemented
Quoting Martin Nordholts ense...@gmail.com: I have been working on implementing the Save + export spec [1] for a while. : : Comments very much appreciated! I haven't GITified my development yet and thus have not tried your implementation. If your request for comments is only on the implementation and you are not expecting comments on the export spec itself, I apologize for the following question: Shouldn't the Save a copy... menu item be eliminated since its functionality can be entirely attained by exporting to the GIMP native format? ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials implemented
On Thu, May 7, 2009 at 7:54 AM, Martin Nordholts ense...@gmail.com wrote: Hi I have been working on implementing the Save + export spec [1] for a while. Since it will affect the workflow for basically everyone it would be nice with getting some testing and comments before we finalize, merge and push to GNOME master. The patches are attached to the bug report http://bugzilla.gnome.org/show_bug.cgi?id=581655 . Quick-guide to apply and test: cd ~/source/gimp tar -zxvf save-plus-export-2009-05-06.tar.gz git checkout -b save-plus-export-2009-05-06 master git am save-plus-export-2009-05-06/* this will create and switch to a new branch based on top of your local master branch, and apply the patches to that branch. Then you build and install as usual. This doesn't seem to work -- patch #0010 fails: Applying app: Add an 'export' mode to the file save dialog error: patch failed: app/dialogs/file-save-dialog.c:138 error: app/dialogs/file-save-dialog.c: patch does not apply Patch failed at 0010. The patch appears to be offset by about 10 lines. I applied it manually, and then ran git-am --skip Patch 0011 applied ok, Patch 0012 had problems: Applying app: Improve save and export error messages error: app/dialogs/file-save-dialog.c: does not match index Patch failed at 0012. Applied that manually, Patches 013..017 applied OK. 018 says : Applying app: Remember last export URI for each image error: app/dialogs/file-save-dialog.c: does not match index error: patch failed: app/file/gimp-file.h:27 error: app/file/gimp-file.h: patch does not apply Patch failed at 0018. Done manually, 019 fails similarly, done manually, same for 020, 021 022 applied ok. It's possible that I didn't understand how to 'resolve' a problem ( now I think it is, apply the patch manually, 'git add' the relevant files, and 'git am --resolved') I'm now trying to build it.. Trying it out.. This works REALLY well! I 3 it! It behaves much more comfortably than the old setup, I anticipate no longer needing to awkwardly 'save copy' so frequently simply to get a web-usable version of the image. I like how, if I hit 'revert', it properly reverts to the source image (eg 12.gif rather than the working document 12.xcf) I was confused by how 'export to foo.png' was only usable once the image became dirty (ie. I changed it ). If that is considered appropriate behaviour, then your ability to 'save' should also depend on the dirtiness of the image David ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials implemented
2009/5/7 David Gowers 00a...@gmail.com patch #0010 fails: Did you pull from GNOME master before you applied the patches? I should have said that the patches requires latest GNOME master. If you apply the patches on top of commit 9c2aae1281d.. you should be fine. This works REALLY well! I 3 it! It behaves much more comfortably than the old setup, I like that you like it :) I was confused by how 'export to foo.png' was only usable once the image became dirty (ie. I changed it ). If that is considered appropriate behaviour, then your ability to 'save' should also depend on the dirtiness of the image Hmm this seems to work properly for me, I can 'Export to' repeatedly also after having saved, it doesn't seem to depend on dirtiness. Maybe you resolved some patch conflict in the wrong way? Could you try to reapply on top of latest GNOME master? If you still have problems, what are the step-by-steps? / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials implemented
2009/5/7 saulgo...@flashingtwelve.brickfilms.com If your request for comments is only on the implementation and you are not expecting comments on the export spec itself, I apologize for the following question: Shouldn't the Save a copy... menu item be eliminated since its functionality can be entirely attained by exporting to the GIMP native format? I figured the best way to form an opinion on the spec is to try it out live but you are of course free to have an opinion on the spec also without having played around with an implementation of it. Allowing to export to the GIMP native format would introduce ambiguity: If I export to .xcf, will my document be considered saved? Will the document - URI association be updated? And so on. Keeping Save a copy allows us to avoid this ambiguity altogether. / Martin ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials implemented
On Thu, 2009-05-07 at 17:08 +0200, Jernej Simončič wrote: [...] Show me one person outside GIMP developer community that thinks this is a sane change. I don't think many people think it's a sane change, but that's not the right question. The question is, will the resulting interface be good? People (including me) were very doubtful about the empty image window, and whilst I'm not 100% happy, I'm 99% happy, and it worked out much better than I had feared. So I'm willing to see what happens here. If you want something different though, you'll need to do more than say the proposed change is insane. You'll need to supply a new proposal that fits in with the vision of GIMP as an xcf editor, or, persuade Peter and others to change the vision slightly. Best, Liam -- Liam Quin - XML Activity Lead, W3C, http://www.w3.org/People/Quin/ Pictures from old books: http://fromoldbooks.org/ Ankh: irc.sorcery.net irc.gnome.org www.advogato.org ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Save + export spec essentials
Show me one person outside GIMP developer community that thinks this is a sane change. Totally irrelevant comment, if you ask me; this is a patch on a development version. Not many users will have tried it. Sure, there's the windows installer, but it remains a development version and an early snapshot of an unfinished feature. I am not part of the GIMP developer community, yet I like every bit of the spec I read. -- Auria ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
