Re: [Gimp-developer] config - display dependency
On Tue, 2010-01-05 at 23:31 +0100, Martin Nordholts wrote: Hi again, Sven Neumann wrote: Since there is no GTK+ dependency in the two files, nor any dependency on code that has a GTK+ dependency, there is no dependency from core to the UI here. The files are just better located in app/display as that is where they are used. I don't understand why you insist on reasoning about files when the GIMP code is divided into modules. I agree that if considering only individual files, the core does not have a dependency to the UI code. If we limit our reasoning to modules however, do you then agree with the conclusion that the core has a dependency to UI code? When we split up the GIMP core into sub-directories, we also split the code into UI and core. You will find a few files in the UI sub-directories that hold nothing but config settings. Since the non-UI GIMP should be able to read the same config files that the UI-enabled GIMP uses, the non-UI code needs to be know about some config settings that are part of the UI. That's why gimp-console needs to link a few files from the non-UI parts of GIMP. Does that mean that these files should be moved to other folders? No, because they are in the right location, close to the code that actually uses them. Does that mean that there is a dependency that needs to be fixed? No, not unless you want to drop the possibility to share config files between the UI-enabled and the non-UI GIMP. Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] gtk-doc 1.13 problem with recent gimp git (+solution)
Recently I found that GIMP from git would not compile, as it couldn't get past the ./autogen.sh step.. It would produce quite a few errors, like this: gtk-doc.make:53: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL devel-docs/app/Makefile.am:116: `gtk-doc.make' included from here gtk-doc.make:58: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL devel-docs/app/Makefile.am:116: `gtk-doc.make' included from here gtk-doc.make:53: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL devel-docs/libgimp/Makefile.am:64: `gtk-doc.make' included from here gtk-doc.make:58: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL devel-docs/libgimp/Makefile.am:64: `gtk-doc.make' included from here gtk-doc.make:53: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL devel-docs/libgimpbase/Makefile.am:52: `gtk-doc.make' included from here gtk-doc.make:58: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL devel-docs/libgimpbase/Makefile.am:52: `gtk-doc.make' included from here gtk-doc.make:53: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL devel-docs/libgimpcolor/Makefile.am:46: `gtk-doc.make' included from here I noticed in my pacman logs, I had upgraded gtk-doc recently: [2009-12-21 10:55] upgraded gtk-doc (1.11-2 - 1.13-1) So I eventually decided these BUILD_PDF and BUILD_HTML flags were new in 1.13 (or 1.12 if it exists) and required in configure.ac, and I hacked around this, by adding AM_CONDITIONAL(GTK_DOC_BUILD_HTML, test x$jpeg_ok = xyes) AM_CONDITIONAL(GTK_DOC_BUILD_PDF, test x$jpeg_ok = xyes) after AM_CONDITIONAL(BUILD_JPEG, test x$jpeg_ok = xyes) AC_SUBST(JPEG_LIBS) to configure.ac Of course, that is somewhat nonsensical.. perhaps 'true = xyes' would work instead of 'test x$jpeg_ok = xyes'. The above fix allowed me to build GIMP successfully (actually is in progress now, so I'll check it actually finishes OK.. yep:) It does seem odd to me that I get the above errors even if building devel docs with gtk-doc is disabled... Is that a bug in configure.ac? ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
