Re: [Gimp-developer] YCbCr (de)compose support [PATCH]

2002-10-21 Thread Sven Neumann 
Hi,

Michael Niedermayer [EMAIL PROTECTED] writes:

 this patch adds 
 YCbCr ITU-R Rec. BT.470-2 (== BT.624-4 seems to be == BT.601) and
 YCbCr ITU-R Rec. BT.709
 compose  decompose support

basically looks like it's worth to be included. You should file a
bug-report at http://bugs.gimp.org/ and attach your patch there.
(You first need to submit the patch before you can add a patch to
it.)

 @@ -136,7 +140,27 @@
{ N_(CMYK), 4, { N_(Cyan:),
   N_(Magenta:),
   N_(Yellow:),
 - N_(Black:) }, N_(cmyk-compose), compose_cmyk }
 + N_(Black:) }, N_(cmyk-compose), compose_cmyk },
 +  { N_(YCbCr_ITU_R470), 
 +   3, { N_(Y:),
 +N_(Cb:),
 +N_(Cr:),
 +CHNL_NA }, N_(ycbcr470-compose),  compose_ycbcr470 },
 +  { N_(YCbCr_ITU_R709), 

does it really make sense to mark these strings for translation? I'd
prefer some more descriptive names but I guess it's not that easy
since these conversions are of a very technical nature. Perhaps
tooltips would help?


Salut, Sven
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer

Re: [Gimp-developer] YCbCr (de)compose support [PATCH]

2002-10-21 Thread Michael Niedermayer 
Hi

On Monday 21 October 2002 23:03, Sven Neumann wrote:
 Hi,

 Michael Niedermayer [EMAIL PROTECTED] writes:
  this patch adds
  YCbCr ITU-R Rec. BT.470-2 (== BT.624-4 seems to be == BT.601) and
  YCbCr ITU-R Rec. BT.709
  compose  decompose support

 basically looks like it's worth to be included. You should file a
 bug-report at http://bugs.gimp.org/ and attach your patch there.
 (You first need to submit the patch before you can add a patch to
 it.)
ok, done

[...]
  +   3, { N_(Y:),
  +N_(Cb:),
  +N_(Cr:),
  +CHNL_NA }, N_(ycbcr470-compose),  compose_ycbcr470
  }, +  { N_(YCbCr_ITU_R709),

 does it really make sense to mark these strings for translation? 
y/cb/cr certainly not (i didnt really think about it, its just edited 
copypaste from the other converters)

 I'd
 prefer some more descriptive names but I guess it's not that easy
 since these conversions are of a very technical nature. Perhaps
 tooltips would help?
i changed Y,Cb,Cr to brightness, blueness, redness in the patch on the 
bug-report, that should be more descriptive 
[...]

Michael
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer