Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-13 Thread Sven Neumann
Hi,

On Mon, 2007-02-12 at 20:09 +0100, Manfred Joerg wrote:

 So far so good. What do you think about my idea to add an option to the 
 threshold tool which allows the user to create an indexed black/white image 
 instead of a rgb image which only contains black and white pixels?

I don't like it because none of our tools change the image mode.

 The conversion to indexed takes a lot of time for big images..

It doesn't take very long if you turn off dithering. Anyway, if there's
a performance problem, then we (or you) should look into fixing it
instead of adding ways to work around it. Perhaps it would be a good
idea to gather some profiling data on the RGB-Indexed conversion code.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-13 Thread jernej
On Tuesday, February 13, 2007, 9:57:17, Sven Neumann wrote:

 It doesn't take very long if you turn off dithering. Anyway, if there's
 a performance problem, then we (or you) should look into fixing it
 instead of adding ways to work around it. Perhaps it would be a good
 idea to gather some profiling data on the RGB-Indexed conversion code.

Compared to GIMP 1.2.5, converting image to indexed palette is much slower
(for pictures that I often convert to indexed, GIMP 1.2.5 usually does the
conversion instantly, while GIMP 2.x takes several seconds [and fills the
progress bar 3 times while doing it]). I also prefer the result given by
GIMP 1.2.5.

-- 
 Jernej Simončič  http://deepthought.ena.si/ 

The shortest distance between two points is under construction.
   -- McGregor's Revised Maxim

___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-12 Thread Manfred Joerg
Hi Sven,

On Monday 12 February 2007 08:38, Sven Neumann wrote:
  1. It doesn't allow the user to save a rgb image as CCITT Datagroup 3/4
  even if it contains only black and white pixels. Instead the user has to
  convert the image to indexed mode black/white first.

 That is the intended behavior. The user should only be allowed to select
 the new compression schemes if the image is indexed with a b/w colormap.
 The radio buttons should be insensitive otherwise and an allowed
 compression scheme should be preselected.
 Sven

So far so good. What do you think about my idea to add an option to the 
threshold tool which allows the user to create an indexed black/white image 
instead of a rgb image which only contains black and white pixels?

The conversion to indexed takes a lot of time for big images..

Manfred
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-11 Thread Sven Neumann
Hi,

On Sun, 2007-02-11 at 19:44 +0100, Manfred Joerg wrote:

 I just checked your revised tiff patch. 
 
 1. It doesn't allow the user to save a rgb image as CCITT Datagroup 3/4 even 
 if it contains only black and white pixels. Instead the user has to convert 
 the image to indexed mode black/white first.

That is the intended behavior. The user should only be allowed to select
the new compression schemes if the image is indexed with a b/w colormap.
The radio buttons should be insensitive otherwise and an allowed
compression scheme should be preselected.

As long as images saved that way are also loaded in Indexed mode with a
b/w colormap, this should be fine.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-02-01 Thread Sven Neumann
Hi,

On Thu, 2007-01-25 at 16:16 +0100, Manfred Joerg wrote:

 I think that I fixed bug 162119. My patch allows the user to save TIFF images 
 with CCITT Group 4. The advantage of this file format is that a scanned text 
 page (600 dpi) takes only 100 KByte.
 
 The patch is based on version 2.3.14. I only added the option to the dialog 
 and an error message which informs the user that only black / white images 
 can be saved as CCITT Group 4. The tiff library already contains the 
 necessary code.
 
 I attached my patch to the bug report.

I've attached a revised patch some days ago. Did you (or anyone else)
get a chance to try it? I would like to commit this as soon as possible
but the patch needs some more testing before it can go in.


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


[Gimp-developer] Saving black/white TIFF with 'CCITT Group 4' encoding

2007-01-25 Thread Manfred Joerg
Hello,

I think that I fixed bug 162119. My patch allows the user to save TIFF images 
with CCITT Group 4. The advantage of this file format is that a scanned text 
page (600 dpi) takes only 100 KByte.

The patch is based on version 2.3.14. I only added the option to the dialog 
and an error message which informs the user that only black / white images 
can be saved as CCITT Group 4. The tiff library already contains the 
necessary code.

I attached my patch to the bug report.

Regards
Manfred
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer