[Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread Alexander Rabtchevich
In GIMP 2.3.18 crop tool isn't stopped at image borders as it was in 
2.3.14. It is a bug: if ratio is set it is violated by this. And even if 
no ratio is set crop should not affect pixels outside the image.


-- 
With respect
Alexander Rabtchevich
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread Thorsten Wilms
On Tue, Jun 19, 2007 at 01:38:06PM +0300, Alexander Rabtchevich wrote:
 In GIMP 2.3.18 crop tool isn't stopped at image borders as it was in 
 2.3.14. It is a bug: if ratio is set it is violated by this. And even if 
 no ratio is set crop should not affect pixels outside the image.

Do you mean the ratio is not correctly applied if the cropping rectangle 
leaves the image borders, and only then?

I disagree on the last sentence. While limiting crop to within the image 
borders is convenient in many cases, being able to freely change the 
canvas size for a layer or image is useful, too. I mean to recall it's 
in fact an option in the last stable release.


-- 
Thorsten Wilms

Thorwil's Design for Free Software:
http://thorwil.wordpress.com
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread Alexandre Prokoudine
On 6/19/07, Thorsten Wilms wrote:

 I disagree on the last sentence. While limiting crop to within the image
 borders is convenient in many cases, being able to freely change the
 canvas size for a layer or image is useful, too. I mean to recall it's
 in fact an option in the last stable release.

From what I remember current Crop Tool is not finished yet and doesn't
fully correspond to specification provided by Peter Sikking.

Alexandre
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread Alexander Rabtchevich
Thorsten Wilms wrote:
 On Tue, Jun 19, 2007 at 01:38:06PM +0300, Alexander Rabtchevich wrote:
 In GIMP 2.3.18 crop tool isn't stopped at image borders as it was in 
 2.3.14. It is a bug: if ratio is set it is violated by this. And even if 
 no ratio is set crop should not affect pixels outside the image.
 
 Do you mean the ratio is not correctly applied if the cropping rectangle 
 leaves the image borders, and only then?

There are different cases.

1. I use fixed ratio. If the crop window leaves image borders, the ratio 
is violated.
2. I use fixed crop window dimensions. When touching the edge of an 
image the mouse is still moving, the crop window isn't crossing the edge 
and the preset window size is violated.

 
 I disagree on the last sentence. While limiting crop to within the image 
 borders is convenient in many cases, being able to freely change the 
 canvas size for a layer or image is useful, too. I mean to recall it's 
 in fact an option in the last stable release.

I would prefer to have this feature switchable with a checkbox (and I'll 
set it not to cross edges at least most of the time). I'll ground it. 
When one is processing images for further printing, cropping is framing. 
And the result _should_ have defined ratio. If one is moving crop window 
within an image, looking if it has crossed the borders and violated the 
resulting ratio is a waste of time and work.

-- 
With respect
Alexander Rabtchevich
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread Alexander Rabtchevich
There is _cropping_ and _cropping_and_changing_canvas_size_. Pure 
cropping means the result is taken within an image, not outside it.

Alexander Rabtchevich wrote:
 
 I would prefer to have this feature switchable with a checkbox (and I'll 
 set it not to cross edges at least most of the time). I'll ground it. 
 When one is processing images for further printing, cropping is framing. 
 And the result _should_ have defined ratio. If one is moving crop window 
 within an image, looking if it has crossed the borders and violated the 
 resulting ratio is a waste of time and work.
 


-- 
With respect
Alexander Rabtchevich
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] crop isn't stopped at image borders

2007-06-19 Thread peter sikking
Alexander,

I have read your concerns and can tell you that at the end GIMP
will work as you like to.

 I would prefer to have this feature switchable with a checkbox

the development of the tools is not finished.

I have to move first here, updating the spec of this feature and
filling in some holes, thus giving developers an easier time and
encourage implementation.

 --ps

 principal user interaction architect
 man + machine interface works

 http://mmiworks.net/blog : on interaction architecture



___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer