[Gimp-developer] gimp-unstable-2.3.11
Hi,
I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=231161 ) in
package gimp-unstable-2.3.11. There are modified elements 2 and 3 of
'values' array on lines 223 - 226 of file
plug-ins/winicon/main.c
But this doesn't agree with definition of 'values' parameter of function
run(), line 154.
Is it OK to replace 2 by 4 in the definition of 'values' variable?
Thanks.
Petr
--- plug-ins/winicon/main.c
+++ plug-ins/winicon/main.c
@@ -151,7 +151,7 @@
gint *nreturn_vals,
GimpParam **return_vals)
{
- static GimpParam values[2];
+ static GimpParam values[4];
gint32 image_ID;
gint32 drawable_ID;
GimpRunModerun_mode;
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] gimp-unstable-2.3.11
On Thu, 08 Mar 2007 10:15:53 +0100, Petr Gajdos [EMAIL PROTECTED] wrote: Hi, I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=231161 ) in package gimp-unstable-2.3.11. [...] Is it OK to replace 2 by 4 in the definition of 'values' variable? Yes, of course this is OK. Thanks a lot for reporting this bug and for providing a patch. This is now fixed in SVN, revision 22070. I am surprised that such a bug was able to hide in our code for several months without being noticed. Boo! for the developer who introduced it in the code! :-) No, I will not give any names - the culprit has already been identified and he pleaded guilty. -Raphaël ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] gimp-unstable-2.3.11
:-) Raphaël Quinet píše v Čt 08. 03. 2007 v 11:16 +0100: On Thu, 08 Mar 2007 10:15:53 +0100, Petr Gajdos [EMAIL PROTECTED] wrote: Hi, I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=231161 ) in package gimp-unstable-2.3.11. [...] Is it OK to replace 2 by 4 in the definition of 'values' variable? Yes, of course this is OK. Thanks a lot for reporting this bug and for providing a patch. This is now fixed in SVN, revision 22070. I am surprised that such a bug was able to hide in our code for several months without being noticed. Boo! for the developer who introduced it in the code! :-) No, I will not give any names - the culprit has already been identified and he pleaded guilty. -Raphaël ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
