On Fri, 09 Mar 2007 08:36:46 +0100, Sven Neumann [EMAIL PROTECTED] wrote:
Hi,
On Fri, 2007-03-09 at 08:08 +0100, [EMAIL PROTECTED] wrote:
I did some revectoring and tidy up work on the convolution plugin last
year and got told off for not testing it and introducing bugs. It turned
out the
Concerning the plug-in example, if you want to see the proper way
to do it, you can look at the real blur plug-in, in plug-ins/common/blur.c.
However, as Sven suggests, that plug-in only does a 3x3 blur, and a
proper implementation for NxN, as in the example, would be pretty hard to
read -- too
My plugin is working fine, after I found my bug and the one in
the blur example. It's just annoying.
Then please explain the bug in the example code and send us a patch
(preferably against SVN) that we can apply so that others won't run
into the problem again.
Quoting Luis A. Florit [EMAIL PROTECTED]:
http://w3.impa.br/~luis/fotos/lixo/grid_blurred.jpg
You can see three problems:
1) The old 1-pixel-down shift.
2) The two dark bands (20 lines each) at top and bottom of the image.
3) Even much intriguing is the grey band right below the top one,
On Fri, 09 Mar 2007 05:31:26 +0100,
[EMAIL PROTECTED] wrote:
Quoting Luis A. Florit [EMAIL PROTECTED]:
http://w3.impa.br/~luis/fotos/lixo/grid_blurred.jpg
You can see three problems:
1) The old 1-pixel-down shift.
2) The two dark bands (20 lines each) at top and bottom of the image.
3)
On Thu, 08 Mar 2007 23:13:08 +0100, Luis A. Florit
[EMAIL PROTECTED] wrote:
My 'solution' (change 'x1, y1,' in line 241 by 'x1, y1+1,')
took care of the shift, but not of the banding.
The homogeneous grey band just moved to the bottom...
(you cannot imagine the mess this does in my code!)
Hi,
On Fri, 2007-03-09 at 08:08 +0100, [EMAIL PROTECTED] wrote:
I did some revectoring and tidy up work on the convolution plugin last
year and got told off for not testing it and introducing bugs. It turned
out the bugs have been there since 1997. My objective was to make the code
Hi,
On Thu, 2007-03-08 at 19:13 -0300, Luis A. Florit wrote:
Unfortunately, the code has more that one bug, or the correction
I made didn't solve the issue completely.
I think we should then replace the example by something simpler. The
point of this tutorial is not to show how to implement a
On Wed, 07 Mar 2007 08:53:34 +0100, Sven Neumann [EMAIL PROTECTED] wrote:
3) Ok, this is the serious one: The whole blurred region is shifted 1
pixel down. To check this, create a new white image with a single
black pixel in the middle, and blur it with radius=1. Go back and
forth and you
Hi,
On Wed, 2007-03-07 at 09:55 +0100, [EMAIL PROTECTED] wrote:
How is it a problem that there are these small and varying offsets all the
way through gimp?
I suspect this is not so much a bug in the example code, which as you say
is just an example, but in gimp itself.
If you can
On Wed, 07 Mar 2007 08:53:34 +0100, Sven Neumann [EMAIL PROTECTED] wrote:
3) Ok, this is the serious one: The whole blurred region is shifted 1
pixel down. To check this, create a new white image with a single
black pixel in the middle, and blur it with radius=1. Go back and
forth and you
On Wed, 07 Mar 2007 10:02:38 +0100, Sven Neumann [EMAIL PROTECTED] wrote:
Hi,
On Wed, 2007-03-07 at 09:55 +0100, [EMAIL PROTECTED] wrote:
How is it a problem that there are these small and varying offsets all
the
way through gimp?
I suspect this is not so much a bug in the example
Hi,
On Wed, 2007-03-07 at 11:03 +0100, [EMAIL PROTECTED] wrote:
OK, then you're probably right , it's a buggy eg. and it would be best to
give examples the work correcly to get ppl off to a good start.
I already fixed the wrong use of gimp_progress_set_value() this morning.
If someone wants
Hi,
On Wed, 2007-03-07 at 10:52 +0100, [EMAIL PROTECTED] wrote:
A quick check on rotation shows 1px drift in x and y. Create a 20x20 and
a 21x21 canvas put a pencil tool (11 circle) spot and rotate 90 degrees
about the centre of the dot. Preview gets it right but it moves when
* El 08/03/07 a las 1:57, [EMAIL PROTECTED] chamullaba:
In general just try to keep cool. You are perfectly right in
complaining about being lead astray by a bad code example and in
your place I would be equally pissed off about the time I had
wasted. I'm sure dismissive comments don't to
Hi,
On Wed, 2007-03-07 at 22:18 -0300, Luis A. Florit wrote:
My plugin is working fine, after I found my bug and the one in
the blur example. It's just annoying.
Then please explain the bug in the example code and send us a patch
(preferably against SVN) that we can apply so that others won't
Pals,
I made my first plugin in C for gimp, based on the one here:
http://developer.gimp.org/writing-a-plug-in/3/index.html
Unfortunately, this plugin has several bugs, that translated to my
own, and I am not being able to detect them (is there any other
source like the avove to get
I suggest to read the book Beginning Gimp written by Akkana Peck. Data
structures aren't cleared automatically. You have to clear them yourself.
Otherwise you have random garbage in your picture. This can happen but it
mustn't happen always.
On Tuesday 06 March 2007 18:16, Luis A. Florit
Hi,
On Tue, 2007-03-06 at 14:16 -0300, Luis A. Florit wrote:
http://developer.gimp.org/writing-a-plug-in/3/index.html
Unfortunately, this plugin has several bugs
If you can point out bugs in the tutorial, we would love to hear about
them so that they can be corrected. What exactly do
Hi,
On Tue, 2007-03-06 at 23:04 -0300, Luis A. Florit wrote:
These are the bugs I can remember now. Probably some of these are not
bugs... apologies then.
1) The bottom bar of the main window becomes blue when the dialog appears.
Looks like progress handling needs to be improved in the
20 matches
Mail list logo
