Re: running ldconfig
On Sun, Mar 05, 2000 at 02:16:04PM -0500, Robert L Krawitz [EMAIL PROTECTED] wrote: When the Gimp is installed, the make install should run ldconfig (on Elf-based systems, at any rate) so that ld.so picks up the new shared libraries. I don't think so: 1. libtool should make sure that the libraries are found anyway (unless moved). ld.so.cache is only that, a cache 2. only root can run ldconfig (without errors, that is) 3. not all systems have ldconfig or the same concept of shared libraries as linux (elf or not...) -- -==- | ==-- _ | ---==---(_)__ __ __ Marc Lehmann +-- --==---/ / _ \/ // /\ \/ / [EMAIL PROTECTED] |e| -=/_/_//_/\_,_/ /_/\_\ XX11-RIPE --+ The choice of a GNU generation | |
patch for gimp_edit_fill
I just uploaded a new patch to ftp.gimp.org (the file name is gimp-quinet-000308-0.patch.gz). This patch fixes the problems with Edit/Fill by allowing the user to choose the fill mode. The "Fill with background color" is prefered by some users who have been using the Gimp for a long time, but this is considered as a bug (or a non-intuitive feature) by those who are familiar with most other paint programs and who prefer "Fill with foreground color". This patch adds a new parameter to gimp_edit_fill(), which specifies the fill mode (FOREGROUND_FILL, BACKGROUND_FILL, ...). It also replaces the menu entry "Image/Edit/Fill" with two entries "Image/Edit/Fill with foreground" (bound to Ctrl-,) and "Image/Edit/Fill with background" (bound to Ctrl-. as before). WARNING: this patch applies to the core only and does not modify any of the Script-Fu or Perl-Fu scripts. This means that all scripts using gimp_edit_fill() will be broken because of the extra parameter. A trivial fix is to add the parameter BACKGROUND_FILL to all calls to gimp_edit_fill(), or BG-IMAGE-FILL in Script-Fu. Tomorrow, I will upload a separate patch adressing this issue (and some other fixes) in Script-Fu. In the meantime, this patch can be used by anybody who wants to update the Perl scripts or to update the translation of the menus. The patch is against 1.1.18. I wrote the first version for 1.1.17, but I upgraded to 1.1.18 yesterday and re-built the patch to make sure that it applies cleanly. I did not have the time to finish cleaning up all the Script-Fu scripts, so I decided to split the patch in two parts and to upload the first part today so that others (Marc?) can start working on the Perl scripts. -Raphael
Suggestion: disabling Perl-Fu installation if Gtk-Perl is not present
This has been suggested before, but I would like to bring it up again... I think that it would be better to disable the installation of all Perl-Fu scripts if any of the required modules (Gtk, PDL, Data::Dumper, Parse::RecDescent) are not detected by the configure script or, more exactly, by Makefile.PL. The argument for installing the scripts anyway is that the user can install the missing modules later. However, I think that it currently does more harm than good. Note that I am not criticizing the Gimp-Perl plug-in itself, only the way the Perl-Fu scripts are installed. I have installed the Gimp on many systems (Linux and Solaris) and the Perl-Fu scripts are working fine on the systems that have perl and all the required modules. But on the systems that do not have perl (it comes with all Linux distros but it is optional) or those that do not have the required modules (because the user did not download them from CPAN), the Perl-Fu scripts crash when the Gimp is started or when they are accessed from the menus. This makes a bad impression and the best solution is usually to uninstall everything, then re-configure with --disable-perl, re-compile and re-install. This extra hassle should not be necessary. Here are a few reasons why I think that the configure script should skip the installation of the Perl-Fu scripts if any of the required modules is missing: - All other plug-ins take the "safe" approach of not installing themselves if any dependency is not satisfied. As far as I know, the Perl plug-in is the only one that tries to install everything and hope that the user will install the missing things later. - I think that most users are updating the Gimp (re-compiling, re-installing) more frequently than they are updating Perl (even if it is only some modules). So there is no reason to force the installation of the Perl-Fu scripts if they could easily be installed later, after having installed the missing modules. One reason for updating the Gimp more frequently is that it is easier to get a single tar file for the Gimp than to have to search for separate modules on CPAN, especially on a computer that has no direct connection to the Internet. Another example: on a multi-user system, the user may not have the required priviledges for installing the Perl modules in the system directories (although the modules could be installed in a private directory if the users take care of modifying their environment.) - The Gimp takes 5 to 6 seconds longer to start if the required Perl modules are missing, because some Perl-Fu scripts crash during start-up and are queried again every time. See the first example included below. Besides, these crashes are not very informative for the user if he is not the one who installed the software and who knows what these messages mean. - The modules that do not crash during start-up will fail anyway when they are used. Except for some things such as the Perl Server, I haven't found a script that was usable without Gtk-Perl. When I attempted to use these scripts, they all started by popping up a dialog box that warns about the missing module, then start some operations and crash before producing any result (which brings another dialog box for reporting the error). Again, for a user who is not the installer, it only makes the Gimp look bad because the menus are cluttered with unusable entries that do nothing else than popping up error boxes. See the second example below. For these reasons, I think that it would be better to use the "safe" method: do not install any (or most of the) Perl-Fu scripts if the required modules are missing during the "configure" phase. And rely on the fact that the person who installed the Gimp will re-install it easily if the Perl modules are installed later. -Raphael -- Example 1 -- Here are the messages that are displayed every time the Gimp starts, taking 5-6 seconds on a Linux PC that has perl but does not have the required modules from CPAN: Can't locate Gtk.pm in @INC (@INC contains: /usr/lib/perl5/5.00503/i586-linux /usr/lib/perl5/5.00503 /usr/lib/perl5/site_perl/5.005/i586-linux /usr/lib/perl5/site_perl/5.005 .) at /usr/lib/perl5/site_perl/5.005/i586-linux/Gimp/UI.pm line 5. BEGIN failed--compilation aborted at /usr/lib/perl5/site_perl/5.005/i586-linux/Gimp/UI.pm line 5. BEGIN failed--compilation aborted at /usr/lib/gimp/1.1/plug-ins/avi line 10. ** WARNING **: wire_read: unexpected EOF (plug-in crashed?) Can't locate Gtk.pm in @INC (@INC contains: /usr/lib/perl5/5.00503/i586-linux /usr/lib/perl5/5.00503 /usr/lib/perl5/site_perl/5.005/i586-linux /usr/lib/perl5/site_perl/5.005 .) at /usr/lib/perl5/site_perl/5.005/i586-linux/Gimp/UI.pm line 5. BEGIN failed--compilation aborted at /usr/lib/perl5/site_perl/5.005/i586-linux/Gimp/UI.pm line 5. BEGIN failed--compilation aborted at /usr/lib/gimp/1.1/plug-ins/colorhtml line 9. ** WARNING **:
Re: running ldconfig
Date: Tue, 7 Mar 2000 16:45:59 +0100 From: Marc Lehmann [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] On Sun, Mar 05, 2000 at 02:16:04PM -0500, Robert L Krawitz [EMAIL PROTECTED] wrote: When the Gimp is installed, the make install should run ldconfig (on Elf-based systems, at any rate) so that ld.so picks up the new shared libraries. I don't think so: 1. libtool should make sure that the libraries are found anyway (unless moved). ld.so.cache is only that, a cache Well, then gimp.m4 does the wrong thing, since after I install a new version of the Gimp I can't use gimp.m4 within autoconf to test for the presence of the Gimp. It's considerably more than "just a cache"; it controls how runtime dynamic linking takes place. 2. only root can run ldconfig (without errors, that is) And make install normally installs software into areas that can only be installed into by root. 3. not all systems have ldconfig or the same concept of shared libraries as linux (elf or not...) Like I said: this should be run as part of the installation procedure "on Elf-based systems, at any rate". -- Robert Krawitz [EMAIL PROTECTED] http://www.tiac.net/users/rlk/ Tall Clubs International -- http://www.tall.org/ or 1-888-IM-TALL-2 Member of the League for Programming Freedom -- mail [EMAIL PROTECTED] Project lead for The Gimp Print -- http://gimp-print.sourceforge.net "Linux doesn't dictate how I work, I dictate how Linux works." --Eric Crampton
Re: Suggestion: disabling Perl-Fu installation if Gtk-Perl is not present
On Wed, 8 Mar 2000, Seth Burgess [EMAIL PROTECTED] wrote: On Wed, Mar 08, 2000 at 01:07:52PM +0100, Raphael Quinet wrote: This has been suggested before, but I would like to bring it up again... I think that it would be better to disable the installation of all Perl-Fu scripts if any of the required modules (Gtk, PDL, Data::Dumper, Parse::RecDescent) are not detected by the configure script or, more exactly, by Makefile.PL. Parse::RecDescent is used only by the script-fu to perl-fu converter, AFIAK. I get Data::Dumper installed as part of perl-base. If there's a perl distro without that, it probably won't be terribly useful for developing perl based scripts (guessing). In any case, if Parse::RecDescent is affecting running of any plug-ins, I'd call that a bug. If Parse::RecDescent is not needed for "normal users", i.e. those who do not have to use scm2perl or scm2scm, then maybe the Makefile.PL should not complain about it. The Gimp configure script does not complain if perl is missing, although it is required for developers who want to use the pdbgen. But this is a minor issue. As for Data::Dumper, it is indeed part of the default perl installation, but I think that some versions older than 5.005 had it as an option only. I do not know which versions exactly, but I know that I had to install the Gimp on some systems that had an old (and probably buggy) version of perl without Data::Dumper. As far as PDL and Gtk goes, I'm in agreement that it shouldn't install those scripts with those dependencies uless those packages are detected. gimptool should be able to install them later for users wishing to upgrade later - its the way everything else in gimp works. I'm glad to see that someone agrees... :-) perlotine: the gtk perl module is required to open a dialog window, running with default values (perl_fu_perlotine) perlotine: No horizontal or vertical guides found. Aborted. at /usr/lib/gimp/1.1/plug-ins/perlotine line 176. (ERROR) This error anyway is legit - you need guides to run perlotine! It would tell you so in a dialog box, but its not availble for lack of Gtk. In this case, I think the commandline is pretty clear. That's right. Sorry, that was a bad example. I should try that script again with some guides defined. Were the color related PDB errors pre or post Gimp-Edit-Fill changes? I captured most of these errors yesterday just after installing gimp-1.1.18 and before re-applying my gimp_edit_fill() patches. So these come from an unmodified 1.1.18 distribution. -Raphael
Re: Suggestion: disabling Perl-Fu installation if Gtk-Perl is not present
On Wed, Mar 08, 2000 at 01:07:52PM +0100, Raphael Quinet wrote: This has been suggested before, but I would like to bring it up again... I think that it would be better to disable the installation of all Perl-Fu scripts if any of the required modules (Gtk, PDL, Data::Dumper, Parse::RecDescent) are not detected by the configure script or, more exactly, by Makefile.PL. Parse::RecDescent is used only by the script-fu to perl-fu converter, AFIAK. I get Data::Dumper installed as part of perl-base. If there's a perl distro without that, it probably won't be terribly useful for developing perl based scripts (guessing). In any case, if Parse::RecDescent is affecting running of any plug-ins, I'd call that a bug. As far as PDL and Gtk goes, I'm in agreement that it shouldn't install those scripts with those dependencies uless those packages are detected. gimptool should be able to install them later for users wishing to upgrade later - its the way everything else in gimp works. perlotine: the gtk perl module is required to open a dialog window, running with default values (perl_fu_perlotine) perlotine: No horizontal or vertical guides found. Aborted. at /usr/lib/gimp/1.1/plug-ins/perlotine line 176. (ERROR) This error anyway is legit - you need guides to run perlotine! It would tell you so in a dialog box, but its not availble for lack of Gtk. In this case, I think the commandline is pretty clear. Were the color related PDB errors pre or post Gimp-Edit-Fill changes? Seth Burgess [EMAIL PROTECTED]
Re: Suggestion: disabling Perl-Fu installation if Gtk-Perl is not present
Hi, This has been suggested before, but I would like to bring it up again... I think that it would be better to disable the installation of all Perl-Fu scripts if any of the required modules (Gtk, PDL, Data::Dumper, Parse::RecDescent) are not detected by the configure script or, more exactly, by Makefile.PL. I second this suggestion. Salut, Sven
recent commit...
* app/cursorutil.c (gtkutil_compress_motion) * app/edit_selection.c (process_event_queue_keys): Guard against gdk_event_get returning NULL (which can happen at least on Win32). I'd kinda like to see this reverted and fixed at the WIN32 GDK level -- if gdk_event_get() fails straight after a gdk_events_pending() succeeds in a single-threaded app then it's not just GIMP that's going to have a problem... ...unless this is documented cross-platform behaviour, of course! Tell me if I missed something. --Adam -- Adam D. Moss. ,,^^[EMAIL PROTECTED]http://www.foxbox.org/
design
www.graphicnet.net If you need help with illustration and design for your current projects, let me know. I'm looking for projects that I can add to my portfolio.
Can anybody tell me the mail address to unsubscribe form this group.
Thanx, shiv
Upgrade probs....
Thanks in advance if anyone can help me with this: When I try to "make" I get the following problems: Making all in po make[2]: Entering `/home/winters/gimp-1.1.18/po' make[2]: *** No rule to make target `en.gmo', needed by `all-yes'. Stop. make[2]: Leaving directory `/home/winters/gimp-1.1.18/po' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/winters/gimp-1.1.18' make: *** [all-recursive-am] Error 2 The part that bothers me is that this has happened to me in the past. Thanks in advance to anyone who has time to help. -- Jon Winters visit the Obscura Lounge in OpenVerse http://www.openverse.org/
Re: Suggestion: disabling Perl-Fu installation if Gtk-Perl is not present
Hi, Why can't those scripts just _not_register_themselves_ if the required modules are not available? gimpmagick does this and the only problem is that it has to be re-probed every time the GIMP starts. The only reason I can think of to not install these scripts is to avoid the delay at startup. The delay at startup for probing the scripts would IMHO be very annoying. I don't see why people wouldn't prefer to reinstall the perl parts after they installed missing packages. That's how it works for all other plug-ins (jpeg, tiff, ...). Salut, Sven
