Re: Submitting Patches
On , 8 Jan 2001, Sven Neumann wrote: A short patch like this one can always be sent through this list. But I'd prefer if you could redo the patch, because of the following reasons: - it reverts a change in the preferences dialog. You obviously didn't cvs update before creating the diff. - it changes some autogenerated code (the files ending in _cmds.c). The changes have to performed in the directory tools/pdbgen/pdb on the .pdb files. You could help us by providing a new patch. Sent it to the list again or upload it to ftp.gimp.org. It might be an idea to put info like this in the HACKING file, so we don't need to keep repeating it. Austin
RE: Submitting Patches
A short patch like this one can always be sent through this list. But I'd prefer if you could redo the patch, because of the following reasons: - it reverts a change in the preferences dialog. You obviously didn't cvs update before creating the diff. D'oh, my bad. - it changes some autogenerated code (the files ending in _cmds.c). The changes have to performed in the directory tools/pdbgen/pdb on the .pdb files. It would be nice to have this written down somewhere, as someone mentioned. Looking now I notice the little comment at the beginning of the files, but other than that they don't look very generated. You could help us by providing a new patch. Sent it to the list again or upload it to ftp.gimp.org. An updated version of the patch is attached. Let me know if all is well this time. Cheers, ~ol blending2.patch.gz
Re: Submitting Patches
Hi, "oliver" [EMAIL PROTECTED] writes: An updated version of the patch is attached. Let me know if all is well this time. I have applied the patch to CVS. If you would have given us your full name, I would also have been able to it to the ChangeLog... Salut, Sven
RE: Submitting Patches
Previous diff was a bit broken. Sorry about the spam. I've hacked a few of photoshop's blending modes (dodge and burn -- which are different in photoshop than multiply and divide -- and hardlight) into the gimp 1.3 sources. I was wondering if this would make an interesting patch, and if so how do you guys prefer recieving them? ~ol blending.patch.gz
Re: Submitting Patches
Hi, "oliver" [EMAIL PROTECTED] writes: I've hacked a few of photoshop's blending modes (dodge and burn -- which are different in photoshop than multiply and divide -- and hardlight) into the gimp 1.3 sources. I was wondering if this would make an interesting patch, and if so how do you guys prefer recieving them? In any event a unified diff against current CVS is attached. A short patch like this one can always be sent through this list. But I'd prefer if you could redo the patch, because of the following reasons: - it reverts a change in the preferences dialog. You obviously didn't cvs update before creating the diff. - it changes some autogenerated code (the files ending in _cmds.c). The changes have to performed in the directory tools/pdbgen/pdb on the .pdb files. You could help us by providing a new patch. Sent it to the list again or upload it to ftp.gimp.org. Salut, Sven
