Re: [Gimp-developer] New GIMP configure warning/error

[Michael Natterer]

Hi,

Since I'm not sure to which mail to reply, I'll reply to the thread's
original mail...

I'll keep it short:

- additional dependency: Í could not care less about some more
  MB to build/install/distribute in order to get whatever
  feature.

- networking code: that's a tough one, we are running into
  security issues here, but since we are using a completely
  broken old webkit version, can we really make it worse... :)

One thing that IMO went wrong with this change is that it should
have gone into master in the first place, and not just picked
to gimp-2-8 right away. We should really only push stuff to 2-8
when we are 100% sure.

Regards,
Mitch

On Thu, 2017-05-11 at 14:34 -0400, Partha Bagchi wrote:
> I am getting the following warning:
> 
> > WARNING: Your GTK+ version is 2.24.31.
> >  The recommended GTK+ version under Windows is 2.24.32 or
> > over.
> >  If you continue without updating GTK+, shortcuts won't
> > work with
> >  non-latin locales, and vector icons will be disabled.
> 
> 
> According to http://ftp.gnome.org/pub/GNOME/sources/gtk+/2.24/, the
> latest
> version is 2.24.31. So, does gtk+ need to be compiled from git to
> make this
> warning go away?
> 
> Secondly, I am getting the following error:
> 
> > Error: GIMP configuration failed.
> >   - Error: missing dependency glib-networking
> >   *** Test for glib-networking failed. This is required.
> 
> 
> I am perplexed to see that we need glib-networking suddenly since my
> git
> pull from a couple of days ago? Is there a reason to requiring glib
> networking support?
> 
> Thanks,
> Partha
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop
> er-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

Re: [Gimp-developer] New GIMP configure warning/error

[Simone Karin Lehmann]

> Am 13.05.2017 um 15:50 schrieb Jehan Pagès :
> 
> 
> We have a few issues with our webkit internal browser, one of them is
> that we still use an old webkit version (because of GTK+2; newer
> versions are for GTK+3), which is therefore deprecated. Security wise,
> this is not fine. Though obviously since this browser is made only to
> reach our manual, which are static pages, and cannot be used to reach
> random pages, the risk is lessened. That's even more a reason to make
> sure we have SSL/TLS activated, because if GIMP requests the help
> browser to reach https://gimp.org, we want to drop the connection in
> case of MITM, especially because of the broken webkit.
> 
> This issue will disappear with GIMP 3, where we should be able to
> update the dependency. This will still be some work to do so. Maybe at
> this point, it could be wise to just drop the webkit dependency and
> make the browser do all the work. On the other hand, a minimal help
> browser is still nice. That's not an easy decision IMO.
> 
> We could also drop the help browser even for GTK+2 builds, but then it
> needs some minimal patch to not have GIMP consider this as a lesser
> GIMP. If not mistaken, when the browser is not built-in, right now
> GIMP would complain and display a popup asking you if you want to use
> your web browser instead. We would need to get rid of this warning if
> we start considering the system browser as the defaults display mode
> of the manual. That's probably really easy, but I have more pressing
> things I want to do for 2.10. Patches are welcome for discussion
> though. I believe it still makes sense in a security point of view
> considering the deprecated webkit we use, so I would be in favor of
> the patch (even if just as a temporary fix until we get to GIMP 3 and
> can migrate to newer webkit).
> 

I’ve just made those patches for OS X and included them into my version on 
gimp.lisanet.de. 
It just uses the system defined web browser for accessing online help and I’ve 
even written 
a plugin which replaces the help browser with the system-wide web browser and 
still offers 
context sensitive help. 

Just have a look at my patches at my SorceForge SVN repository 
https://sourceforge.net/p/gimponosx/code/HEAD/tree/GimpPorts/ports/graphics/gimp2/files/
They are just a few lines of Cocoa API calls...

Simone


___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

Re: [Gimp-developer] New GIMP configure warning/error

[Jehan Pagès]

Hi,

On Sat, May 13, 2017 at 3:40 PM, Partha Bagchi  wrote:
>
>
> On Sat, May 13, 2017 at 8:52 AM, Jehan Pagès 
> wrote:
>>
>> Hi,
>>
>> On Sat, May 13, 2017 at 6:25 AM, Partha Bagchi  wrote:
>> >
>> >
>>
>> >> No, there are at least 2 features affected: open remote files indeed
>> >> and the help browser (help will fail showing with an error since our
>> >> websites are now https only). This last one was getting quite a lot of
>> >> report on the tracker and was very bad experience.
>> >> Anyway nowadays https is the standard for web access. Not supporting
>> >> this is not acceptable IMO.
>> >>
>> >> Jehan
>> >
>> >
>> > Hi,
>> >
>> > You realize that for platforms other than Linux, that if you wish to
>> > install
>> > glib-networking, you have to install
>>
>> Yes I realize that dependencies have often dependencies themselves.
>> Unless there is something which proves to be impossible to compile on
>> other platforms, I don't see the problem.
>>
>> > gnutls which requires that you install
>> > nettle which in turn requires that you install gmp?
>>
>> gnutls is a SSL/TLS lib (the feature we need). And from my searches,
>> nettle is apparently a cryptographic library and gmp would be an
>> arithmetic library. This does make total sense for a SSL/TLS lib
>> (which is a cryptographic protocol, and cryptography usually needs a
>> lot of arithmetic).
>> I don't see your point. That doesn't seem at all far fetched
>> dependencies for the feature we need, quite the opposite.
>>
>> > All this because you
>> > want remote help files and remote images be accessed from GIMP? Does
>> > this
>> > seem reasonable to you?
>>
>> It does seem absolutely reasonable, yes. I would even say that in
>> 2017, not having support for TLS/SSL when we have web access
>> requirement would be the thing which is absolutely non-reasonable.
>
> For an image editor, I think this is unreasonable. I don't understand why we
> are considering GIMP to be a network aware product due to 2 possible usage
> when the rest of GIMP does not depend on it.

GIMP *IS* a network-aware software (not a "product", we are not a
company). Especially with the port to GIO. Right, not everything is
about network, and we don't want this. That's only a few features, and
this won't increase much since we are not into jailing people into
services and fees for web access (once again, we are not a company).
But even if just for a few features, that's still important features.
There is not much arguing that internet access and better interaction
with web/internet resources is considered as granted by most people
nowadays. Let's not be backward please, GIMP should live with its
time.

> Is it not possible to ship the
> help files as PDFs while disabling URI if TLS/SSL is not installed with the
> package?

How do you determine which language to ship? All of them? Also it
needs some code on our website then to make this conditional decision.
And not only our own website but all websites of third party (like
yours). Are you going to write it for yours at least?
So yes, nearly everything is possible. That's more or less work
depending on what you want. And we welcome contributions if you have
good ideas.

Also as said already, that would only make for one of the feature (the
help system). We still need to allow people to access remote files in
a secure way.

>> I am rerunning a crossbuild again to check that everything is all
>> right, just to make sure. What I can say is that there exists
>> pre-built packages for glib-networking (and all the dependencies) so I
>> could install it and all its dependencies in about 10 seconds inside
>> my crossbuild environment (using my tool called crossroad, with a
>> single command: crossroad install glib-networking). So first it means
>> that glib-networking is buildable for Windows and in you have the
>> right tools, that's really not much of a hassle. Now on Windows, I
>> have no idea how hard things are. But I assume you have various helper
>> tools too.
>
> You mean it's easy on Windows and then on Windows you have no idea how hard
> things are? Did you mean Windows it's easy and Mac you don't know? I am not
> sure I understand.

I don't build *on* Windows, no. But I build *for* Windows all the
time, as I just explained. Until we got a developer dedicated to
Windows (there is one lately, hopefully he'll stay long!), I was one
of the only ones who would sometimes fix bugs and test on Windows,
taking some of my time to install VMs, cross-building, etc. Please,
there is no need to be unpleasant and smirking at other's work. I am
not unpleasant towards you, I expect the same.

> In any case, as Kris mentioned below, you are talking
> about bloating the application on both Windows and Mac.

Come on, it's a very small dependency which itself brought 3 more
small dependencies!
I will check right now the size of all deps:

glib-networking:
- libgiognutls.dll 117K
- 

Re: [Gimp-developer] New GIMP configure warning/error

[Jehan Pagès]

Hi,

On Sat, May 13, 2017 at 3:15 PM, Pat David  wrote:
> Is it not possible to invoke the default browser and hand off the https
> responsibility to it?

That's definitely a possibility, and even a good one IMO.

We have a few issues with our webkit internal browser, one of them is
that we still use an old webkit version (because of GTK+2; newer
versions are for GTK+3), which is therefore deprecated. Security wise,
this is not fine. Though obviously since this browser is made only to
reach our manual, which are static pages, and cannot be used to reach
random pages, the risk is lessened. That's even more a reason to make
sure we have SSL/TLS activated, because if GIMP requests the help
browser to reach https://gimp.org, we want to drop the connection in
case of MITM, especially because of the broken webkit.

This issue will disappear with GIMP 3, where we should be able to
update the dependency. This will still be some work to do so. Maybe at
this point, it could be wise to just drop the webkit dependency and
make the browser do all the work. On the other hand, a minimal help
browser is still nice. That's not an easy decision IMO.

We could also drop the help browser even for GTK+2 builds, but then it
needs some minimal patch to not have GIMP consider this as a lesser
GIMP. If not mistaken, when the browser is not built-in, right now
GIMP would complain and display a popup asking you if you want to use
your web browser instead. We would need to get rid of this warning if
we start considering the system browser as the defaults display mode
of the manual. That's probably really easy, but I have more pressing
things I want to do for 2.10. Patches are welcome for discussion
though. I believe it still makes sense in a security point of view
considering the deprecated webkit we use, so I would be in favor of
the patch (even if just as a temporary fix until we get to GIMP 3 and
can migrate to newer webkit).

Finally it does not totally deal with the glib-networking need. We
still need support for https for opening remote files. Nowadays not
having support for https while pretending having support for remote
file access is not ok. The web is slowly getting into a full https
state, and all the web browser companies are pushing toward this.
Fighting this is useless (and also wrong; full https is good IMO).
So even with this one use case, we would still need glib-networking.

Kris' idea though totally makes sense if developers of other platform
don't want of gnutls (which I can understand, especially if they
platform have — I don't know — a default local implementation for
TLS). Patches welcome. :-)

Jehan

> On Sat, May 13, 2017 at 8:05 AM Kristian Rietveld  wrote:
>>
>>
>> > On 13 May 2017, at 14:52, Jehan Pagès 
>> > wrote:
>> >>
>> >> You realize that for platforms other than Linux, that if you wish to
>> >> install
>> >> glib-networking, you have to install
>> >
>> > Yes I realize that dependencies have often dependencies themselves.
>> > Unless there is something which proves to be impossible to compile on
>> > other platforms, I don't see the problem.
>>
>> A possible problem is that all of these extra dependencies have to be
>> shipped in macOS and Windows packages. If in any of these dependencies
>> serious bugs (e.g. security) are found, we need to ship updated packages. A
>> problem like this does not exist on Linux since you would typically simply
>> update the distribution packages (although not sure how that will work for
>> Flatpak).
>>
>> A potential solution could be to write a Mac-specific GIO TLS backend that
>> depends on macOS system libraries which can be shipped instead of the
>> default TLS backend that depends on gnutls.
>>
>>
>> regards,
>>
>> -kris.
>>
>> ___
>> gimp-developer-list mailing list
>> List address:gimp-developer-list@gnome.org
>> List membership:
>> https://mail.gnome.org/mailman/listinfo/gimp-developer-list
>> List archives:   https://mail.gnome.org/archives/gimp-developer-list
>
> --
> https://patdavid.net
> GPG: 66D1 7CA6 8088 4874 946D  18BD 67C7 6219 89E9 57AC



-- 
ZeMarmot open animation film
http://film.zemarmot.net
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list