Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Jehan Pagès
Hi, On Mon, Jul 29, 2013 at 1:28 AM, Partha Bagchi wrote: > Sorry Jehan, didn't mean to "bug" you. :) Didn't realize you are in NZ. No prob. I prefer these kind of annoying crashes gone as soon as possible myself! ;-) > Yes, all is good now. The crash is history!! Cool! I'll push this then. :-

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Partha Bagchi
Sorry Jehan, didn't mean to "bug" you. :) Didn't realize you are in NZ. Yes, all is good now. The crash is history!! Thanks so much! Partha On Sun, Jul 28, 2013 at 8:07 AM, Jehan Pagès wrote: > Hi, > > On Sun, Jul 28, 2013 at 11:51 PM, Partha Bagchi > wrote: > > As of night, the crash still

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Partha Bagchi
Are you using Macport? I don't use Macport and build all my dependencies from scratch. On Sun, Jul 28, 2013 at 1:19 AM, su_v wrote: > On my system (10.7.5), GIMP launches ok, but crashes when opening > the preferences. See stack trace in >

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Partha Bagchi
To answer the first question, here is the trace: __ #0 0x7fff8b970698 in __wait4 () #1 0x000101868353 in g_on_error_stack_trace () #2 0x0001018687f2 in g_on_error_query () #3 0x0001ebd4 in gimp_eek () #4 0x0001000

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Partha Bagchi
Hi Jehan, Here is the output from the crash. Hope it's helpful. I don't see anything myself. :( Thanks! Partha On Sat, Jul 27, 2013 at 11:47 PM, Jehan Pagès wrote: > Hey Partha, su_v, > > could you test the following patch: > - copy it in your GIMP directory; > - apply it with this command

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Jehan Pagès
Hi, On Sun, Jul 28, 2013 at 11:51 PM, Partha Bagchi wrote: > As of night, the crash still occurred. Jehan, is there a new patch? Sorry Partha, I went out. I am kind of a particular timezone (New Zealand). I just realized I completely misused a macro. That may have been the issue, even though it

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-28 Thread Partha Bagchi
As of night, the crash still occurred. Jehan, is there a new patch? Thanks, Partha On Sun, Jul 28, 2013 at 2:57 AM, su_v wrote: > On 2013-07-28 08:03 +0100, Jehan Pagès wrote: > > Hi, > > > > On Sun, Jul 28, 2013 at 5:42 PM, su_v > wrote: > >> On 2013-07-28 07:32 +0100, Jehan Pagès wrote: > >

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread su_v
On 2013-07-28 08:03 +0100, Jehan Pagès wrote: > Hi, > > On Sun, Jul 28, 2013 at 5:42 PM, su_v wrote: >> On 2013-07-28 07:32 +0100, Jehan Pagès wrote: >>> yes I saw your message in the report too. Actually I was feeling this >>> would work your crash around when I wrote this patch. But that is >>>

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Hi, On Sun, Jul 28, 2013 at 5:42 PM, su_v wrote: > On 2013-07-28 07:32 +0100, Jehan Pagès wrote: >> yes I saw your message in the report too. Actually I was feeling this >> would work your crash around when I wrote this patch. But that is >> still not a fix. When you open the preferences and chec

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread su_v
On 2013-07-28 07:32 +0100, Jehan Pagès wrote: > yes I saw your message in the report too. Actually I was feeling this > would work your crash around when I wrote this patch. But that is > still not a fix. When you open the preferences and check the Interface > tab, then the language list, this list

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Hi su_v, yes I saw your message in the report too. Actually I was feeling this would work your crash around when I wrote this patch. But that is still not a fix. When you open the preferences and check the Interface tab, then the language list, this list is empty now, right? Jehan On Sun, Jul 2

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread su_v
[ reposting to the list, with trimmed fullquote ] On my system (10.7.5), GIMP launches ok, but crashes when opening the preferences. See stack trace in With your patch applied (and no other local changes), GIMP still launches ok, and now no

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Just to try into another direction: if you comment out the line: parse_iso_codes (base_lang_list, NULL); (line 173 in app/widgets/gimplanguagestore-parser.c) Do you still have the crash? And if yes, the same trace? Jehan On Sun, Jul 28, 2013 at 4:22 PM, Jehan Pagès wrote: > Hmmm... NULL nowhere

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Hmmm... NULL nowhere, no strange values, nothing. Did the trace still say it happened at strchr() inside gimp_language_store_parser_init ()? Jehan On Sun, Jul 28, 2013 at 4:16 PM, Partha Bagchi wrote: > Hi Jehan, > > Here is the output from the crash. > > Hope it's helpful. I don't see anything

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Hey Partha, su_v, could you test the following patch: - copy it in your GIMP directory; - apply it with this command from the GIMP directory: patch -p0 < osx_crash.diff - compile and try again. I believe it would not fix your crash, because I did not change the calls where your traces say it happ

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Partha Bagchi
Well, not to worry. I have a Mac handy and willing to test. :) Good news for you is that if I comment out gimp_language_store_parser_init() in gui.c, Gimp compiles and runs fine without language support of course. Thanks, Partha On Sat, Jul 27, 2013 at 9:47 PM, Jehan Pagès wrote: > Argh! I sh

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Jehan Pagès
Argh! I should nearly have a Mac just to test code there! uhuh Let me have a look. :-) Jehan On Sun, Jul 28, 2013 at 10:39 AM, Partha Bagchi wrote: > Should have mentioned the segfault is related to > gimp_language_store_parser_init () > __

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Partha Bagchi
Should have mentioned the segfault is related to gimp_language_store_parser_init () __ ./gimp-2.9 --verbose Cannot spawn a message bus without a machine-id: Unable to load /var/lib/dbus/machine-id or /etc/machine-id: Failed to

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-27 Thread Partha Bagchi
Jehan, Looks like the segfault is back? Thanks, Partha On Fri, Jul 19, 2013 at 7:12 AM, Partha Bagchi wrote: > Jehan, > > Thumbs up! All good now. It didn't crash and I was able to open images etc. > > Thanks again, > Partha > > > > On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès > wrote: > >

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-19 Thread Partha Bagchi
Jehan, Thumbs up! All good now. It didn't crash and I was able to open images etc. Thanks again, Partha On Thu, Jul 18, 2013 at 10:56 PM, Jehan Pagès wrote: > Hey Partha, > > you can pull and test now. I made a simple commit where I only take > care of the unset env variable issue. Hopefully

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Jehan Pagès
Hey Partha, you can pull and test now. I made a simple commit where I only take care of the unset env variable issue. Hopefully this will fix the OSX crash. I'll handle the other issue I discovered about not being thread-safe later. Tell me how it goes. :-) Jehan On Fri, Jul 19, 2013 at 11:26 AM

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Jehan Pagès
Partha, nothing pushed yet. I'll do this and send a message. :-) Jehan On Fri, Jul 19, 2013 at 11:21 AM, Partha Bagchi wrote: > Jehan, > > Do you want me to go ahead test the current code or wait for you to add > additional logic? > > Thanks! > Partha > > > > On Thu, Jul 18, 2013 at 10:04 PM, J

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Partha Bagchi
Jehan, Do you want me to go ahead test the current code or wait for you to add additional logic? Thanks! Partha On Thu, Jul 18, 2013 at 10:04 PM, Jehan Pagès wrote: > Hi, > > I searched a little more though, and it seems on BSDs, hence on OSX, > indeed setenv with a NULL value could crash the

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Jehan Pagès
Hi, I searched a little more though, and it seems on BSDs, hence on OSX, indeed setenv with a NULL value could crash the program. The setenv in GNU libc on the other hand perfectly handles the case explicitly. So obviously when I see this kind of code (note I am not 100% sure this is the code for

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Partha Bagchi
Jehan, I will test it tomorrow. I will get back to you with the results. Thanks for your prompt response! Partha On Thu, Jul 18, 2013 at 11:42 AM, Jehan Pagès wrote: > Hi again, > > I have some working code in my working branch now where I applied the > concepts I wrote about (basically init

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Partha Bagchi
Sounds good. I will file a bug. Thanks, Partha On Thu, Jul 18, 2013 at 8:40 AM, Michael Natterer wrote: > On Wed, 2013-07-17 at 17:31 -0400, Partha Bagchi wrote: > > Hey V, > > > > Thanks for checking on this. I am glad (in a way) that my system is not > the > > only one having this issue! :)

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Jehan Pagès
Hi again, I have some working code in my working branch now where I applied the concepts I wrote about (basically initializing the language store only once and at the very start of the program, before any threading would occur hopefully). Don't know if that will be the finale code, but should be a

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Jehan Pagès
Hey all, it seems I am the culprit for this bug. I don't have this crash on Linux though. It looks like the implementation of setenv/getenv is different on OSX. According to glib doc, the problem may be that on some implementations, successive calls may use the same buffer. I guess that's the cas

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-18 Thread Michael Natterer
On Wed, 2013-07-17 at 17:31 -0400, Partha Bagchi wrote: > Hey V, > > Thanks for checking on this. I am glad (in a way) that my system is not the > only one having this issue! :) > > I will try to revert the above changes and see if the problem disappears. This is most certainly due to the new la

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-17 Thread Partha Bagchi
Hey V, Thanks for checking on this. I am glad (in a way) that my system is not the only one having this issue! :) I will try to revert the above changes and see if the problem disappears. Partha On Wed, Jul 17, 2013 at 7:51 AM, su_v wrote: > On 2013-07-17 01:19 +0100, Partha Bagchi wrote: >

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-17 Thread su_v
On 2013-07-17 13:51 +0100, su_v wrote: > Workaround (at least for this segfault at launch time) is to run GIMP > like this: > > $ echo $LANG > en_US.UTF-8 > $ LANGUAGE="$LANG" gimp --verbose Just to clarify: the problem (at least on my 10.7.5 system) seems to be that in the default shell $LANGUA

Re: [Gimp-developer] Gimp git on Mac Segfault

2013-07-17 Thread su_v
On 2013-07-17 01:19 +0100, Partha Bagchi wrote: > My recent (last built a few moment ago) git builds (2.9) have been > instantly segfaulting on MBR running Mountain Lion. > > gdb backtrace (or commandline execution) shows: > ./gimp-2.9 (pid:42315): [E]xit, [H]alt, show [S]tack trace or [P]roceed:

[Gimp-developer] Gimp git on Mac Segfault

2013-07-16 Thread Partha Bagchi
My recent (last built a few moment ago) git builds (2.9) have been instantly segfaulting on MBR running Mountain Lion. gdb backtrace (or commandline execution) shows: ./gimp-2.9 (pid:42315): [E]xit, [H]alt, show [S]tack trace or [P]roceed: S #0 0x7fff8b257698 in __wait4 () #1 0x0001018de