Re: [Gimp-developer] Cropping border color

2015-09-03 Thread Brad Gibson
Hey guys, I found a workaround. I just use the rectangle select tool, click 
hide selection and layer boundary to remove distractions from the edges, and 
use crop to selection. I assigned a shortcut to this function, because I use 
that and undo consecutively. When I undo, all I have to do is click within the 
original selection, even though I can't see any lines, and the adjustable 
selection square re-appears as it used to be. It's a little slower, but perfect 
for those times when I have to fit a hard-to-crop picture into a certain 
standard ratio. 


 On Friday, June 5, 2015 12:41 AM, Liam R. E. Quin  wrote:
   

 On Wed, 2015-06-03 at 21:09 +0200, Ofnuts wrote:
> On 02/06/15 17:50, Burnell West wrote:
> > > On Jun 1, 2015, at 11:07 PM, Brad Gibson  > > > wrote:
> > > 
> > > It would be great if I could choose to see pure black around 
> > > whatever I'm cropping,

[...]


> > Simply add a black layer and put it behind the image

This doesn't work... it turns grey when you draw the crop tool 
rectangle.

> > 
> 
> Or Edit>Preferences>Display>Transparency>Check style>Black only

Nether does this. It has no effect on the crop tool preview at all.

I had a look at editing the source to change the way the reduced-
contrast area around the cropping rectangle is drawn -- a colour 
swatch on tool options for the crop tool would not be out of line, nor 
even an opacity slider, as on e.g. the Rotate tool. I found the place 
(I think) where the cairo outer rectangle is made, so maybe it's a 
case of adding a fill to that, and passing the colour (and opacity?) 
as arguments from the crop tool preview function, I'm not sure.

I've often wished for a way for Undo to go back to the exact state 
just before the operation, including e.g. the uncommitted selection 
that you could edit, the crop ectangle, the perspective grid. It would 
be clean-warm-dry-black-sock awesome.

Liam

> ___
> gimp-developer-list mailing list
> List address:    gimp-developer-list@gnome.org
> List membership: 
> https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:  https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:    gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:  https://mail.gnome.org/archives/gimp-developer-list


  
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Cropping border color

2015-06-05 Thread Liam R. E. Quin
On Wed, 2015-06-03 at 21:09 +0200, Ofnuts wrote:
> On 02/06/15 17:50, Burnell West wrote:
> > > On Jun 1, 2015, at 11:07 PM, Brad Gibson  > > > wrote:
> > > 
> > > It would be great if I could choose to see pure black around 
> > > whatever I'm cropping,

[...]


> > Simply add a black layer and put it behind the image

This doesn't work... it turns grey when you draw the crop tool 
rectangle.

> > 
> 
> Or Edit>Preferences>Display>Transparency>Check style>Black only

Nether does this. It has no effect on the crop tool preview at all.

I had a look at editing the source to change the way the reduced-
contrast area around the cropping rectangle is drawn -- a colour 
swatch on tool options for the crop tool would not be out of line, nor 
even an opacity slider, as on e.g. the Rotate tool. I found the place 
(I think) where the cairo outer rectangle is made, so maybe it's a 
case of adding a fill to that, and passing the colour (and opacity?) 
as arguments from the crop tool preview function, I'm not sure.

I've often wished for a way for Undo to go back to the exact state 
just before the operation, including e.g. the uncommitted selection 
that you could edit, the crop ectangle, the perspective grid. It would 
be clean-warm-dry-black-sock awesome.

Liam

> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: 
> https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Cropping border color

2015-06-04 Thread Gez
El jue, 04-06-2015 a las 07:47 +, Saul Goode escribió:
> > On Jun 1, 2015, at 11:07 PM, Brad Gibson  wrote:
> >
> > It would be great if I could choose to see pure black around whatever I'm 
> > cropping, because I make very meticulous crops of photos for artistic 
> > purposes, and I often have to crop and go back multiple times because it 
> > looks different in the final version with solid white/gray/black compared 
> > to transparent while I'm cropping. Or else, if it's easier, make it so that 
> > I can undo the finalization of the crop but go back to where I left the 
> > crop at. Thanks.Brad G.
> 
> 
> Are you willing to re-compile?
> 
> 
> If you change the passe_partout color in app/display/gimpdisplayshell-style.c 
> [1] to be { 0.0, 0.0, 0.0, 1.0}, you should achieve the result you seek 
> (though I have not tested this).

Making the color and opacity of the passepartout an option of the crop
tool would be a nice feature. The quick mask already has that and it's
really useful.

G.

___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Cropping border color

2015-06-04 Thread Saul Goode
> On Jun 1, 2015, at 11:07 PM, Brad Gibson  wrote:
>
> It would be great if I could choose to see pure black around whatever I'm 
> cropping, because I make very meticulous crops of photos for artistic 
> purposes, and I often have to crop and go back multiple times because it 
> looks different in the final version with solid white/gray/black compared to 
> transparent while I'm cropping. Or else, if it's easier, make it so that I 
> can undo the finalization of the crop but go back to where I left the crop 
> at. Thanks.Brad G.


Are you willing to re-compile?


If you change the passe_partout color in app/display/gimpdisplayshell-style.c 
[1] to be { 0.0, 0.0, 0.0, 1.0}, you should achieve the result you seek (though 
I have not tested this).



[1]

https://git.gnome.org/browse/gimp/tree/app/display/gimpdisplayshell-style.c?h=gimp-2-8#n73





___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:  https://mail.gnome.org/archives/gimp-developer-list
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Cropping border color

2015-06-03 Thread Ofnuts

On 02/06/15 17:50, Burnell West wrote:

On Jun 1, 2015, at 11:07 PM, Brad Gibson  wrote:

It would be great if I could choose to see pure black around whatever I'm 
cropping, because I make very meticulous crops of photos for artistic purposes, 
and I often have to crop and go back multiple times because it looks different 
in the final version with solid white/gray/black compared to transparent while 
I'm cropping. Or else, if it's easier, make it so that I can undo the 
finalization of the crop but go back to where I left the crop at. Thanks.Brad G.

Simply add a black layer and put it behind the image



Or Edit>Preferences>Display>Transparency>Check style>Black only
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


Re: [Gimp-developer] Cropping border color

2015-06-02 Thread Burnell West

> On Jun 1, 2015, at 11:07 PM, Brad Gibson  wrote:
> 
> It would be great if I could choose to see pure black around whatever I'm 
> cropping, because I make very meticulous crops of photos for artistic 
> purposes, and I often have to crop and go back multiple times because it 
> looks different in the final version with solid white/gray/black compared to 
> transparent while I'm cropping. Or else, if it's easier, make it so that I 
> can undo the finalization of the crop but go back to where I left the crop 
> at. Thanks.Brad G.
Simply add a black layer and put it behind the image
> ___
> gimp-developer-list mailing list
> List address:gimp-developer-list@gnome.org
> List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
> List archives:   https://mail.gnome.org/archives/gimp-developer-list

___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list


[Gimp-developer] Cropping border color

2015-06-01 Thread Brad Gibson
It would be great if I could choose to see pure black around whatever I'm 
cropping, because I make very meticulous crops of photos for artistic purposes, 
and I often have to crop and go back multiple times because it looks different 
in the final version with solid white/gray/black compared to transparent while 
I'm cropping. Or else, if it's easier, make it so that I can undo the 
finalization of the crop but go back to where I left the crop at. Thanks.Brad G.
___
gimp-developer-list mailing list
List address:gimp-developer-list@gnome.org
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list